By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 920

Summary:	Build issue: avahi-tqt FTBFS
Product:	TDE	Reporter:	Darrell <darrella>
Component:	other (any)	Assignee:	Timothy Pearson <kb9vqf>
Status:	RESOLVED FIXED
Severity:	blocker	CC:	bugwatch, darrella, drfiemost
Priority:	P1
Version:	R14.0.0 [Trinity]
Hardware:	Other
OS:	Other
Compiler Version:		TDE Version String:
Application Version:		Application Name:
Attachments:	Patch for Makefile.am Updated patch to build avahi-tqt without failures Build log for avahi-tqt

Description Darrell 2012-03-16 16:19:28 CDT

Created attachment 497 [details]
Patch for Makefile.am

avahi-tqt fails to build. I have avahi 0.6.30 installed.

The build fails with this message:

==========================================================
make[1]: Entering directory `/dev/shm/avahi-tqt'
test -z "avahi-tqt.pc" || rm -f avahi-tqt.pc
rm -rf .libs _libs
rm -f *.lo
make[1]: Leaving directory `/dev/shm/avahi-tqt'
make  all-recursive
make[1]: Entering directory `/dev/shm/avahi-tqt'
Making all in avahi-tqt
make[2]: Entering directory `/dev/shm/avahi-tqt/avahi-tqt'
  GEN    qt-watch.moc3
TQt meta object compiler
moc: Too many input files specified
Usage:  moc [options] <header-file>
        -o file    Write output to file rather than stdout
        -f[file]   Force #include, optional file name
        -p path    Path prefix for included file
        -i         Do not generate an #include statement
        -k         Do not stop on errors
        -nw        Do not display warnings
        -v         Display version of moc
make[2]: *** [qt-watch.moc3] Error 1
make[2]: Leaving directory `/dev/shm/avahi-tqt/avahi-tqt'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/dev/shm/avahi-tqt'
make: *** [all] Error 2
==========================================================

I then patch the avahi-tqt/Makefile.am as mentioned here:

http://trinity-devel.pearsoncomputing.net/?0::6608

I am attaching the patch.

Yet the build still fails:

==========================================================
Making clean in avahi-tqt
make[1]: Entering directory `/dev/shm/avahi-tqt/avahi-tqt'
test -z "qt-watch.moc3" || rm -f qt-watch.moc3
test -z "libavahi-tqt.la" || rm -f libavahi-tqt.la
rm -f "./so_locations"
rm -rf .libs _libs
rm -f *.o
rm -f *.lo
make[1]: Leaving directory `/dev/shm/avahi-tqt/avahi-tqt'
Making clean in .
make[1]: Entering directory `/dev/shm/avahi-tqt'
test -z "avahi-tqt.pc" || rm -f avahi-tqt.pc
rm -rf .libs _libs
rm -f *.lo
make[1]: Leaving directory `/dev/shm/avahi-tqt'
make  all-recursive
make[1]: Entering directory `/dev/shm/avahi-tqt'
Making all in avahi-tqt
make[2]: Entering directory `/dev/shm/avahi-tqt/avahi-tqt'
  GEN    qt-watch.moc3
qt-watch.cpp:50: Error: The declaration of the class "AvahiWatch" contains signals or slots
         but no TQ_OBJECT macro.
qt-watch.cpp:69: Error: The declaration of the class "AvahiTimeout" contains signals or slots
         but no TQ_OBJECT macro.
make[2]: *** [qt-watch.moc3] Error 1
make[2]: Leaving directory `/dev/shm/avahi-tqt/avahi-tqt'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/dev/shm/avahi-tqt'
make: *** [all] Error 2
==========================================================

Comment 1 Leandro Nini 2012-04-06 04:14:02 CDT

Just change Q_OBJECT to TQ_OBJECT in avahi-tqt/qt-watch.cpp
Not sure if this is compatible with Qt3 but it looks like building on Qt3 is unsupported anyway.

Comment 2 Darrell 2012-04-06 12:27:49 CDT

Created attachment 520 [details]
Updated patch to build avahi-tqt without failures

Yes, changing Q_OBJECT to TQ_OBJECT did the trick. Thank you!

I don't know to make this kind of patch conditional in the builds. There has not been any offical word that building against Qt3 no longer is supported. If we had such an announcment then I could push the patch to GIT as is. If building against Qt3 remains supported then the patch needs some kind of preprocessor test to distinguish between TQt3 and Qt3 before applying the changes.

I am updating the patch attachment.

Comment 3 Darrell 2012-04-07 21:03:36 CDT

avahi-tqt will not build against Qt3 when the attached patch is used. avahi-tqt builds without error against Qt3 without the patch.

avahi-tqt will not build against TQt3 without the patch.

Therefore this patch needs to be revised to distinguish between the two environments.

Comment 4 Timothy Pearson 2012-06-09 01:05:40 CDT

The root cause of this failure is actually that the configure script doesn't properly search for TQt, then Qt3, and also that it does not abort if the tqtinterface-provided moc is not found.  This should be fixed in GIT hash 1817318.

Comment 5 Darrell 2012-06-09 10:05:49 CDT

Thanks. I pulled the latest for avahi-tqt (GIT hash 1817318). With no patches I receive the following build failure:

configure: error: Could not find moc-tqt

This is building against TQt3.

Comment 6 Timothy Pearson 2012-06-09 13:43:18 CDT

(In reply to comment #5)
> Thanks. I pulled the latest for avahi-tqt (GIT hash 1817318). With no patches I
> receive the following build failure:
> 
> configure: error: Could not find moc-tqt
> 
> This is building against TQt3.

Do you have moc-tqt installed in a non-standard location?  If so, configure.ac may need to be modified to accept a moc-tqt search directory.

Comment 7 Darrell 2012-06-09 20:07:53 CDT

Created attachment 651 [details]
Build log for avahi-tqt

/usr/bin/moc-tqt.

Attached is a build log.

Comment 8 Timothy Pearson 2012-06-09 20:17:18 CDT

Update pushed in GIT hash 7b10d93.

Comment 9 Darrell 2012-06-09 21:32:09 CDT

Latest patch did the trick. Thank you!