By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 937

Summary:	Build issue: tderadio: unknown icon type
Product:	TDE	Reporter:	Darrell <darrella>
Component:	other (any)	Assignee:	Timothy Pearson <kb9vqf>
Status:	RESOLVED FIXED
Severity:	minor	CC:	bugwatch, darrella, kb9vqf, michele.calgaro
Priority:	P1
Version:	R14.0.0 [Trinity]
Hardware:	Other
OS:	Other
Compiler Version:		TDE Version String:
Application Version:		Application Name:
Attachments:	Patch to fix messages

Description Darrell 2012-03-26 19:45:46 CDT

From the configure log:

unknown icon prefix lo64 in kradio3/icons/Makefile.in
unknown icon prefix hi24 in kradio3/icons/Makefile.in
unknown icon prefix lo48 in kradio3/icons/Makefile.in
unknown icon prefix lo24 in kradio3/icons/Makefile.in
unknown icon type  in kradio3/plugins/alsa-sound/icons/Makefile.in (kradio_alsa2.png)
unknown icon type  in kradio3/plugins/alsa-sound/icons/Makefile.in (kradio_alsa.png)
unknown icon prefix hi256 in kradio3/plugins/recording/icons/Makefile.in
unknown icon prefix hi330 in kradio3/plugins/timecontrol/icons/Makefile.in

Comment 1 Michele Calgaro 2013-11-26 23:54:02 CST

Just for reference info only, this is now tderadio

Comment 2 Darrell 2013-11-27 01:06:29 CST

>Just for reference info only, this is now tderadio
Yup --- some of these bug reports are getting old. :-)

Here is an updated list from the tderadio build log:

unknown icon prefix lo48 in tderadio3/icons/Makefile.in
unknown icon prefix lo64 in tderadio3/icons/Makefile.in
unknown icon prefix hi24 in tderadio3/icons/Makefile.in
unknown icon prefix lo24 in tderadio3/icons/Makefile.in
unknown icon type  in tderadio3/plugins/alsa-sound/icons/Makefile.in (tderadio_alsa2.png)
unknown icon type  in tderadio3/plugins/alsa-sound/icons/Makefile.in (tderadio_alsa.png)
unknown icon prefix hi256 in tderadio3/plugins/recording/icons/Makefile.in
unknown icon prefix hi330 in tderadio3/plugins/timecontrol/icons/Makefile.in

Comment 3 Darrell 2013-12-03 13:18:00 CST

Created attachment 1694 [details]
Patch to fix messages

Comment 4 Michele Calgaro 2013-12-04 00:28:15 CST

(In reply to comment #3)
> Created attachment 1694 [details]
> Patch to fix messages

Hi Darrell, I think this patch needs some rework.
The files tderadio_alsa.png tderadio_alsa2.png are icons, representing the same image of the other icons in the same folder but with different size. IMO we should follow the same naming pattern, renaming the files to
hi129-action-tderadio_alsa.png and hi109-action-tderadio_alsa2.png for consistency

Comment 5 Darrell 2013-12-04 08:58:40 CST

There is no such thing as hi129 or hi109. For bitmapped icons, the only supported sizes are 16, 22, 32, 48, 64, 128, 256.

Comment 6 Darrell 2013-12-04 11:09:36 CST

Where do the tderadio_alsa*.png files install on your system unpatched?

Unpatched on my system, they install to /opt/trinity/share/icons/hicolor/ZZxZZ/actions, where ZZ is 16, 22, 32, 48, and 64. Likewise for the tderadio_zzz and tderadio_kalarm png images.

In my patched package all of those png files install to the same location. The file structure of my patched package is the same as my unpatched package. Whether the patch is correct or incorrect, seems the patch is consistent? :-)

Comment 7 Michele Calgaro 2013-12-04 21:58:49 CST

> In my patched package all of those png files install to the same location. The
> file structure of my patched package is the same as my unpatched package.
> Whether the patch is correct or incorrect, seems the patch is consistent? :-)

The more I work on TDE the more I learn :) On second thought, I agree with your view. Patch works ok here too.

Comment 8 Timothy Pearson 2013-12-17 23:39:46 CST

Patch looks reasonable to me; go ahead and commit to GIT when ready.

Comment 9 Darrell 2013-12-18 16:12:05 CST

This requires modifying admin/am_edit, which actually is derived from common/admin. We need to split this patch into two and then coordinate with the next patch session of common.

Comment 10 Darrell 2013-12-23 15:47:24 CST

tderadio/admin/am_edit was resolved with the recent common module patch updates from Dec. 22-23.

The remainder of the patch in attachment 1694 [details] was pushed to git in commit 90101231.