By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 957

Summary:	Build issue: kipi-plugins fails to build - error: redeclaration of 'TQListViewItemIterator it'
Product:	TDE	Reporter:	David C. Rankin <trin>
Component:	other (any)	Assignee:	Timothy Pearson <kb9vqf>
Status:	RESOLVED FIXED
Severity:	critical	CC:	bugwatch, darrella
Priority:	P5
Version:	R14.0.0 [Trinity]
Hardware:	All
OS:	Linux
Compiler Version:		TDE Version String:
Application Version:		Application Name:

Description David C. Rankin 2012-04-04 23:48:00 CDT

all,

  Looks like http://git.trinitydesktop.org/cgit/kipi-plugins/commit/?id=21b5bfab4d2467a0f644d653e12f169ea4afcaaf is the responsible commit that broke building. I see the iterator received a number of tweaks there. The following is how that change manifests itself in the build. This is a no-patches build in 4/04 GIT code. The problem looks to be that TQValueList<KURL>::const_iterator it' was previously declared and choked when it was declared again within flickrtalker.cpp:

libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../.. -I/opt/trinity/include -I/opt/trinity/include -I../../kipi-plugins/common/include -I/opt/trinity/include -I/opt/trinity/include -I/opt/tqt3/include -I. -include tqt.h -I/opt/trinity/include/tde -DQT_THREAD_SUPPORT -D_REENTRANT -Wno-long-long -Wundef -ansi -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -Wcast-align -Wchar-subscripts -Wall -W -Wpointer-arith -fno-builtin -g3 -fno-inline -march=x86-64 -mtune=generic -O2 -pipe -fstack-protector --param=ssp-buffer-size=4 -D_FORTIFY_SOURCE=2 -fpermissive -fpermissive -Wformat-security -Wmissing-format-attribute -Wno-non-virtual-dtor -fno-exceptions -fno-check-new -fno-common -I/usr/include/tqt -DQT_CLEAN_NAMESPACE -DQT_NO_ASCII_CAST -DQT_NO_STL -DQT_NO_COMPAT -DQT_NO_TRANSLATION -MT login.lo -MD -MP -MF .deps/login.Tpo -c login.cpp  -fPIC -DPIC -o .libs/login.o
In file included from /opt/trinity/include/kfileitem.h:31:0,
                 from /opt/trinity/include/kio/previewjob.h:27,
                 from imageslist.cpp:42:
/opt/trinity/include/kfilemetainfo.h:1237:34: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
mv -f .deps/login.Tpo .deps/login.Plo
/bin/sh ../../libtool --tag=CXX   --mode=compile g++ -DHAVE_CONFIG_H -I. -I../.. -I/opt/trinity/include   -I/opt/trinity/include   -I../../kipi-plugins/common/include -I/opt/trinity/include   -I/opt/trinity/include -I/opt/tqt3/include -I. -include tqt.h  -I/opt/trinity/include/tde  -DQT_THREAD_SUPPORT  -D_REENTRANT  -Wno-long-long -Wundef -ansi -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -Wcast-align -Wchar-subscripts -Wall -W -Wpointer-arith -fno-builtin -g3 -fno-inline -march=x86-64 -mtune=generic -O2 -pipe -fstack-protector --param=ssp-buffer-size=4 -D_FORTIFY_SOURCE=2 -fpermissive -fpermissive -Wformat-security -Wmissing-format-attribute -Wno-non-virtual-dtor -fno-exceptions -fno-check-new -fno-common -I/usr/include/tqt -DQT_CLEAN_NAMESPACE -DQT_NO_ASCII_CAST -DQT_NO_STL -DQT_NO_COMPAT -DQT_NO_TRANSLATION  -MT flickrtalker.lo -MD -MP -MF .deps/flickrtalker.Tpo -c -o flickrtalker.lo flickrtalker.cpp
imageslist.cpp: In member function 'void KIPIFlickrExportPlugin::ImagesList::slotAddImages(const KURL::List&)':
imageslist.cpp:231:35: error: redeclaration of 'TQListViewItemIterator it'
imageslist.cpp:223:36: error: 'TQValueList<KURL>::const_iterator it' previously declared here
libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../.. -I/opt/trinity/include -I/opt/trinity/include -I../../kipi-plugins/common/include -I/opt/trinity/include -I/opt/trinity/include -I/opt/tqt3/include -I. -include tqt.h -I/opt/trinity/include/tde -DQT_THREAD_SUPPORT -D_REENTRANT -Wno-long-long -Wundef -ansi -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -Wcast-align -Wchar-subscripts -Wall -W -Wpointer-arith -fno-builtin -g3 -fno-inline -march=x86-64 -mtune=generic -O2 -pipe -fstack-protector --param=ssp-buffer-size=4 -D_FORTIFY_SOURCE=2 -fpermissive -fpermissive -Wformat-security -Wmissing-format-attribute -Wno-non-virtual-dtor -fno-exceptions -fno-check-new -fno-common -I/usr/include/tqt -DQT_CLEAN_NAMESPACE -DQT_NO_ASCII_CAST -DQT_NO_STL -DQT_NO_COMPAT -DQT_NO_TRANSLATION -MT flickrtalker.lo -MD -MP -MF .deps/flickrtalker.Tpo -c flickrtalker.cpp  -fPIC -DPIC -o .libs/flickrtalker.o
make[3]: *** [imageslist.lo] Error 1
make[3]: *** Waiting for unfinished jobs....
mv -f .deps/plugin_flickrexport.Tpo .deps/plugin_flickrexport.Plo
mv -f .deps/flickrwindow.Tpo .deps/flickrwindow.Plo
mv -f .deps/flickrtalker.Tpo .deps/flickrtalker.Plo
make[3]: Leaving directory `/build/src/kipi-plugins/kipi-plugins/flickrexport'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/build/src/kipi-plugins/kipi-plugins'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/build/src/kipi-plugins'

Comment 1 David C. Rankin 2012-04-05 13:28:32 CDT

Forget about the suspect commit -- the problem appears to gcc 4.7 in addition to the normal bugs that kipi-plugins has that prevents gwenview and digikam from finding kipi-plugins and building hooks for them. This bug will remain for kipi-plugins patches, etc.. related to it not being found and hooks built by other applications. The gcc 4.7 stuff will be moved to a separate bug.

Comment 2 David C. Rankin 2012-04-10 18:03:51 CDT

TQListViewItemIterator it( d->listView );

is declared multiple times in the following kipi-plugins files:

gpssync/gpssyncdialog.cpp
flickrexport/imageslist.cpp

From Darrell's look at it:

The declaration of TQListViewItemIterator it(d->listView); occurs five times, each time in a different function.

Apparently in function slotAddImages the declaration is seen twice. Once from the explicit declaration and once indirectly through a call to one of the other functions.

Comment 3 Darrell 2012-04-27 23:29:53 CDT

Patch pushed in GIT hash 9f6d6300. Resolved.

Thank you!