| Summary: | Build issue: kvirc package is unusable | ||
|---|---|---|---|
| Product: | TDE | Reporter: | Slávek Banko <slavek.banko> |
| Component: | non-core programs | Assignee: | Timothy Pearson <kb9vqf> |
| Status: | RESOLVED FIXED | ||
| Severity: | blocker | CC: | albator78, bugwatch, darrella |
| Priority: | P5 | ||
| Version: | 3.5.13 [Trinity] | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Compiler Version: | TDE Version String: | ||
| Application Version: | Application Name: | ||
| Bug Depends on: | |||
| Bug Blocks: | 991 | ||
| Attachments: |
Fix commit e45ba8e
Fix hard-coded path /opt/kde3 Fixed compile support for TDE and subsequent FTBFS Removed additional moving of service files Fix hard-coded path /opt/kde3, compile support for TDE and subsequent FTBFS |
||
|
Description
Slávek Banko
2012-04-26 12:04:20 CDT
This should be fixed in packaging GIT hash e45ba8e. Thanks for reporting! (Odpověď na komentář #1) > This should be fixed in packaging GIT hash e45ba8e. > > Thanks for reporting! With the packaging is still something wrong. For the i386 is okay, but for amd64 modules still missing. https://quickbuild.pearsoncomputing.net/~slavek-banko/+archive/axis/+build/36589 https://quickbuild.pearsoncomputing.net/~slavek-banko/+archive/axis/+build/36587 https://quickbuild.pearsoncomputing.net/~slavek-banko/+archive/axis/+packages?field.name_filter=kvirc Created attachment 569 [details]
Fix commit e45ba8e
Previous fix did not work when compiling only platform-dependent part of the package. Therefore, the revision corrects your fix - adding common-install-arch.
(In reply to comment #3) > Created attachment 569 [details] > Fix commit e45ba8e > > Previous fix did not work when compiling only platform-dependent part of the > package. Therefore, the revision corrects your fix - adding > common-install-arch. Committed to GIT in hash 5ece516. Thanks for the patch! (Odpověď na komentář #4)
> Committed to GIT in hash 5ece516.
>
> Thanks for the patch!
Sorry, but I have to open the bug again. The files are already successfuly in the package, but inside the program is tightly written path /opt/kde3/
I found another problem with compilation - package is not compiled with support for KDE/Trinity and the arts: checking if KDE support is requested... yes checking for the general KDE directory... failed...continuing with normal checks checking for KDE services directory... unknown checking for the KDE libraries... "FAILED" . . checking if Arts support is requested... no KDE so no Arts Created attachment 601 [details]
Fix hard-coded path /opt/kde3
But it is essential that starttde had exported variable TDEDIR.
Created attachment 606 [details]
Fixed compile support for TDE and subsequent FTBFS
Created attachment 607 [details]
Removed additional moving of service files
Due to the fact that kvirc is compiled with support for TDE, service files are installed in the correct place during compilation. No need to move further, during packaging.
The "Fix hard-coded path /opt/kde3" will not work for distributions that use "lib64" folder instead of "lib". There is also a list of hardcoded path in src/kvirc/kernel/kvi_app_setup.cpp . This list is missing "/opt/trinity". Kvirc is tricky to build. You can see the procedure I use in Redhat/Fedora here: http://git.trinitydesktop.org/cgit/tde-packaging/tree/redhat/applications/kvirc/trinity-kvirc.spec Created attachment 615 [details]
Fix hard-coded path /opt/kde3, compile support for TDE and subsequent FTBFS
Inspired by Francois solution, I have prepared a new solution - using automake. With acinclude are written into config.h paths KDE_DIR and KDE_LIBDIR, which are subsequently used in the code - instead of hard-coded paths. I also incorporated FTBFS because of missing link libraries (from Francois) - but are linked only if it is compiled with support for TDE.
(In reply to comment #11) > Created attachment 615 [details] > Fix hard-coded path /opt/kde3, compile support for TDE and subsequent FTBFS > > Inspired by Francois solution, I have prepared a new solution - using automake. > With acinclude are written into config.h paths KDE_DIR and KDE_LIBDIR, which > are subsequently used in the code - instead of hard-coded paths. I also > incorporated FTBFS because of missing link libraries (from Francois) - but are > linked only if it is compiled with support for TDE. Patch looks sane; updated for latest GIT HEAD and committed in GIT hash 136d2c8. Thanks! (Odpověď na komentář #12) > Patch looks sane; updated for latest GIT HEAD and committed in GIT hash > 136d2c8. > > Thanks! Still need to apply the patch to clean up the rules in compiling Debian/Ubuntu packages - see attachment 607 [details]. (In reply to comment #13) > (Odpověď na komentář #12) > > Patch looks sane; updated for latest GIT HEAD and committed in GIT hash > > 136d2c8. > > > > Thanks! > > Still need to apply the patch to clean up the rules in compiling Debian/Ubuntu > packages - see attachment 607 [details]. Committed to tde-packaging GIT in hash 22ce2a3. Have I forgotten anything else? ;-) |