By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 1023 - [Regression] KControl does not use the correct icon size
Summary: [Regression] KControl does not use the correct icon size
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: tdebase (show other bugs)
Version: R14.0.x [Trinity]
Hardware: Other Other
: P1 normal
Assignee: Timothy Pearson
URL:
Depends on:
Blocks: R14.0.11
  Show dependency tree / graph
 
Reported: 2012-06-07 13:18 CDT by Darrell
Modified: 2021-08-09 05:11 CDT (History)
5 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
Example of wrong icon size in module heading (171.44 KB, image/png)
2012-06-07 13:18 CDT, Darrell 		Details
Screen grab: Missing icon for Web Browser (167.47 KB, image/png)
2012-06-07 13:20 CDT, Darrell 		Details
Screen grab: Missing icon for Information (139.21 KB, image/png)
2012-06-07 13:20 CDT, Darrell 		Details
Example of wrong icon size in module heading (145.43 KB, image/png)
2012-06-07 13:21 CDT, Darrell 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darrell 2012-06-07 13:18:56 CDT 
Created attachment 645 [details]
Example of wrong icon size in module heading

When using kcontrol in tree mode, kcontrol does not use the correct icon size for the module heading. I'll attach some sample screen grabs.

There does not seem to be any pattern which size is used, as seen by the attached screen grabs. The icon sizes vary from module to module.

All icon sizes are installed and available.

Seems the icon size for module headings should be 22x22. My reasoning is the module items use 16x16 but the module heading text is bolded and larger than the module item text. Using 22x22 will match the module heading text size.

I'm filing this bug report as a regression because 3.5.10 does not exhibit this problem.

Two more quirks:

* Internet & Network -> Web Browser has no icon.

* Peripherals -> Information has no icon.

The missing Web Browser icon occurs in 3.5.10 too and that bug is not a regression. The missing Information icon is new because that module item comes from the old KInfoCenter. Nonetheless, finding the cause of one missing icon likely resolves the other too. Again, all icon sizes are installed and available.

None of these problems occur in icon view mode, but in that view mode there are no module listings in the right size pane.

The bugs were confirmed by two users in the developer's mail list.

None of the bugs in this report affect usability, but they do affect our image. :-)
Comment 1 Darrell 2012-06-07 13:20:19 CDT 
Created attachment 646 [details]
Screen grab: Missing icon for Web Browser
Comment 2 Darrell 2012-06-07 13:20:48 CDT 
Created attachment 647 [details]
Screen grab: Missing icon for Information
Comment 3 Darrell 2012-06-07 13:21:15 CDT 
Created attachment 648 [details]
Example of wrong icon size in module heading
Comment 4 Slávek Banko 2012-06-07 13:23:57 CDT 
It really is regression?
In the 3.5.10 it was okay?
Comment 5 Darrell 2012-06-07 13:29:41 CDT 
In 3.5.10 all module heading icons are the same size, 16x16. No abnormal icons sizes.

I'll be content if we restore the TDE behavior to 16x16, although in my original report I suggested 22x22 --- to match the slightly larger text size used in the module heading.

I tried hard looking through the code for anything obvious, but I'm not a C++ guru. :-( Possibly somebody like you will see something obvious. :-)

I do not have a 3.5.13 or 3.5.12 test environment. I am curious whether the bugs are present in those releases.
Comment 6 Timothy Pearson 2012-06-07 13:40:17 CDT 
This looks like an Ubuntu "fix" (i.e. an attempt to make the desktop more clunky in appearance) that was accidentally ingested into the TDE source tree.  It is probably as simple as an incorrect icon size request somewhere in the kcontrol sources.
Comment 7 Slávek Banko 2012-06-07 14:02:20 CDT 
(Odpověď na komentář #5)
> I do not have a 3.5.13 or 3.5.12 test environment. I am curious whether the
> bugs are present in those releases.

I can confirm it on both 3.5.13.1 and 3.5.12.
Comment 8 Darrell 2012-06-07 14:15:44 CDT 
If the icon bugs exist in 3.5.12, and based upon Tim's comment and hunch, we should look at the patches before 3.5.12. 3.5.12 was released October 3, 2010.

However, that search might be fruitless because the original Trinity source code base was from Ubuntu/Debian. :-) Possibly then the icon bugs existed in Trinity from the beginning of the Trinity project. Possibly comparing the 3.5.11 kcontrol code to 3.5.10 might reveal the difference. I have a copy of the 3.5.11 tarball and will try comparing the sources.

The missing icon for Web Browser is inherited from 3.5.10. I don't know why the same thing happens for Information.
Comment 9 Timothy Pearson 2012-06-07 16:02:14 CDT 
(In reply to comment #8)
> If the icon bugs exist in 3.5.12, and based upon Tim's comment and hunch, we
> should look at the patches before 3.5.12. 3.5.12 was released October 3, 2010.
> 
> However, that search might be fruitless because the original Trinity source
> code base was from Ubuntu/Debian. :-) 

Actually no this is not the case, though this is a common misconception. ;-)

The TDE project initialised its repositories with a full and exact copy of KDE 3.5.10, then applied a large patchset with unfortunately included some Ubuntu/Debian-specific patches.  This is primarily due to the history of the project, which started on Debian/Ubuntu and grew to a "real" distribution-agnostic project shortly after the 3.5.11 release.
Comment 10 Darrell 2012-06-07 16:10:52 CDT 
My apologies for the misconception!

Sounds then that comparing 3.5.11 to 3.5.10 might lead to the culprit for this bug report.
Comment 11 Michele Calgaro 2021-08-08 20:58:17 CDT 
As far as I can say, all icons in TCC are now ok except 3 icons in TDE Components (Resources, Service Manager and Spell Checker) which show up as unknown icons.
Comment 12 gregory guy 2021-08-09 04:12:52 CDT 
(In reply to Michele Calgaro from comment #11)
> As far as I can say, all icons in TCC are now ok except 3 icons in TDE
> Components (Resources, Service Manager and Spell Checker) which show up as
> unknown icons.

I've got all three under Ubuntu:
- Resources --> /opt/trinity/share/icons/crystalsvg/16x16/actions/identity.png
- Service Manager --> /opt/trinity/share/icons/crystalsvg/16x16/actions/flag.png
- Spell Checker --> /opt/trinity/share/icons/crystalsvg/16x16/actions/tools-check-spelling.png
Comment 13 Michele Calgaro 2021-08-09 04:38:38 CDT 
I have the icons installed and I can see them in the left treeview and in the individual modules. But in the overview page that I get if I click TCC-> TDE Compoments, those 3 icons show up as broken icons.
Comment 14 Michele Calgaro 2021-08-09 05:11:03 CDT 
I am going to close this bug, since both Greg and Slavek can see all the icons. Those 3 missing icons is most likely a problem with my own development machine.