By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 1025 - Build issue: Fix covariant return check
Summary: Build issue: Fix covariant return check
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: tdebase (show other bugs)
Version: R14.0.0 [Trinity]
Hardware: All Linux
: P5 major
Assignee: Timothy Pearson
URL:
Depends on:
Blocks:
 
Reported: 2012-06-11 05:08 CDT by Nix
Modified: 2012-06-15 08:32 CDT (History)
2 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
Use check_cxx_source_runs, not check_c_source_runs (1.14 KB, patch)
2012-06-11 05:08 CDT, Nix 		Details | Diff
Include the TQT_CFLAGS in TQT_CXX_FLAGS as well (818 bytes, patch)
2012-06-11 05:09 CDT, Nix 		Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nix 2012-06-11 05:08:26 CDT 
Created attachment 652 [details]
Use check_cxx_source_runs, not check_c_source_runs

The covariant return check fails for two reasons:

 1) it's using check_c_source_runs: C has no covariant return types :)
 2) even if the right language was being used, most of the -I flags are missing because main/common/cmake/modules/FindTQt.cmake is buggy.

Patches attached.
Comment 1 Nix 2012-06-11 05:09:12 CDT 
Created attachment 653 [details]
Include the TQT_CFLAGS in TQT_CXX_FLAGS as well
Comment 2 Darrell 2012-06-13 20:46:15 CDT 
I'm tagging the Summary as a "Build issue" for easier tracking and
identification, and bumping the status to Major.
Comment 3 Timothy Pearson 2012-06-15 01:43:24 CDT 
Comment on attachment 652 [details]
Use check_cxx_source_runs, not check_c_source_runs

Pushed to GIT in hash 33aada3.
Comment 4 Nix 2012-06-15 07:46:00 CDT 
(Note that both of these patches are necessary for covariant checking to work. You probably noticed that, but your wording suggests that you applied-and-pushed only one of them...)
Comment 5 Timothy Pearson 2012-06-15 08:32:35 CDT 
Yes I am aware that both patches are needed; I waited to push the second one to see if I needed to push an unrelated patch to the common/cmake module at the same time.

Second patch committed to GIT in hash 477d071.

Thanks for reporting, and for the patches!