By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 1030 - Ark broken show filenames into real UTF-8 (Cyrillic)
Summary: Ark broken show filenames into real UTF-8 (Cyrillic)
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: tdeutils (show other bugs)
Version: R14.0.0 [Trinity]
Hardware: Other Linux
: P5 major
Assignee: Timothy Pearson
URL:
Depends on:
Blocks:
 
Reported: 2012-06-14 09:22 CDT by Roman Savochenko
Modified: 2012-06-18 19:41 CDT (History)
3 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
Ark FilenameEncode ZipUTFProc patch (1.26 KB, patch)
2012-06-14 09:22 CDT, Roman Savochenko 		Details | Diff
For set global encoding environment, need for ZIP (442 bytes, patch)
2012-06-14 09:45 CDT, Roman Savochenko 		Details | Diff
Use 7zip instead of zip/unzip (436 bytes, patch)
2012-06-16 11:27 CDT, Slávek Banko 		Details | Diff
Ark × ark in kpart (64.79 KB, image/png)
2012-06-16 11:51 CDT, Slávek Banko 		Details
OK: Ark-7Z into konqueror window (55.23 KB, image/png)
2012-06-16 12:13 CDT, Roman Savochenko 		Details
ALTLinux extension ARK patch (37.30 KB, patch)
2012-06-16 15:33 CDT, Roman Savochenko 		Details | Diff
ALTLinux extension ARK patch (36.92 KB, patch)
2012-06-17 00:39 CDT, Roman Savochenko 		Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Savochenko 2012-06-14 09:22:32 CDT 
Created attachment 663 [details]
Ark FilenameEncode ZipUTFProc patch

Into 3.5.10 the problem is missing, but ZIP archive processing actuale also broken.
From 3.5.12 you fix ZIP processing by broken filenames into UTF-8 display, for all archives.

I has fix the problems. Filenames into UTF-8 (Cyrillic) correct display and ZIP correct processing now.

The fix has tested on archives ZIP, ARJ, 7Z and RAR.
Comment 1 Roman Savochenko 2012-06-14 09:45:55 CDT 
Created attachment 664 [details]
For set global encoding environment, need for ZIP
Comment 2 Slávek Banko 2012-06-16 06:48:11 CDT 
I tried the 7zip open in a separate window Ark - works great. But when I open 7zip in Konqeuror as a new tab (uses Ark as kpart) patch has no effect - UTF-8 characters are wrong.
Comment 3 Roman Savochenko 2012-06-16 11:25:12 CDT 
(In reply to comment #2)
> I tried the 7zip open in a separate window Ark - works great. But when I open
> 7zip in Konqeuror as a new tab (uses Ark as kpart) patch has no effect - UTF-8
> characters are wrong.

In my case ark_part.desktop is disabled by default but after it enabling I have seen that correct work everywhere (ark, konqueror, krusader) for all tested archives: ZIP, TAR.GZ, TAR.BZ2, RAR, ARJ, 7Z.
Comment 4 Slávek Banko 2012-06-16 11:27:51 CDT 
Created attachment 667 [details]
Use 7zip instead of zip/unzip

The unzip is another problem. His support for UTF-8 is a bit crappy - when listing the contents of ZIP archives instead of UTF-8 characters is listed '??'. Is there a work-around - instead of zip / unzip use 7z, which works without problems. Is it too daring?
Comment 5 Slávek Banko 2012-06-16 11:51:20 CDT 
Created attachment 668 [details]
Ark × ark in kpart

I use 3.5.13.1 and recompiled just a kdeutils.
Comment 6 Roman Savochenko 2012-06-16 11:54:38 CDT 
(In reply to comment #4)
> The unzip is another problem. His support for UTF-8 is a bit crappy - when
> listing the contents of ZIP archives instead of UTF-8 characters is listed
> '??'. Is there a work-around - instead of zip / unzip use 7z, which works
> without problems. Is it too daring?
Better fix zip/unzip for your Linux distributive. In my distributive, ALTLinux with UTF-8 no any problem present:
[roman@roman tmp]$ unzip -v Прил.1_ТТ.zip
Archive:  Прил.1_ТТ.zip
 Length   Method    Size  Cmpr    Date    Time   CRC-32   Name
--------  ------  ------- ---- ---------- ----- --------  ----
   14076  Defl:N    11594  18% 2012-06-07 21:53 3a5d9451  Дефектная ведомость внутр Прил к ТТ 8-2.xlsx
   11819  Defl:N     9340  21% 2012-06-07 21:54 aeb9331c  Дефектная ведомость фасад - кровля Прил к ТТ 7-1.xlsx
 1266438  Defl:N  1230737   3% 2012-06-07 21:52 249112b8  ПРил.1_ТТ 1-ТПиР-КВВГЭС Приложения  .pdf
  616598  Defl:N   603159   2% 2012-06-07 21:50 a616c66c  Прил.1_ТТ 1-ТПиР-КВВГЭС .pdf
--------          -------  ---                            -------
 1908931          1854830   3%                            4 files
Comment 7 Slávek Banko 2012-06-16 12:00:06 CDT 
I also noticed that the Ark incorrectly parses the output from 7zip - in the name of the file leaves the leading space. Between column of compressed size and column with file names are the two spaces. But Ark removes only one - the second leaves as a part of the filename.

Because it does not work properly with the contents of the archive - eg preview.
Comment 8 Roman Savochenko 2012-06-16 12:13:34 CDT 
Created attachment 669 [details]
OK: Ark-7Z into konqueror window

(In reply to comment #7)
> I use 3.5.13.1 and recompiled just a kdeutils.
For me all correct, use 3.5.13 partially patched from GIT and original ALTLinux patches.
Comment 9 Slávek Banko 2012-06-16 12:15:21 CDT 
What is your locale? You have UTF-8 on the console? I have the cs_CZ.UTF-8. I tried to give just cs_CZ (that mean output in ISO8859-2) and the output from unzip is better, although it would be wrong (ISO × UTF).
Comment 10 Roman Savochenko 2012-06-16 12:20:52 CDT 
(In reply to comment #9)
> What is your locale? You have UTF-8 on the console? I have the cs_CZ.UTF-8. I
> tried to give just cs_CZ (that mean output in ISO8859-2) and the output from
> unzip is better, although it would be wrong (ISO × UTF).

My locale is:
[roman@roman ark]$ env | grep LANG
LANG=uk_UA.UTF-8
Comment 11 Slávek Banko 2012-06-16 12:59:51 CDT 
(Odpověď na komentář #10)
> (In reply to comment #9)
> > What is your locale? You have UTF-8 on the console? I have the cs_CZ.UTF-8. I
> > tried to give just cs_CZ (that mean output in ISO8859-2) and the output from
> > unzip is better, although it would be wrong (ISO × UTF).
> 
> My locale is:
> [roman@roman ark]$ env | grep LANG
> LANG=uk_UA.UTF-8

I found the explanation for unzip:
https://bugzilla.altlinux.org/show_bug.cgi?id=21137

You have also a problem with a leading space in the files names with 7zip in Ark?
Comment 12 Roman Savochenko 2012-06-16 13:45:52 CDT 
> You have also a problem with a leading space in the files names with 7zip in
> Ark?
No I have not that problem. the leading space in name file correct display and open/extract...
Comment 13 Roman Savochenko 2012-06-16 15:33:05 CDT 
Created attachment 670 [details]
ALTLinux extension ARK patch

Combined patch for ARK from ALTLinux.

New functions: ARJ support, TEST archives, Archives password processing.
FIX: File-names into UTF-8 for all archives, LHA unpack check, Single directories pass for RAR and 7Z, some other.
Comment 14 Slávek Banko 2012-06-16 20:06:41 CDT 
Comment on attachment 667 [details]
Use 7zip instead of zip/unzip

There is a solution that corrects unzip - work-around is not needed.
Comment 15 Slávek Banko 2012-06-16 20:13:01 CDT 
It looks good - with 7zip is all already well - for me everything works as it should.
But with zip for me still does not work preview by kpart.
Comment 16 Roman Savochenko 2012-06-16 23:41:37 CDT 
(In reply to comment #15)
> It looks good - with 7zip is all already well - for me everything works as it
> should.
> But with zip for me still does not work preview by kpart.
For ZIP you can and allowed to change file's names encoding by Konqueror menu item "Instruments"->"Network disk encoding" and the encoding selection will be save for further.
Comment 17 Roman Savochenko 2012-06-17 00:34:58 CDT 
Comment on attachment 670 [details]
ALTLinux extension ARK patch

Update patch for ZIP encoding into KPart.
Comment 18 Roman Savochenko 2012-06-17 00:39:27 CDT 
Created attachment 671 [details]
ALTLinux extension ARK patch

>> It looks good - with 7zip is all already well - for me everything works as it
>> should.
>> But with zip for me still does not work preview by kpart.
> For ZIP you can and allowed to change file's names encoding by Konqueror menu
> item "Instruments"->"Network disk encoding" and the encoding selection will be
> save for further.
That is for KIO ZIP. For KPART_ARK_ZIP I have updated the patch.
Comment 19 Slávek Banko 2012-06-17 12:57:34 CDT 
Great, thank you. With the latest version of the patch for me it all works flawlessly. I made a few TQt adjustments to be more consistent patch between 3.5.13.1 and R14.

Fixed in GIT hash 1c84948d (and also in v3.5.13-sru branch).
Sorry - I forgot to thank you in the commit log.
Comment 20 Darrell 2012-06-18 17:32:20 CDT 
Slavek,

The ark portion of the patch pushed in GIT hash 1c84948d causes tdeutils to fail to build:

rar.cpp:191: error: 'KPasswordDialog' has not been declared
Comment 21 Darrell 2012-06-18 18:13:19 CDT 
Note: Reversing the patch from 1c84948d allows tdeutils to build.
Comment 22 Slávek Banko 2012-06-18 18:17:20 CDT 
(Odpověď na komentář #20)
> Slavek,
> 
> The ark portion of the patch pushed in GIT hash 1c84948d causes tdeutils to
> fail to build:
> 
> rar.cpp:191: error: 'KPasswordDialog' has not been declared

Interesting, I tested it with the v3.5.13.1 in Squeeze and Precise and with the current nightly builds in Squeeze and I have no problem encountered.

FTBFS fixed in GIT hash e782ad1b
Comment 23 Darrell 2012-06-18 19:22:07 CDT 
One more patch needed for GIT: hash 219a425c. :-)
Comment 24 Slávek Banko 2012-06-18 19:37:47 CDT 
(Odpověď na komentář #23)
> One more patch needed for GIT: hash 219a425c. :-)

Thank you. For me was compilation successful also before these patches. Therefore, it is difficult for me to find these problems.
Comment 25 Darrell 2012-06-18 19:41:42 CDT 
There must be some no-so-obvious differences between 3.5.13 and GIT. Anyway, all done! :-)