By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 1052 - Fifteenpieces About dialog displays a KDE3 branded image
Summary: Fifteenpieces About dialog displays a KDE3 branded image
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: tdetoys (show other bugs)
Version: R14.0.0 [Trinity]
Hardware: Other Other
: P1 minor
Assignee: Timothy Pearson
URL:
Depends on:
Blocks:
 
Reported: 2012-06-18 02:32 CDT by Darrell
Modified: 2012-10-19 15:19 CDT (History)
2 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name: fifteenpieces

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darrell 2012-06-18 02:32:47 CDT 
The fifteenpieces About dialog does not use the image specified in the respective desktop file.

Only four fifteenpieces.png images exist in the Trinity installation, all crystalsvg. I don't know whether About dialogs are built statically during the build process or dynamically at the time they are requested. Either way the fifteenpieces About dialog is grabbing a KDE3 branded image that I can't find in the sources. There must be a stray KDE3 image in the sources that is being used.

The images displayed in the panel popup menu and applet list box are correct.

1. Find the image being used in the About dialog to update for branding reasons.

2. Fix the About dialog to show the correct image specified in the desktop file.

If I knew which image is being used I'd at least fix that generic image. :-)
Comment 1 Darrell 2012-07-04 23:16:17 CDT 
Turns out this was an interesting bug.

The image is actually updated. The bug appears only in a Trinity-KDE3 system. There, the KDE image is used rather than the Trinity image. In my case, I have KDE3 and Trinity concurrently installed --- the former for reference and comparison testing.

I stumbled across the mysterious KDE3 icon while filing bug report 1081 about the menu search field crashing. While troubleshooting that bug, I needed to restart kicker. Opening the minicli (Alt-F2), and typing 'kicker' revealed the same icon as being used by fifteenpieces. That got me suspicious.

Starting a pristine Trinity system without KDE3 revealed the icon for both the fifteenpieces About dialog and kicker were correct. I then knew something in Trinity was grabbing KDE3 icons rather than Trinity icons and the problem was not a Trinity icon that had not been updated for branding.

The cause turned out to be the same as those patches resolving bug report 892 related to hard-coding. That is, something is looking in */share/applications/kde/*desktop rather than looking in */share/applications/tde/*desktop to find respective icons.

I pushed a patch to resolve the problem (commit 5f382dd7). The patch fixes both the original report with fifteenpieces and with kicker in the minicli dialog.

Although technically that patch fixed the fifteenpieces About dialog, I pushed a second patch so fifteenpieces uses its own icon for its About dialog rather than the kicker icon (commit 394fb8b8). As the About dialog in kweather uses similar code as fifteenpieces, I copied the example from kweather to create the fifteenpieces patch.

Having KDE3 installed concurrently, even if only used occasionally for reference and comparison testing, actually helped expose a weird corner case bug. I don't believe the same thing could not happen with KDE4 because KDE4 uses */share/applications/kde4/ rather than */share/applications/kde/. Nonetheless, the patch for tdebase/kicker makes for a better system and is the right thing to do.

Getting fifteenpieces to use its own icon is proverbial icing on the cake. :-)

Resolved!