By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 1109 - Build issue: Cannot choose QtCurve style
Summary: Build issue: Cannot choose QtCurve style
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: tdebase (show other bugs)
Version: 3.5.13 [Trinity]
Hardware: i386 Debian Squeeze
: P5 minor
Assignee: Timothy Pearson
URL:
Depends on:
Blocks:
 
Reported: 2012-07-16 07:52 CDT by bzanetti00
Modified: 2012-10-19 15:50 CDT (History)
4 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:


Attachments
Build log for 3.5.13-sru on Squeeze (123.62 KB, text/x-makefile)
2012-08-24 06:39 CDT, Slávek Banko
Details
Workaround config module FTBFS (5.90 KB, patch)
2012-08-30 14:35 CDT, Francois Andriot
Details | Diff
Fix inadvertent TQ/Q renaming of #ifdef (8.20 KB, patch)
2012-08-30 14:39 CDT, Francois Andriot
Details | Diff
Initial CMake conversion from KDE3 to TDE (9.24 KB, patch)
2012-08-30 14:41 CDT, Francois Andriot
Details | Diff
Revert TQtCurve to QtCurve and fix build along qt3 (28.12 KB, patch)
2012-09-01 06:11 CDT, Slávek Banko
Details | Diff
Revert TQtCurve to QtCurve and fix build along qt3 (1) (28.15 KB, patch)
2012-09-01 06:18 CDT, Slávek Banko
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description bzanetti00 2012-07-16 07:52:01 CDT
I installed qtcurve-trinity package, along with gtk-qt-engine-trinity and gtk2-engines-qtcurve.
I can select the qtcurve style for gtk+ apps from the Control Center (GTK Styles and Fonts) but not for TDE ones (it doesn't appear anywhere under Styles / Window Decorations / Theme manager / Qt 4 Settings).
I don't know if it's debian specific because I didn't tried other distro.
Comment 1 Slávek Banko 2012-07-16 10:09:36 CDT
It seems that in 3.5.13.x is kde-style-qtcurve compiled incorrectly - style is just as pure qt style. See: QTC_QT_ONLY.

In any case, it is still much better than the R14-nighly because there are packages qtcurve completely broken - there is nothing in them.
Comment 2 Slávek Banko 2012-08-24 06:39:04 CDT
Created attachment 795 [details]
Build log for 3.5.13-sru on Squeeze

I tried to find why qtcurve does not compile as TDE style, but only as "plain QT" style. I added to cmake parameters:
 -DQTC_QT_ONLY=false
 -DQTC_BUILD_CONFIG_MODULE=true
 -DQTC_DEFAULT_TO_KDE3=true

But in build configuration module occurs error.
See build log.
Comment 3 Francois Andriot 2012-08-29 13:58:28 CDT
Hello, it looks like the CMakeLists.txt files are designed to use kde3 macros , not TDE . There are hardcoded path to kde3 etc ... so it can't work in TDE.
I will look into it, but there will be several modifications.
Comment 4 Slávek Banko 2012-08-29 14:16:01 CDT
Okay, I'll try to backport changes for replace CMake to the TDE standard and TQt conversion. Stay tuned :)
Comment 5 Francois Andriot 2012-08-29 15:59:31 CDT
Also, there are FTBFS in the "config" module.
I guess that's why there is an explicit message in the main "CMakeLists.txt":

message("**************************************************************\n"
                "Warning: The KDE3 config module is deprecated, and is no longer\n"
                "         actively maintained. This module NO LONGER COMPILES!\n"
                "         It is recommended to use the KDE4 version instead.\n"
                "**************************************************************\n")

Oh well... either we can build it by disabling unsupported features, or we have to give up with this module ...
Comment 6 Slávek Banko 2012-08-29 16:06:47 CDT
When there is no compiled configuration module, style is compiled only as plain qt3 style, not as a TDE style. See CMakeLists.txt:

if (QTC_BUILD_CONFIG_MODULE)
    if (NOT QTC_QT_ONLY)
        find_package(KDE3)
        if (NOT KDE3_FOUND)
            set(QTC_QT_ONLY true)
            message("INFO: KDE3 not found! Compiling for Qt only! (Not building the config modu
le)")
        endif (NOT KDE3_FOUND)
    endif (NOT QTC_QT_ONLY)
else (QTC_BUILD_CONFIG_MODULE)
    set(QTC_QT_ONLY true)
endif (QTC_BUILD_CONFIG_MODULE)

For this reason, I try to build including config module.
Comment 7 Slávek Banko 2012-08-30 13:30:33 CDT
Packaging for R14 fixed in GIT hash 55642292
Problem in v3.5.13-sru yet remains unresolved.
Comment 8 Francois Andriot 2012-08-30 14:35:45 CDT
Created attachment 798 [details]
Workaround config module FTBFS

The attached patch allow build of "config" module without FTBFS. But at this time I still do not know if it works ...
Comment 9 Francois Andriot 2012-08-30 14:39:24 CDT
Created attachment 799 [details]
Fix inadvertent TQ/Q renaming of #ifdef

It looks like automatic Q/TQ renaming has modified #ifdef variables. This patch reverts the changes.
Comment 10 Francois Andriot 2012-08-30 14:41:40 CDT
Created attachment 800 [details]
Initial CMake conversion from KDE3 to TDE

The attached patch is an attempt to update the CMakeLists.txt files to the TDE-style.
I manage to build qtcurve TDE style with it, but it still does not work at runtime.
Comment 11 Francois Andriot 2012-08-30 14:44:01 CDT
With all 3 attached patches, I'm now building with:

cmake \
	-DTDEPREFIX=/opt/trinity \
	-DTDE_INCLUDE_DIR=/opt/trinity/include/kde \
	-DQTC_QT_ONLY=false \
	-DQTC_BUILD_CONFIG_MODULE=true \
	-DQTC_DEFAULT_TO_KDE3=true \
	-DQTC_STYLE_SUPPORT=true \
	..

And as a result, I get the following files:

/opt/trinity/lib64/trinity/kstyle_qtcurve_config.la
/opt/trinity/lib64/trinity/kstyle_qtcurve_config.so
/opt/trinity/lib64/trinity/plugins/styles/qtcurve.la
/opt/trinity/lib64/trinity/plugins/styles/qtcurve.so
/opt/trinity/share/apps/QtCurve/Agua.qtcurve
/opt/trinity/share/apps/QtCurve/Agua_II.qtcurve
/opt/trinity/share/apps/QtCurve/Curve.qtcurve
/opt/trinity/share/apps/QtCurve/Flat.qtcurve
/opt/trinity/share/apps/QtCurve/Human.qtcurve
/opt/trinity/share/apps/QtCurve/Inverted.qtcurve
/opt/trinity/share/apps/QtCurve/Klearlooks.qtcurve
/opt/trinity/share/apps/QtCurve/Milk.qtcurve
/opt/trinity/share/apps/QtCurve/Murrine.qtcurve
/opt/trinity/share/apps/QtCurve/Ozone.qtcurve
/opt/trinity/share/apps/QtCurve/Plastic.qtcurve
/opt/trinity/share/apps/QtCurve/Silk.qtcurve
/opt/trinity/share/apps/kdisplay/color-schemes/QtCurve.kcsrc
/opt/trinity/share/apps/kstyle/themes/qtcurve.themerc
/opt/trinity/share/doc/trinity-style-qtcurve
/opt/trinity/share/doc/trinity-style-qtcurve/AUTHORS
/opt/trinity/share/doc/trinity-style-qtcurve/COPYING
/opt/trinity/share/locale/tr/LC_MESSAGES/qtcurve.mo

But, I still do not see the "QTcurve" (or TQTCurve) style in the "kcmshell style" dialog box ...
Comment 12 Francois Andriot 2012-08-30 14:49:07 CDT
I forgot to mention, that you need to add the "cmake" submodule in order to build with TDE macros.
Comment 13 Slávek Banko 2012-08-30 19:04:50 CDT
Thank you, I look forward to try it, because with backport patches from R14, I just got into a blind alley.
Comment 14 Slávek Banko 2012-08-31 10:56:18 CDT
François, thank you. With small modifications (tqt I have in /usr/include/tqt, qt in /usr/include/qt3) I have also builded the package!

Then I prepared next patch. And with that QtCurve is working again - I see QtCurve in the style settings, I can select it and style is working.

Now I have to go away - I'll attach my updated patches later.
Comment 15 Slávek Banko 2012-09-01 06:11:15 CDT
Created attachment 801 [details]
Revert TQtCurve to QtCurve and fix build along qt3

François, first faster way, to you could also test the patch. I've noticed that perhaps still not work config window. Please, test it.

Now I try to combine your patches, my patches and backport patches to consolidated patches for v3.5.13-sru.
Comment 16 Slávek Banko 2012-09-01 06:18:36 CDT
Created attachment 802 [details]
Revert TQtCurve to QtCurve and fix build along qt3 (1)

Update: re-added missing #include "qtcurve.moc"
Comment 17 Francois Andriot 2012-09-01 06:37:52 CDT
OK with your latest patch I now have qtcurve in the style chooser window.
I can select and activate it => it works.

I can also open the "configure" window, some settings seem to work, some seems to not. There are too many of them I did not test everything.

Also, I've noticed some settings have label "KDE4 only" or "KDE4/GTK2 only" in this configure window.
Comment 18 Slávek Banko 2012-09-01 07:27:47 CDT
Patches consolidated and settings also work well for me. Wow - such a huge number of settings I did not expect :)

I do not know which of those settings affect really only KDE4. Or which of them also have an influence on TDE. I propose to close this bug report and to move the discussion about them into mailing list.
Comment 19 Francois Andriot 2012-09-02 03:03:02 CDT
I agree, we can close this bug now since the build issue is solved.
If there are usability problems with Qtcurve, we will open another bug report.