By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 1123 - Please add KOrganizer holiday region for Slovakia
Summary: Please add KOrganizer holiday region for Slovakia
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: tdepim (show other bugs)
Version: 3.5.13 [Trinity]
Hardware: All All
: P5 enhancement
Assignee: Timothy Pearson
URL:
Depends on:
Blocks:
 
Reported: 2012-07-23 06:42 CDT by linux
Modified: 2012-10-19 15:45 CDT (History)
3 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description linux 2012-07-23 06:42:49 CDT 
I've created KOrganizer holiday region data file for Slovakia some time ago. Please include it in Trinity. You can get it here:
http://www.rainbow-software.org/linux_files/holiday_sk
Comment 1 Slávek Banko 2012-08-16 07:33:49 CDT 
Please can you compare your file with the one already in the Trinity?
http://git.trinitydesktop.org/cgit/tdepim/tree/libkholidays/holidays/holiday_sk
Comment 2 linux 2012-08-16 07:44:15 CDT 
Is it a new addition? It wasn't in 3.5.13. But that file is wrong, it contains holidays that are NOT holidays and are working days in fact.
Comment 3 Slávek Banko 2012-08-16 07:57:22 CDT 
No, the file is already in 3.5.13. But as I look, it is only in the source tree - not installed == not in the package. Because the your file and file in GIT are different, so that's why I wanted to ask you whether you can compare files, as needed to merge, and then the result I would to push into the GIT.
Comment 4 Slávek Banko 2012-08-20 12:42:44 CDT 
I tried to compare three similar resources:
http://git.trinitydesktop.org/cgit/tdepim/tree/libkholidays/holidays/holiday_sk
https://projects.kde.org/projects/kde/kdepimlibs/repository/revisions/master/entry/kholidays/holidays/plan1/holiday_sk_sk
http://www.rainbow-software.org/linux_files/holiday_sk

The original file in Trinity apparently contains data that is not holidays (in KDE4 file moved to the end of the file). Your file does not contain a "Deň vzniku SR", differ in "Traja králi" × "Zjavenie Pána" and then just differences in abbreviations.

It will suffice if I delete from original file data that are not holidays?
Comment 5 linux 2012-08-20 13:34:04 CDT 
Yes, deleting non-holiday days would be OK.

"Deň vzniku SR" has the same date as "Nový rok" - I don't know if it's OK for KDE/TDE code that works with this data.
Comment 6 Slávek Banko 2012-08-20 13:51:29 CDT 
On my holiday_cz I tested - the two holidays on the same day is not a problem.

Thank you for your cooperation.
I'll update as we agreed and joined him to installed.
Comment 7 Slávek Banko 2012-08-21 19:12:35 CDT 
Fixed in GIT hash cc318898.