By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 1146 - Build issue: fusion-icon does not install python module in python_sitelib
Summary: Build issue: fusion-icon does not install python module in python_sitelib
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: non-core programs (show other bugs)
Version: 3.5.13 [Trinity]
Hardware: All Linux
: P5 normal
Assignee: Michele Calgaro
URL:
Depends on:
Blocks: 2014
  Show dependency tree / graph
 
Reported: 2012-08-04 04:23 CDT by Francois Andriot
Modified: 2014-08-02 03:49 CDT (History)
4 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
Fix installation directory for python module (502 bytes, patch)
2012-08-04 04:26 CDT, Francois Andriot 		Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Francois Andriot 2012-08-04 04:23:29 CDT 
Hello, when building 'fusion-icon', it creates 2 sets of files:
- Icons files, which should go to /opt/trinity/share/icons/XXXX
- Python scripts, which should go to /usr/lib/pythonXXXX

Alas, with the current Makefile, it is only possible to specify a single PREFIX, so that everything goes either under /opt/trinity OR under /usr .
Comment 1 Francois Andriot 2012-08-04 04:26:43 CDT 
Created attachment 749 [details]
Fix installation directory for python module

The build sequence for this package should now be:

# Finds the python library directory
PYTHON_SITELIB="$(python2 -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())")"

# Builds the stuff
make

# Install files in correct locations
make install \
  DESTDIR=/tmp/destdir \
  PREFIX=/opt/trinity \
  PYTHON_SITELIB=${PYTHON_SITELIB}
Comment 2 Timothy Pearson 2014-07-11 12:10:15 CDT 
The current patch looks a bit hacky--the Python directory detection should be included in the Makefile rather than requiring an external command to be run first.

Can we put PYTHON_SITELIB=$((python2 -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())") at the top of the Makefile to set the variable automatically when make is run?
Comment 3 Michele Calgaro 2014-08-01 10:45:36 CDT 
Commit 7aa39b5 fixes the installation location for *non* Debian/Ubuntu distros, introducing auto-detection in the makefile.
Francois, could you test on your system and let me know if it is ok now?

Commit ed3904e (packaging) fixes the installation location for Debian/Ubuntu distros, which do not rely on the makefile to build the package.

The bug should now be solved, but before closing it I will wait for Francois's feedback.
Comment 4 Francois Andriot 2014-08-02 02:38:36 CDT 
Works OK for me.
Comment 5 Michele Calgaro 2014-08-02 03:49:30 CDT 
Thanks for the feedback and for the original patch.