1169 – Build issue: koffice FTBFS with libwpd >= 0.9

By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 1169 - Build issue: koffice FTBFS with libwpd >= 0.9

Summary: Build issue: koffice FTBFS with libwpd >= 0.9

Status:	RESOLVED FIXED

Alias:	None

Product:	TDE
Classification:	Unclassified
Component:	non-core programs (show other bugs)
Version:	3.5.13.2 [Trinity]
Hardware:	Other Other

Importance:	P5 blocker
Assignee:	Timothy Pearson

URL:

Depends on:
Blocks:

Reported:	2012-08-15 13:24 CDT by Darrell
Modified:	2013-04-08 12:43 CDT (History)
CC List:	5 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
Proposed additional patch for libwpd-0.9 (1.61 KB, patch) 2012-09-24 14:28 CDT, Darrell	Details \| Diff
Temporary patch to allow building koffice without kword wordperfct filter (500 bytes, patch) 2012-10-12 12:25 CDT, Darrell	Details \| Diff
koffice 3.5.13.2 : fix wpd 0.9 support (547.65 KB, patch) 2013-04-08 04:40 CDT, Francois Andriot	Details \| Diff
koffice 3.5.13.2 : fix redefinition problems with previous patch (4.74 KB, patch) 2013-04-08 05:40 CDT, Francois Andriot	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Darrell 2012-08-15 13:24:53 CDT

The error:

configure: error: libwpd >= 0.9.0 is not yet supported!

The error message is from koffice/filters/kword/wordperfect/configure.in.in, but koffice/configure.in also tests the libwpd version to set the HAVE_WPD configuration variable.

I don't know what the original authors intended or expected with versions > 0.8.x that they added such a test.

Comment 1 Darrell 2012-09-18 20:33:23 CDT

Looks like there was a patch Aug. 1 in commit 86ea45fe. I still receive the same configure failure. I patched koffice/configure.in the same as in the commit but to no avail. libwpd is installed.

Comment 2 Darrell 2012-09-24 14:28:14 CDT

Created attachment 824 [details]
Proposed additional patch for libwpd-0.9

Deleting the failure message seems to resolve the build failure.

Comment 3 Darrell 2012-09-24 14:45:08 CDT

Possibly additional files will need to be patched to work with libwpd-0.9:

http://lists.kde.org/?l=koffice-devel&m=131010277425751

Comment 4 Timothy Pearson 2012-09-24 15:38:55 CDT

(In reply to comment #2)
> Created attachment 824 [details]
> Proposed additional patch for libwpd-0.9
> 
> Deleting the failure message seems to resolve the build failure.

koffice will not build with libwpd enabled if those lines are removed.  As you pointed out below, some patching has to be done to koffice in order to build against wpd >= 0.9; until this is done the configure check should remain in place.

Comment 5 Darrell 2012-09-24 16:49:34 CDT

Yes, but without the patch the build process never finishes the configure process to get to a point to actually debug where patches are needed with libwpd-0.9.

Comment 6 Darrell 2012-10-11 14:36:21 CDT

Looks a patch for KDE4 koffice exists:

http://cvs.pld-linux.org/cgi-bin/viewvc.cgi/cvs/packages/kde4-koffice/kde4-koffice-libwpdg.patch?r1=1.2&r2=1.3

Comment 7 Darrell 2012-10-12 12:25:26 CDT

Created attachment 876 [details]
Temporary patch to allow building koffice without kword wordperfct filter

This patch is temporary. The patch builds koffice without building the kword wordperfect import filter.

I need to use both attached patches to build koffice in a libwpd-0.9 environment. I do not need either patch in a libwpd-0.8 environment.

These patches are only temporary work-aroundss. When used, kword will not have wordperfect import support, but allows the entire package to build. Yet another example to support enhancement request 464 to split koffice into individual packages. :)

Comment 8 Timothy Pearson 2013-04-05 15:18:57 CDT

Fixed in GIT hash efca154.

Thanks for reporting!

Comment 9 Francois Andriot 2013-04-08 04:40:13 CDT

Created attachment 1143 [details]
koffice 3.5.13.2 : fix wpd 0.9 support

Same patch for 3.5.13.2 .

Comment 10 Francois Andriot 2013-04-08 05:14:44 CDT

Hey now I have FTBFS in wordperfect import filter !

I've already found the problem, patch will follow soon !

In file included from libwpimport_la.all_cxx.cxx:9:0:
WordPerfectCollector.cxx:389:6: error: redefinition of 'void WordPerfectCollector::openPageSpan(const WPXPropertyList&)'
WordPerfectCollector.hxx:96:15: error: 'virtual void WordPerfectCollector::openPageSpan(const WPXPropertyList&)' previously defined here
WordPerfectCollector.cxx:396:6: error: redefinition of 'void WordPerfectCollector::openHeader(const WPXPropertyList&)'
WordPerfectCollector.hxx:98:15: error: 'virtual void WordPerfectCollector::openHeader(const WPXPropertyList&)' previously defined here
WordPerfectCollector.cxx:408:6: error: redefinition of 'void WordPerfectCollector::closeHeader()'
WordPerfectCollector.hxx:99:15: error: 'virtual void WordPerfectCollector::closeHeader()' previously defined here
WordPerfectCollector.cxx:413:6: error: redefinition of 'void WordPerfectCollector::openFooter(const WPXPropertyList&)'
WordPerfectCollector.hxx:100:15: error: 'virtual void WordPerfectCollector::openFooter(const WPXPropertyList&)' previously defined here
WordPerfectCollector.cxx:425:6: error: redefinition of 'void WordPerfectCollector::closeFooter()'
WordPerfectCollector.hxx:101:15: error: 'virtual void WordPerfectCollector::closeFooter()' previously defined here
WordPerfectCollector.cxx:430:6: error: redefinition of 'void WordPerfectCollector::openSection(const WPXPropertyList&, const WPXPropertyListVector&)'
WordPerfectCollector.hxx:109:15: error: 'virtual void WordPerfectCollector::openSection(const WPXPropertyList&, const WPXPropertyListVector&)' previously defined here
WordPerfectCollector.cxx:456:6: error: redefinition of 'void WordPerfectCollector::closeSection()'
WordPerfectCollector.hxx:110:15: error: 'virtual void WordPerfectCollector::closeSection()' previously defined here
In file included from libwpimport_la.all_cxx.cxx:9:0:
WordPerfectCollector.cxx:572:6: error: redefinition of 'void WordPerfectCollector::defineOrderedListLevel(const WPXPropertyList&)'
WordPerfectCollector.hxx:116:15: error: 'virtual void WordPerfectCollector::defineOrderedListLevel(const WPXPropertyList&)' previously defined here
In file included from libwpimport_la.all_cxx.cxx:9:0:
WordPerfectCollector.cxx:613:6: error: redefinition of 'void WordPerfectCollector::defineUnorderedListLevel(const WPXPropertyList&)'
WordPerfectCollector.hxx:117:15: error: 'virtual void WordPerfectCollector::defineUnorderedListLevel(const WPXPropertyList&)' previously defined here
WordPerfectCollector.cxx:640:6: error: redefinition of 'void WordPerfectCollector::openOrderedListLevel(const WPXPropertyList&)'
WordPerfectCollector.hxx:118:15: error: 'virtual void WordPerfectCollector::openOrderedListLevel(const WPXPropertyList&)' previously defined here
WordPerfectCollector.cxx:653:6: error: redefinition of 'void WordPerfectCollector::openUnorderedListLevel(const WPXPropertyList&)'
WordPerfectCollector.hxx:119:15: error: 'virtual void WordPerfectCollector::openUnorderedListLevel(const WPXPropertyList&)' previously defined here
WordPerfectCollector.cxx:681:6: error: redefinition of 'void WordPerfectCollector::closeOrderedListLevel()'
WordPerfectCollector.hxx:120:15: error: 'virtual void WordPerfectCollector::closeOrderedListLevel()' previously defined here
WordPerfectCollector.cxx:686:6: error: redefinition of 'void WordPerfectCollector::closeUnorderedListLevel()'
WordPerfectCollector.hxx:121:15: error: 'virtual void WordPerfectCollector::closeUnorderedListLevel()' previously defined here
WordPerfectCollector.cxx:707:6: error: redefinition of 'void WordPerfectCollector::openListElement(const WPXPropertyList&, const WPXPropertyListVector&)'
WordPerfectCollector.hxx:122:15: error: 'virtual void WordPerfectCollector::openListElement(const WPXPropertyList&, const WPXPropertyListVector&)' previously defined here
WordPerfectCollector.cxx:752:6: error: redefinition of 'void WordPerfectCollector::closeListElement()'
WordPerfectCollector.hxx:123:15: error: 'virtual void WordPerfectCollector::closeListElement()' previously defined here
WordPerfectCollector.cxx:765:6: error: redefinition of 'void WordPerfectCollector::openFootnote(const WPXPropertyList&)'
WordPerfectCollector.hxx:124:15: error: 'virtual void WordPerfectCollector::openFootnote(const WPXPropertyList&)' previously defined here
WordPerfectCollector.cxx:786:6: error: redefinition of 'void WordPerfectCollector::closeFootnote()'
WordPerfectCollector.hxx:125:15: error: 'virtual void WordPerfectCollector::closeFootnote()' previously defined here
WordPerfectCollector.cxx:794:6: error: redefinition of 'void WordPerfectCollector::openEndnote(const WPXPropertyList&)'
WordPerfectCollector.hxx:126:15: error: 'virtual void WordPerfectCollector::openEndnote(const WPXPropertyList&)' previously defined here
WordPerfectCollector.cxx:815:6: error: redefinition of 'void WordPerfectCollector::closeEndnote()'
WordPerfectCollector.hxx:127:15: error: 'virtual void WordPerfectCollector::closeEndnote()' previously defined here
WordPerfectCollector.cxx:823:6: error: redefinition of 'void WordPerfectCollector::openTable(const WPXPropertyList&, const WPXPropertyListVector&)'
WordPerfectCollector.hxx:132:16: error: 'virtual void WordPerfectCollector::openTable(const WPXPropertyList&, const WPXPropertyListVector&)' previously defined here
WordPerfectCollector.cxx:866:6: error: redefinition of 'void WordPerfectCollector::openTableRow(const WPXPropertyList&)'
WordPerfectCollector.hxx:133:16: error: 'virtual void WordPerfectCollector::openTableRow(const WPXPropertyList&)' previously defined here
WordPerfectCollector.cxx:887:6: error: redefinition of 'void WordPerfectCollector::closeTableRow()'
WordPerfectCollector.hxx:134:15: error: 'virtual void WordPerfectCollector::closeTableRow()' previously defined here
WordPerfectCollector.cxx:900:6: error: redefinition of 'void WordPerfectCollector::openTableCell(const WPXPropertyList&)'
WordPerfectCollector.hxx:135:16: error: 'virtual void WordPerfectCollector::openTableCell(const WPXPropertyList&)' previously defined here
WordPerfectCollector.cxx:924:6: error: redefinition of 'void WordPerfectCollector::closeTableCell()'
WordPerfectCollector.hxx:136:15: error: 'virtual void WordPerfectCollector::closeTableCell()' previously defined here
WordPerfectCollector.cxx:933:6: error: redefinition of 'void WordPerfectCollector::insertCoveredTableCell(const WPXPropertyList&)'
WordPerfectCollector.hxx:137:15: error: 'virtual void WordPerfectCollector::insertCoveredTableCell(const WPXPropertyList&)' previously defined here
WordPerfectCollector.cxx:942:6: error: redefinition of 'void WordPerfectCollector::closeTable()'
WordPerfectCollector.hxx:138:16: error: 'virtual void WordPerfectCollector::closeTable()' previously defined here
make[5]: *** [libwpimport_la.all_cxx.lo] Erreur 1

Comment 11 Francois Andriot 2013-04-08 05:40:27 CDT

Created attachment 1144 [details]
koffice 3.5.13.2 : fix redefinition problems with previous patch

Comment 12 Timothy Pearson 2013-04-08 11:40:47 CDT

Changing version to reflect current activity.

Comment 13 Slávek Banko 2013-04-08 12:43:20 CDT

Patch from attachment 1144 [details] pushed to GIT in hash 690b0c72 and also into v3.5.13-sru branch.

Francois, beware: in your preparation patch fix wpd 0.9 support you overlooked and did not remove change from HAVE_KSPELL2_BROKER_H to HAVE_TDESPELL2_BROKER_H - undesirable for v3.5.13-sru branch. In the GIT commit into v3.5.13-sru branch it is fixed.