By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 1238 - TDEFileReplace: add a maxdepth option
Summary: TDEFileReplace: add a maxdepth option
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: non-core programs (show other bugs)
Version: R14.0.0 [Trinity]
Hardware: Other Other
: P5 enhancement
Assignee: Michele Calgaro
URL:
Depends on:
Blocks: R14.1.0
  Show dependency tree / graph
 
Reported: 2012-09-29 00:13 CDT by Darrell
Modified: 2015-01-30 20:31 CST (History)
3 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
Screen capture of new maxdepth option (49.06 KB, image/png)
2015-01-29 14:47 CST, Darrell 		Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darrell 2012-09-29 00:13:18 CDT 
KFileReplace is a really nice utility for searching and replacing multiple lines. Search the web for people requesting help with that problem.

Adding a maxdepth limitation would be really handy when performing a search in a directory that is large or many levels deep.

Although there is an Advanced tab with additional search options, the best place to add the option is a child spinner box in the General tab, in the "Startup Folder Options" group, just under the "Include subfolders" check box. The child spinner box would be ghosted/grayed when the "Include subfolders" check box is disabled.

| | Include subfolders
    < > Max depth

This request was mentioned in the Comment 3 in bug report 693. A separate bug report enhancement request will help ensure the idea is not lost.
Comment 1 Darrell 2012-11-02 22:28:32 CDT 
This utility is powerful and useful. I use this utility often to make multi line changes to Trinity build scripts. The biggest disadvantage is my build scripts all are a part of a comprehensive Trinity build environment. With no maxdepth option, this utility searches the entire environment, which includes the GIT repo.

Yes, I can reorganize my build environment, but that will not resolve this shortcoming of this useful tool. Hence my wish for a maxdepth option and a vote.
Comment 2 Darrell 2015-01-22 23:48:24 CST 
Update the summary.
Comment 3 Michele Calgaro 2015-01-27 21:23:11 CST 
It's a good idea, definitely something that could be useful to the user.
Comment 4 Michele Calgaro 2015-01-28 22:25:22 CST 
Fixed in commit 570104c.
Comment 5 Darrell 2015-01-29 14:47:05 CST 
Created attachment 2442 [details]
Screen capture of new maxdepth option

On my Slackware 14.1 system, the Location and Filter drop-down widgets are squished to the far right of the dialog. Previously the two widgets would spread across the dialog. A before/after screenshot is attached.
Comment 6 Michele Calgaro 2015-01-29 16:50:17 CST 
> On my Slackware 14.1 system, the Location and Filter drop-down widgets are
> squished to the far right of the dialog
Thanks for noticing that. 
Fixed in commit 08d91f5.
Comment 7 Darrell 2015-01-29 18:11:23 CST 
>Fixed in commit 08d91f5.
Looks better. Thanks. :)
Comment 8 Michele Calgaro 2015-01-29 23:06:45 CST 
Implementation is incomplete: need to fix the code for the search-and-replace functionality.
Comment 9 Michele Calgaro 2015-01-30 01:46:06 CST 
This should be fixed in commit 23b906b.
Darrell, I will leave the bug open until you have tested in your 6.3 GiB folder
Comment 10 Darrell 2015-01-30 07:54:41 CST 
I tested same as yesterday but with maxdepth=3. The Search/Replace completed in several seconds.

I can't think of anything else to test this.
Comment 11 Michele Calgaro 2015-01-30 20:31:06 CST 
Ok, then I am closing the bug once again.