By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 1243 - Build issue: kdesdk 3.5.13.1 FTBFS
Summary: Build issue: kdesdk 3.5.13.1 FTBFS
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: tdesdk (show other bugs)
Version: 3.5.13 [Trinity]
Hardware: All Linux
: P5 blocker
Assignee: Timothy Pearson
URL:
Depends on:
Blocks:
 
Reported: 2012-09-30 13:14 CDT by Francois Andriot
Modified: 2012-10-13 10:08 CDT (History)
3 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
kdesdk: fix build of kdecachegrind (489.00 KB, patch)
2012-09-30 14:18 CDT, Francois Andriot 		Details | Diff
kdesdk: fix 'x-kcachegrind.desktop' file installation (631 bytes, patch)
2012-09-30 14:28 CDT, Francois Andriot 		Details | Diff
kdesdk: fix 'x-kcachegrind.desktop' file installation (2) (729 bytes, patch)
2012-09-30 14:45 CDT, Francois Andriot 		Details | Diff
kdesdk: use 'flex' instead of 'lex' to build kbabel (435 bytes, patch)
2012-09-30 14:54 CDT, Francois Andriot 		Details | Diff
kdesdk: fix cmake macro so that 'cmake' submodule does not require updating (714 bytes, patch)
2012-09-30 16:14 CDT, Francois Andriot 		Details | Diff
kdesdk: fix build of kcachegrind for 3.5.13.1 (11.83 KB, patch)
2012-10-01 12:56 CDT, Francois Andriot 		Details | Diff
kdesdk: find for 'flex' or 'lex' to build kbabel (446 bytes, patch)
2012-10-10 16:58 CDT, Slávek Banko 		Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Francois Andriot 2012-09-30 13:14:06 CDT 
There is an unknown cmake function "tde_save_and_set" which is defined nowhere.

CMake Error at kioslave/svn/ConfigureChecks.cmake:37 (tde_save_and_set):
  Unknown CMake command "tde_save_and_set".
Call Stack (most recent call first):
  kioslave/svn/CMakeLists.txt:12 (include)


-- Configuring incomplete, errors occurred!
error: Bad exit status from /var/tmp/rpm-tmp.23826 (%build)
Comment 1 Slávek Banko 2012-09-30 13:40:48 CDT 
You need to patch to common cmake directory: http://git.trinitydesktop.org/cgit/cmake/commit/?id=caedf8323c45b376c824de343f31de78664b2511

On Debian / Ubuntu is still using automake....
Comment 2 Francois Andriot 2012-09-30 14:18:57 CDT 
Created attachment 834 [details]
kdesdk: fix build of kdecachegrind

It looks like the old 'kcachegrind' was renamed to 'kdecachegrind' then 'tdecachegrind' (in R14), but necessary patches/files were not backported.

The attached patch is backported from commit: cfccedd9
(file was too big for bugzilla so I gzipped it)
Comment 3 Francois Andriot 2012-09-30 14:28:47 CDT 
Created attachment 835 [details]
kdesdk: fix 'x-kcachegrind.desktop' file installation

Following the previous patch, here is another quick fix.
Comment 4 Francois Andriot 2012-09-30 14:45:08 CDT 
Created attachment 836 [details]
kdesdk: fix 'x-kcachegrind.desktop' file installation (2)
Comment 5 Francois Andriot 2012-09-30 14:45:59 CDT 
Now another FTBFS, but only on OpenSuse 12.2:

[ 12%] Generating pofiles.cpp
cd /home/albator/rpmbuild/BUILD/BUILD.i386/kdesdk-3.5.13.1/build/kbabel/common/libgettext && /usr/bin/lex -+ -opofiles.cpp /home/albator/rpmbuild/BUILD/BUILD.i386/kdesdk-3.5.13.1/kbabel/common/libgettext/pofiles.ll
flex: Can't use -+ with -l option
make[2]: *** [kbabel/common/libgettext/pofiles.cpp] Error 1
make[2]: Leaving directory `/home/albator/rpmbuild/BUILD/BUILD.i386/kdesdk-3.5.13.1/build'
make[1]: *** [kbabel/common/libgettext/CMakeFiles/gettext-static.dir/all] Error 2
make[1]: Leaving directory `/home/albator/rpmbuild/BUILD/BUILD.i386/kdesdk-3.5.13.1/build'
make: *** [all] Error 2
Comment 6 Francois Andriot 2012-09-30 14:54:36 CDT 
Created attachment 837 [details]
kdesdk: use 'flex' instead of 'lex' to build kbabel
Comment 7 Francois Andriot 2012-09-30 16:14:57 CDT 
Created attachment 838 [details]
kdesdk: fix cmake macro so that 'cmake' submodule does not require updating
Comment 8 Francois Andriot 2012-09-30 16:15:31 CDT 
I can now build kdesdk 3.5.13.1 on all my distros with all 4 attached patches.
Comment 9 Slávek Banko 2012-09-30 19:06:09 CDT 
Thank you for your patches. Unfortunately it is now too late to include patches to official release 3.5.13.1. But I'll look at it, to patches can be included into possible 3.5.13.2.

I have always tried to avoid renaming such kcachegrind => kdecachegrind / tdecachegrind. Unfortunately, I probably missed it in some patches. In any case, for 3.5.13.x I would prefer to preserve the original names == avoid renaming.
Comment 10 Francois Andriot 2012-10-01 12:56:55 CDT 
Created attachment 839 [details]
kdesdk: fix build of kcachegrind for 3.5.13.1

OK this time this is the good patch to build kcachegrind with cmake, without renaming to kdecachegrind.
Comment 11 Slávek Banko 2012-10-01 13:04:41 CDT 
Excellent - it looks very good.
Thank you.
Comment 12 Slávek Banko 2012-10-10 16:58:01 CDT 
Created attachment 860 [details]
kdesdk: find for 'flex' or 'lex' to build kbabel

François, 

I do not know whether we have confidence that all systems use flex.
So I tried to design a patch that looks for both.

What do you think about this?
Comment 13 Francois Andriot 2012-10-11 03:10:10 CDT 
Nice, I did not know that the "find_program" macro could search several binaries at once. If it works (not tested yet), it is the best solution IMO.
Comment 14 Darrell 2012-10-13 00:11:01 CDT 
With appropriate renaming, do these patches apply to R14?
Comment 15 Francois Andriot 2012-10-13 02:40:48 CDT 
Only the last patch from Slavek applies to R14.
Comment 16 Slávek Banko 2012-10-13 04:59:25 CDT 
Attachment 860 [details] pushed to GIT in hash c20f47db.
Comment 17 Slávek Banko 2012-10-13 05:33:04 CDT 
François, I decided that if because of java (libhpi.so) I'll update common admin module, I shall also update common cmake module to add tde_save_and_set. With the fact that these updates are not the reason for rebuild other packages than kdebidings and kdesdk.
Comment 18 Slávek Banko 2012-10-13 10:08:02 CDT 
Attachment 839 [details] pushed to v3.5.13-sru GIT branch in hash c5dcdad6.