By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 1278 - Build issue: tdenetwork cmake conversion lacks support for OpenSLP or XMMS
Summary: Build issue: tdenetwork cmake conversion lacks support for OpenSLP or XMMS
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: tdenetwork (show other bugs)
Version: R14.0.0 [Trinity]
Hardware: Other Other
: P5 normal
Assignee: Timothy Pearson
URL:
Depends on:
Blocks:
 
Reported: 2012-10-18 19:06 CDT by Darrell
Modified: 2012-10-26 18:12 CDT (History)
3 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
Added OpenSLP support to CMake (2.46 KB, patch)
2012-10-25 14:42 CDT, Slávek Banko 		Details | Diff
Added XMMS supoort to CMake (2.77 KB, patch)
2012-10-25 20:02 CDT, Slávek Banko 		Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darrell 2012-10-18 19:06:40 CDT 
When tdenetwork was converted to cmake, no support for OpenSLP was added.
Comment 1 Darrell 2012-10-18 21:00:19 CDT 
I don't see anything in the cmake files indicating support for XMMS (nowlistening plugin). The nowlistening plugin builds as far as I can tell, but I don't know whether XMMS support is added. In automake, there was a direct configure option, --with-xmms.
Comment 2 Darrell 2012-10-18 22:09:40 CDT 
I installed the OpenSLP package and built tdenetwork with autotools. There were no build failures, but I don't know how to validate OpenSLP support was built. What usability tests would suffice?

There are no references in the cmake build log or cmake cache file about XMMS, although there are a few lines about building nlxmms.cpp. So don't know one way or another whether XMMS support is being built.
Comment 3 Slávek Banko 2012-10-24 20:59:33 CDT 
I'm not sure if xmms support is still applicable?
I think that was for xmms 1.x and with xmms 2.x does not work.
Comment 4 Darrell 2012-10-24 21:03:50 CDT 
I don't know. I have xmms-1.2.11 installed. Even if no longer compatible with xmms 2.x, I think we should keep the configure option functional for xmms 1.2.x.

I don't know how to test whether the support builds correctly.
Comment 5 Slávek Banko 2012-10-24 21:15:31 CDT 
Ok, I understand. Currently can be xmms support builded only by automake build - with using --with-xmms. I'll try into the upcoming 'cmake' patch also add support for xmms and OpenSLP. Stay tuned :)

Anyway, today I tried to build with jingle support, but so far build failed.
Comment 6 Darrell 2012-10-24 21:52:26 CDT 
I'm changing the bug report summary to include XMMS.

I too am unable to build jingle support.
Comment 7 Slávek Banko 2012-10-25 14:42:48 CDT 
Created attachment 936 [details]
Added OpenSLP support to CMake

Added WITH_SLP option, checking for library presence and linking.
Please try it - this time cmake build :)
Comment 8 Darrell 2012-10-25 15:34:35 CDT 
I tested the cmake OpenSLP patch and -DWITH_SLP=ON. The package builds, but I don't know what usability test proves the hooks built correctly. I presume when building with automake that the OpenSLP support builds already, but again, what is a good usability test?
Comment 9 Slávek Banko 2012-10-25 18:32:21 CDT 
In krdc is Browse button, which would (hopefully) can be used to scan using SLP services on the network. For me (build with autotools) but still nothing is there. So I'm not sure how to verify functionality.
Comment 10 Slávek Banko 2012-10-25 20:02:09 CDT 
Created attachment 937 [details]
Added XMMS supoort to CMake

I tried to prepare a patch, but I have no idea if it will work.
Testing is yours.
Comment 11 Slávek Banko 2012-10-26 08:24:44 CDT 
Comment on attachment 936 [details]
Added OpenSLP support to CMake

Pushed to GIT in hash 354555a2
Comment 12 Darrell 2012-10-26 16:43:43 CDT 
Comment on attachment 937 [details]
Added XMMS supoort to CMake

I made one typographical change to the XMMS patch (missing parentheses). The patch builds without incident. We'll have to look later how to test usability. I am pushed the patch in commit 10026753.
Comment 13 Darrell 2012-10-26 16:46:03 CDT 
As this bug report addressed cmake build issues (and not usability), I'm closing the bug report as resolved. The libjingle build issues mentioned in the comments should be addressed through bug report 1097.

Thanks everybody!
Comment 14 Slávek Banko 2012-10-26 18:06:10 CDT 
Darrell, you forgot in commit 10026753 to add new file kopete/plugins/nowlistening/ConfigureChecks.cmake
Comment 15 Darrell 2012-10-26 18:12:07 CDT 
Oops. Done!