Hi, 

I have done a lot of work on kickoff lately, so I am assigning this to me.

> 1.) hibernate to disk and hibernate to ram is missing in kickoff, but is 
available in/over the classic menu.

Looking into it.

> 2.) the bottom buttons(Favorites, Application, etc.) are not 
expanded(horizontal layout manager is broken?)?

Confirmed 

> 3.) default menu height is to low.

What size should it be?

>4.) kcontrol menu entries are missing in kickoff. /opt/trinity/bin/kcontrol is 
not available in kickoff and also not in the classic 
> menu, only with search over the kickoff search field it occurs in kickoff. 
5.) no default favorites entries are available in kickoff

yeah I have these problems as well. 

Though I can't even run kickoff because of bugs with the media manager parser. 
What version are you using? 3.5.13?

Created attachment 1197 [details]
kickoff 3.5.13.2 : adds 'kcontrol' and 'run command' in 'computer' tab

Hello, the attached patches removes the existing icons under "Application" in "Computer" tab.
Previously, it contained 2 items:
1) YaST (the openSUSE configuration utility)
2) sysinfo (displays system informations in HTML format, requires kio-sysinfo package which is not available in Trinity)

The patches adds "Kcontrol" and "Run Command" items, which are there in KDE4.

(Odpověď na komentář #2)
> > 3.) default menu height is to low.
> 
> What size should it be?
> 

For me, the default height was so that it did not see any icons - it was just the top rail, bottom rail and between this 0 points.

Created attachment 1200 [details]
kickoff 3.5.13.2 : enable the "timed logout" feature

The following feature was present in Trinity's source code but not enabled:

The attached patch replaces the default (and ordinary) popups that prompts for user confirmation on logout/shutdown/restart from Kickoff menu (normal kicker menus are not modified by this patch).

The new popup looks nicer, and displays a timer of 30 seconds. After 30 seconds, the action is confirmed, unless the user has pressed the Cancel button.

Note: this is how openSUSE-KDE3 looks currently.

Created attachment 1201 [details]
kickoff 3.5.13.2 : do not reduce icons for searched applications

Currently, when using the search feature, the results are shown with small icons (16 pixels). This patch disable the icon reduction, so that search results look like normal items.
(This is the behavior in KDE4)

Created attachment 1202 [details]
kickoff 3.5.13.2 : fix tabs width

The attached patches fixes 2 issues related to tab size:
1) Tabs are now all the same width
2) Tabs are now automatically resized when kicker menu is resized

Created attachment 1203 [details]
kickoff 3.5.13.2 : enable the suspend features

The attached patches enables the "suspend to ram" and "suspend to disk" buttons in Kickoff menu.
Alas, it relies on an external library called "liblazy".
So the build of the features are conditional, depending if you have the "lazy" library or not.

Note about the previous patch: the lazy library is used to communicate with HAL daemon, to run suspend to ram or suspend to disk.
With the deprecation of HAL and the new HWlibrary in TDE R14, the code will need to be updated and the "lazy" library will not be needed anymore.

(Odpověď na komentář #9)
> Note about the previous patch: the lazy library is used to communicate with HAL
> daemon, to run suspend to ram or suspend to disk.
> With the deprecation of HAL and the new HWlibrary in TDE R14, the code will
> need to be updated and the "lazy" library will not be needed anymore.

It is possible to modify the code (for v3.5.13-sru branch) to use the same method for suspend / hibernate as is used in classic menu and kpowersave instead of liblazy?

Created attachment 1204 [details]
kickoff 3.5.13.2 : adds a distribution-specific link in "Computer" tab

The attached patch allows to add a distribution-specific application shortcut in the "Computer" tab of Kickoff menu.
For example, you can add the distribution-specific configuration utility (Yast, Drakconf ...) depending on your distribution.

(En réponse au commentaire 10)
> (Odpověď na komentář #9)
> > Note about the previous patch: the lazy library is used to communicate with HAL
> > daemon, to run suspend to ram or suspend to disk.
> > With the deprecation of HAL and the new HWlibrary in TDE R14, the code will
> > need to be updated and the "lazy" library will not be needed anymore.
> 
> It is possible to modify the code (for v3.5.13-sru branch) to use the same
> method for suspend / hibernate as is used in classic menu and kpowersave
> instead of liblazy?

There are several points. I think the problem is deeper.

In theory it's possible to replace the "lazy" code to straight DBUS code. It would add a lot of code complexity (The purpose of "lazy" library is to avoid complexity).

The "classic" menu does not provide any "Suspend" button. It only provides a "Log out" (red) button, which tells the ksmserver to display a specific window, which in turns contains all possible actions (logoff, shutdown, reboot, suspend ...). This menu is NOT part of kicker. There is no "logoff/shutdown/restart/suspend" related code at all in classic menu, so we can't share this code with kickoff.

Currently, kickoff uses direct call to HAL daemon via dbus, ignoring the ksmserver. I don't think this is a correct way. 
But is it possible to make Kickoff speak with ksmserver to know which actions are possible, and then trigger them ? I do not know.

>Currently, kickoff uses direct call to HAL daemon via dbus, ignoring the ksmserver. I don't think this is a correct way. 

Kickoff makes the same call to hal that ksmserver does, I don't think that's a problem really. Unless you guys have had trouble with it?

>But is it possible to make Kickoff speak with ksmserver to know which actions
are possible, and then trigger them ? I do not know.

You could do the same checks that ksmserver does (ksmserver queries hal)

(En réponse au commentaire 13)
> >Currently, kickoff uses direct call to HAL daemon via dbus, ignoring the ksmserver. I don't think this is a correct way. 
> 
> Kickoff makes the same call to hal that ksmserver does, I don't think that's a
> problem really. Unless you guys have had trouble with it?
> 
> >But is it possible to make Kickoff speak with ksmserver to know which actions
> are possible, and then trigger them ? I do not know.
> 
> You could do the same checks that ksmserver does (ksmserver queries hal)


Yes I've seen that ksmserver does the same dbus calls.
And it makes obvious that the "lazy" library makes things much simpler :-)
But my point is: is it worth duplicating the dbus/hal code everywhere we need to trigger shutdown actions ? I think we should investigate a smarter way.

(Odpověď na komentář #14)
> (En réponse au commentaire 13)
> > >Currently, kickoff uses direct call to HAL daemon via dbus, ignoring the ksmserver. I don't think this is a correct way. 
> > 
> > Kickoff makes the same call to hal that ksmserver does, I don't think that's a
> > problem really. Unless you guys have had trouble with it?
> > 
> > >But is it possible to make Kickoff speak with ksmserver to know which actions
> > are possible, and then trigger them ? I do not know.
> > 
> > You could do the same checks that ksmserver does (ksmserver queries hal)
> 
> 
> Yes I've seen that ksmserver does the same dbus calls.
> And it makes obvious that the "lazy" library makes things much simpler :-)
> But my point is: is it worth duplicating the dbus/hal code everywhere we need
> to trigger shutdown actions ? I think we should investigate a smarter way.

When I look into tdebase/ksmserver/shutdowndlg.cpp, I see that the code to check the status canHibernate and canSuspend is only internal.

Instead of depending on external liblazy (not included in Debian nor Ubuntu) I incline to (not very elegant) code duplication from ksmserver.

Before duplucating the ksmserver code into kickoff, I will try to write a generic class that would do the job and could be used by both ksmserver and kickoff. Wait & see.

Note for attachment 1204 [details]: I propose to change too general name DISTRIBUTION_SHORTCUT to more specific - for example KICKOFF_DIST_CONFIG_SHORTCUT. What do you think?

I noticed a regression. With patch from attachment 1202 [details] the default kickoff menu width increases significantly. When I resize menu to narrower, after switch to classic menu and back, or logout and login, the menu is again too wide.

Created attachment 1207 [details]
Kickoff default size when first opening

Certainly, you see that the default height is quite awkward. On the second opening, the place for icons automatically increases - see next attachment.

Large width is due to patch from attachment 1202 [details].

Screen size is 1024×768.

Created attachment 1208 [details]
Kickoff default size on second opening

Created attachment 1210 [details]
kickoff 3.5.13.2 : fix menu size at startup, fix tabbar size calculation

Slavek, the attached patch fix the issue you describe.
It still requires patch in attachment 1202 [details].

Created attachment 1211 [details]
kickoff 3.5.13.2 : adds a distribution-specific link in "Computer" tab (2)

Darrell, I've renamed the variable as you said.
I've also added the ability to add 2 shortcuts instead of 1, to match what I've seen in openSUSE-KDE3:
- A shortcut to the distribution control panel
- A shortcut to the "add/remove programs" graphical interface

I think these 2 shortcuts are useful to all users.

Created attachment 1212 [details]
kickoff 3.5.13.2 : use native dbus library instead of lazy library

OK finally I give up writing common code between ksmserver and kicoff for HAL/suspend features. Because it's not worth it in my opinion:
1) HAL is deprecated, all HAL related modifications will stay in 3.5.13-sru branch
2) In R14, Tim as already modified ksmserver code
3) Hal code present in ksmserver 3.5.13 would need too much reworking too.

So, I've just copy/pasted the ksmserver's HAL-related code into Kickoff to replace LAZY library calls. Here is the result. It seems to work on my computer, but you are welcome to try it yourself.

The attached patch applies AFTER attachment 1203 [details], it does NOT replace it.

Created attachment 1213 [details]
kickoff 3.5.13.2 : use native dbus library instead of lazy library (2)

Small typo in return code handling.

Created attachment 1218 [details]
kickoff 3.5.13.2 : do not try to display pixmap if it cannot be loaded

This patch is taken from openSUSE KDE3.
I think it prevents some error messages from spamming .xsession_errors .

Created attachment 1221 [details]
kickoff 3.5.13.2 : Allow suspend features using native dbus library

I tried to merge patches to enable suspend features with lazy and subsequent replacement lazy to native dbus. For me on Debian it works well. Please, try also on your distribution.

In relation to the Kickoff menu I see in the error log the following messages:

KMenuBase::setProperty( "frameShadow", value ) failed: property invalid, read-only or does not exist
KMenuBase::setProperty( "frameShape", value ) failed: property invalid, read-only or does not exist
QFile::open: No file name specified

The patch from attachment 1218 [details] had no effect on any of them.

Created attachment 1222 [details]
kickoff R14 : Allow suspend features using native dbus library or tdehw

I tried to prepare the R14 variant that allows to use a TDEHW library.
At this moment I do not have a test machine with R14.
Please can anyone try it?

About problem 5 (no default favorites in Kickoff).
It works on my computer.

Do you have the file: /opt/trinity/share/apps/kicker/default-favs
What does it contain ?

I've just installed Ubuntu 13.04 in a virtual machine, then TDE 3.5.13.2~pre from Slavek's repository, and I confirm that, in Kickoff:

1) There is no default favorite (file /opt/trinity/share/apps/kicker/default-favs is missing => packaging issue in Ubuntu)

2) As a consequence, the default menu size, which is calculated automatically, is very small. Normally, if favorites were there, the menu size would match exaclty the correct size to display all favorites icons.

So the fix is adding "/opt/trinity/share/apps/kicker/default-favs" in
http://git.trinitydesktop.org/cgit/tde-packaging/tree/ubuntu/raring/tdebase/debian/kicker-trinity.install

Then both issues should be solved.

Created attachment 1227 [details]
kickoff 3.5.13.2 : fix menu size at startup, fix tabbar size calculation (2)

Updated patch to remove useless horizontal margins on tabs.
That allows the menu to be a little thinner now.

(Odpověď na komentář #30)
> I've just installed Ubuntu 13.04 in a virtual machine, then TDE 3.5.13.2~pre
> from Slavek's repository, and I confirm that, in Kickoff:
> 
> 1) There is no default favorite (file
> /opt/trinity/share/apps/kicker/default-favs is missing => packaging issue in
> Ubuntu)
> 
> 2) As a consequence, the default menu size, which is calculated automatically,
> is very small. Normally, if favorites were there, the menu size would match
> exaclty the correct size to display all favorites icons.
> 
> So the fix is adding "/opt/trinity/share/apps/kicker/default-favs" in
> http://git.trinitydesktop.org/cgit/tde-packaging/tree/ubuntu/raring/tdebase/debian/kicker-trinity.install
> 
> Then both issues should be solved.

Thank you - good point - I'll fix it.

Apparently, it also addresses the reported "QFile::open: No file name specified".

Created attachment 1235 [details]
kickoff 3.5.13.2 : Allow suspend features using native dbus library (2)

Method KMenu::slotSuspend updated in the light patch designed for R14 (in attachment 1222 [details]).

François, please, can you test this update of merged patch, which replaces attachment 1203 [details] and attachment 1213 [details]?

Slavek, your merged patch for 3.5.13.2 works for me.

Created attachment 1248 [details]
kickoff 3.5.13.2 : fix warning messages

According to the QT3 API:
  http://www.trinitydesktop.org/docs/qt3/qdialog.html

the "qdialog" class has no member called "frameShadow" nor "frameShape".
So I simply removed them in the ".ui" file, and the warnings about invalid properties went away.

All patches was pushed to GIT

18e37298: Adds 'kcontrol' and 'run command' in 'computer' tab
a5d1d485: Enable the 'timed logout' feature
3e9cea48: Do not reduce icons for searched applications
8e144348: Fix menu size at startup and tabbar size calculation
14cd57f5: Adds a distribution-specific link in 'computer' tab
229d1bcf: Do not try to display pixmap if it cannot be loaded
bbdb95ed: Allow suspend features using native dbus library
7a982ffa: Allow suspend features using tdehw library
0782d2bb: Fix remaining warning messages

Into v3.5.13-sru branch will be backported after a while.

It seems that all listed bugs are fixed.
Therefore, the message I was set as resolved.
I thank François for his great efforts.

Created attachment 1252 [details]
kickoff 3.5.13.2 : update default favs

Some last minute tuning for Kickoff: I've updated the favs so that:
1) there are only programs from tdebase, so I'm 99% sure they are installed when running Kickoff (not like amarok, digikam ...)
2) there are 8 of them, so that the default size of kickoff menu looks normal.

Created attachment 1253 [details]
1211 : kickoff 3.5.13.2 : adds a distribution-specific link in "Computer" tab (3)

Minor update to the "distribution" patch: adding gnome-packagekit (/usr/share/applications/gpk-application.desktop) for people NOT having a distribution specific tool (Fedora, Centos ...)

Because of the additional patches a bug report opened again.

After building tdebase in R14, I have 2 regressions in kickoff menu:

1) The Kcontrol item is missing. There is something wrong with Kickoff looking for some items because even i you search "kcontrol", it does not find any result. Same problem for kfind for example.

2) The timed logout feature: when choosing logoff or shutdown or reboot from kickoff menu, you can see the popup with timer 30 seconds.
Then if you press Confirm, nothing happens. Or at least, nothing VISIBLE happens, and you think it did not work. After 30 seconds (when the timer has finished), you are finally logged out.

(En réponse au commentaire 41)
> After building tdebase in R14, I have 2 regressions in kickoff menu:
> 
> 1) The Kcontrol item is missing. There is something wrong with Kickoff looking
> for some items because even i you search "kcontrol", it does not find any
> result. Same problem for kfind for example.
> 
> 2) The timed logout feature: when choosing logoff or shutdown or reboot from
> kickoff menu, you can see the popup with timer 30 seconds.
> Then if you press Confirm, nothing happens. Or at least, nothing VISIBLE
> happens, and you think it did not work. After 30 seconds (when the timer has
> finished), you are finally logged out.

These 2 issues are gone.
I believe we can close this bug report now, since there is no activity here.

>I believe we can close this bug report now, since there is no activity here.
Before closing, please mark as obsolete all patches that have been pushed or backported.

I have a question before closing this report.

In KControl when I disable "Confirm logout" I still see the "30 second" dialog. This does not seem correct to me.

KDE4 kickoff has a similar 30 second countdown but abides by the "Confirm logout" option. Kickoff TDE does not. I have tested with a new profile.

What is the expected/intended kickoff behavior?

Another observation: the mouse on hover feature is erratic. Sometimes the kickoff menu changes when I hover the mouse pointer over a button and sometimes not. The option is enabled in the panel configuration. Same behavior with a new profile.

Is this a bug?

(In reply to Darrell from comment #43)
> What is the expected/intended kickoff behavior?
IMO, it should abides the "Confirm logout" option.

> Mouse on hover erratic
May be a bug we have to look into. Can you reproduce the erratic behavior in same regular manner?

Created attachment 1985 [details]
kickoff 14.0.0 : use the "confirm logout" option

Try this patch so that Kickoff menu uses the "Confirm Logout" option from TDE control panel.

Note: changing the setting in control panel does not take effect immediatly. You must change the setting, logout, login again, and then it is applied.

>Note: changing the setting in control panel does not take effect immediatly. 
>You must change the setting, logout, login again, and then it is applied.
Why? Users can make the same changes to the classic menu and do not need to restart Trinity.

Although restarting is required, the patch does support Confirm logout.

Unfortunately, the gray "fancy logout fadeaway" appears despite having that option disabled.

Created attachment 1988 [details]
kickoff 14.0.0 : use the "confirm logout" option (2)

Please try this new patch ... (no need to logout anymore)

The latest patch works much nicer with respect to not needing to restart Trinity. Good job. :)

As we are in a soft freeze I will not push the latest patch to git. The patch should be added to the R14 check list, however, to ensure the patch gets pushed before R14 is released.

Regarding the 'fancy logout fadeaway', seems the gray fadeout now appears all the time when logout confirmation is enabled. Enabling the 'fancy logout fadeaway' seems only to change the speed. This occurs with the classic menu too.

I tested with 3.5.13.2. When confirmation is enabled and the 'fancy logout fadeaway' is disabled, the gray fadeaway does not appear at all, fast or slow.

As the fadeaway appears with the classic menu too, that bug does not seem related to this bug report. I filed bug 1999 to address the incorrect fadeaway.

The erratic button response behavior still exists on my system. Sometimes the menu changes when I hover the mouse pointer and just as often not, and I have to click the button.

The bug is part of the list we are making for releasing v14.0.0, so the patch will be there at the end.
Darrell, for the erratic mouse hover behavior, could you file a separate bug report?

Comment on attachment 1197 [details]
kickoff 3.5.13.2 : adds 'kcontrol' and 'run command' in 'computer' tab

Pushed to GIT in hash 18e37298.

Comment on attachment 1200 [details]
kickoff 3.5.13.2 : enable the "timed logout" feature

Pushed to GIT in hash a5d1d485.

Comment on attachment 1201 [details]
kickoff 3.5.13.2 : do not reduce icons for searched applications

Pushed to GIT in hash 3e9cea48.

Comment on attachment 1218 [details]
kickoff 3.5.13.2 : do not try to display pixmap if it cannot be loaded

Pushed to GIT in hash 229d1bcf.

Comment on attachment 1248 [details]
kickoff 3.5.13.2 : fix warning messages

Pushed to GIT in hash 0782d2bb.

Comment on attachment 1235 [details]
kickoff 3.5.13.2 : Allow suspend features using native dbus library (2)

Pushed to GIT in hash bbdb95ed.

Comment on attachment 1222 [details]
kickoff R14 : Allow suspend features using native dbus library or tdehw

Pushed to GIT in hash 7a982ffa.

Comment on attachment 1202 [details]
kickoff 3.5.13.2 : fix tabs width

Fixed in GIT hash 8e144348.

Comment on attachment 1227 [details]
kickoff 3.5.13.2 : fix menu size at startup, fix tabbar size calculation (2)

Pushed to GIT in hash 8e144348.

Comment on attachment 1253 [details]
1211 : kickoff 3.5.13.2 : adds a distribution-specific link in "Computer" tab (3)

Pushed to GIT in hash 14cd57f5.

Comment on attachment 1988 [details]
kickoff 14.0.0 : use the "confirm logout" option (2)

Pushed to GIT in hash f8558cb3.

(In reply to Francois Andriot from comment #38)
> Created attachment 1252 [details]
> kickoff 3.5.13.2 : update default favs
> 
> Some last minute tuning for Kickoff: I've updated the favs so that:
> 1) there are only programs from tdebase, so I'm 99% sure they are installed
> when running Kickoff (not like amarok, digikam ...)
> 2) there are 8 of them, so that the default size of kickoff menu looks
> normal.

I agree with the restriction to programs that are part of TDE, but I find it too strict restrictions to programs from tdebase. Personally, I suggest to leave as part of the default favs Kontakt, Amarok and also Digikam.

What is your opinion?

Yes you're right. We just need to remove the external programs (e.g. Firefox) and put the various programs that are part of TDE, not only tdebase.

Comment on attachment 1252 [details]
kickoff 3.5.13.2 : update default favs

External programs removed from default-favs in commit 46c39bc0.