By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 1302 - Build issue: libkscan in CMakeList.txt named libksane
Summary: Build issue: libkscan in CMakeList.txt named libksane
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: tdegraphics (show other bugs)
Version: R14.0.0 [Trinity]
Hardware: All Linux
: P5 minor
Assignee: Timothy Pearson
URL:
Depends on:
Blocks: 1300
  Show dependency tree / graph
 
Reported: 2012-10-31 10:36 CDT by Alexander Golubev (Fat-Zer)
Modified: 2012-11-20 17:28 CST (History)
3 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
patch (305 bytes, patch)
2012-10-31 10:36 CDT, Alexander Golubev (Fat-Zer) 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Golubev (Fat-Zer) 2012-10-31 10:36:30 CDT 
Created attachment 949 [details]
patch

Seems it's only a typo, not a pending rename, cause it refered as libkscan in kooka.
And this issue breaks the build of the last one.
Comment 1 Darrell 2012-10-31 12:29:42 CDT 
Looks like a typo. Does the "project" declaration serve any purpose other than being informative?

What breaks without this patch? I never had any related breakage but as mentioned in the mail list, perhaps we are building in different ways.
Comment 2 Alexander Golubev (Fat-Zer) 2012-10-31 12:39:57 CDT 
(In reply to comment #1)
> Looks like a typo. Does the "project" declaration serve any purpose other than
> being informative?
the project name gives the name to the installed *.cmake file.

> What breaks without this patch? I never had any related breakage but as
> mentioned in the mail list, perhaps we are building in different ways.
it's because you are using «All-in-one» build. 
Try to build them step-by step:
Firstly build and install the libkscan.
Then in clean environment try to build and install kooka.
Comment 3 Darrell 2012-10-31 13:48:21 CDT 
> the project name gives the name to the installed *.cmake file.
Okay --- if I understand correctly, then the "project" declaration won't play a role when a person builds the complete package. The declaration becomes important when building separately?

At the moment I am not equipped to build component packages. Yet if I understand correctly, then many CMakeLists.txt files will need a "project" declaration to support building at that level?
Comment 4 Darrell 2012-10-31 14:04:20 CDT 
I'm updating the summary to "Build issue:" because that is what we have configured in our search links. :)
Comment 5 Alexander Golubev (Fat-Zer) 2012-10-31 14:56:35 CDT 
(In reply to comment #3)
> > the project name gives the name to the installed *.cmake file.
> Okay --- if I understand correctly, then the "project" declaration won't play a
> role when a person builds the complete package. The declaration becomes
> important when building separately?
yes

> At the moment I am not equipped to build component packages. Yet if I
> understand correctly, then many CMakeLists.txt files will need a "project"
> declaration to support building at that level?
nope, it's quite different. The project name declaration is used by tde_install_export function. This function generates&installs files witch are later can be used by tde_import to test, if required packages are already installed, and to obtain information (such as link directories) about required packages.

In fact it makes sense and quite necessary for most of shared libraries.
Comment 6 Darrell 2012-10-31 15:08:24 CDT 
So only a few CMakeLists.txt files will need to be revised?
Comment 7 Darrell 2012-10-31 16:19:01 CDT 
I tested this patch only from the perspective of watching for problems when building the full package rather than trying to build separate component packages. No problems found during the build.

I have not looked for or tested any possible usability issues.

I would like Slavek or Tim to provide additional testing before pushing to GIT.
Comment 8 Alexander Golubev (Fat-Zer) 2012-11-01 12:49:13 CDT 
(In reply to comment #6)
> So only a few CMakeLists.txt files will need to be revised?
yeap, they are ok in most of cases... 

AFAIK Serghei also have used gentoo when he was writing core cmake functionality and cmake for tdelibs/tdebase, so it seems he took a lot of care for those things too...
Also when new modules are being ported they sometimes require some more functionality to be exported from other modules.
Comment 9 Darrell 2012-11-01 22:44:28 CDT 
Patch pushed to GIT in commit c1b994bd.

Thanks for helping!