By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 1324 - Add mouse double-click test area in KControl->Peripherals->Mouse->Advanced
Summary: Add mouse double-click test area in KControl->Peripherals->Mouse->Advanced
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: tdebase (show other bugs)
Version: R14.0.0 [Trinity]
Hardware: Other Other
: P1 enhancement
Assignee: Michele Calgaro
URL:
Depends on:
Blocks:
 
Reported: 2012-11-15 14:57 CST by Darrell
Modified: 2013-11-20 21:01 CST (History)
4 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
First image for double-click test (2.11 KB, image/png)
2012-11-16 14:19 CST, Darrell 		Details
Second image for double-click test (2.21 KB, image/png)
2012-11-16 14:19 CST, Darrell 		Details
First image for double-click test with correct file name (2.11 KB, image/png)
2012-11-17 16:48 CST, Darrell 		Details
Second image for double-click test with correct file name (2.21 KB, image/png)
2012-11-17 16:48 CST, Darrell 		Details
Patch to add new images to tdelibs (5.05 KB, patch)
2012-11-17 16:52 CST, Darrell 		Details | Diff
Preliminary patch to add double-click test area (9.13 KB, patch)
2012-11-17 22:34 CST, Darrell 		Details | Diff
Updated preliminary patch to add double-click test area (8.94 KB, patch)
2012-11-18 17:15 CST, Darrell 		Details | Diff
Screen shot of first image in kcontrol module (41.02 KB, image/png)
2012-11-19 10:51 CST, Darrell 		Details
Screen shot of second image in kcontrol module (41.05 KB, image/png)
2012-11-19 10:52 CST, Darrell 		Details
patch for tdebase module (2.89 KB, patch)
2013-11-20 05:35 CST, Michele Calgaro 		Details | Diff
patch for tde-packaging (debian/ubuntu distribution) (7.09 KB, patch)
2013-11-20 05:35 CST, Michele Calgaro 		Details | Diff
Show Obsolete (7) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darrell 2012-11-15 14:57:40 CST 
In tdebase/kcontrol/input/mouse.cpp:226-227 are the following comments:

// It would be nice if the user had a test field.
// Selecting such values in milliseconds is not intuitive

I agree: not intuitive at all. :)

Windows has had such a test box for 20+ years. Trinity should have a similar test box. In Windows the test box provides an animated jack-in-the-box image that pops up and down when the user double-clicks in the test area.

GNOME 2.x supports a similar model using a light bulb:

http://www.bbc.co.uk/accessibility/guides/mouse_easier/doubleclick/linux/gnome/index.shtml

Being GPL, we could adapt the GNOME code.

Ideas for images:

The kget system tray arrow icon and reverse the direction with each double-click.

The ark toolbar extract/compress icons.

The kgpg lock/unlock icons.

The kbinary icon and reverse colors.

Two different "smiley" emoticon icons.

Or indirectly provide credit to GNOME and use the ktip light bulb icon.
Comment 1 Darrell 2012-11-16 14:19:04 CST 
Created attachment 984 [details]
First image for double-click test

This is the first (default) image to use in the double-click test.
Comment 2 Darrell 2012-11-16 14:19:40 CST 
Created attachment 985 [details]
Second image for double-click test

This is the second (toggle) image to use in the double-click test.
Comment 3 Darrell 2012-11-16 14:23:16 CST 
To whomever hacks code for this request:

Please remember the code is not a simple double-click test but is to test the double-click time interval the user selects. The images toggle only when the double-click event is less than or equal to the user's selected interval. A double-click interval greater than user's setting does not toggle the images.
Comment 4 Darrell 2012-11-17 16:48:11 CST 
Created attachment 990 [details]
First image for double-click test with correct file name

This is the same image as originally posted but with a correct file name.

The new file name is cr32-action-doubleclick-1.png and should be added in GIT to tdelibs/pics/crystalsvg/.

When building tdelibs, the file will be installed as $TDEDIR/share/icons/crystalsvg/32x32/actions/doubleclick-1.png.
Comment 5 Darrell 2012-11-17 16:48:52 CST 
Created attachment 991 [details]
Second image for double-click test with correct file name

This is the same image as originally posted but with a correct file name.

The new file name is cr32-action-doubleclick-2.png and should be added in GIT to tdelibs/pics/crystalsvg/.

When building tdelibs, the file will be installed as $TDEDIR/share/icons/crystalsvg/32x32/actions/doubleclick-2.png.
Comment 6 Darrell 2012-11-17 16:52:23 CST 
Created attachment 992 [details]
Patch to add new images to tdelibs

Two images are needed to resolve this enhancement request. The images are attached to this report.

The patch adds the two new images in GIT to tdelibs/pics/crystalsvg/.

When building tdelibs, the two mage files will be installed to $TDEDIR/share/icons/crystalsvg/32x32/actions/doubleclick-1(2).png. Subsequent code changs in tdebase/kcontrol will need to reference those file names as:

doubleclick-1.png
doubleclick-2.png
Comment 7 Darrell 2012-11-17 22:34:51 CST 
Created attachment 995 [details]
Preliminary patch to add double-click test area

I have a partial patch completed. I'm still trying to learn more about this but at this point I have the What's This help, the TQLabel, spacing, and the first image in place.

I need coaching how to measure the time between clicks, but I'm tickled I even got this far. :)

The previous tdelibs patch (attachment 992 [details]) is unnecessary. The new tdebase patch installs the two images in $(kde_datadir)/kcminput/pics.
Comment 8 Darrell 2012-11-18 17:15:09 CST 
Created attachment 996 [details]
Updated preliminary patch to add double-click test area

This patch is the best I can do. I tried many times to copy similar eventFilter code, but I'm over my head trying to understand what is involved. Hopefully I learn something when the patch is completed.

Code is still needed to detect a double-click event, which in turn changes the image when the test time is <= to the user's configured double-click interval.

The latest patch includes both images, builds without failure, and looks great in KControl. Get the double-click event finished and we have a nice new feature.
Comment 9 Darrell 2012-11-19 10:51:44 CST 
Created attachment 999 [details]
Screen shot of first image in kcontrol module
Comment 10 Darrell 2012-11-19 10:52:09 CST 
Created attachment 1000 [details]
Screen shot of second image in kcontrol module
Comment 11 Darrell 2013-03-02 21:35:06 CST 
Patch in attachment 996 [details] pushed to GIT in commit 48e7fc5a.

The patch does not fully resolve the bug report. Work is needed to toggle the icon image after testing the double-click.
Comment 12 Michele Calgaro 2013-11-14 00:24:44 CST 
I will work on this bug, but won't be until at least middle of next week due to other commitments
Comment 13 Michele Calgaro 2013-11-20 05:35:02 CST 
Created attachment 1649 [details]
patch for tdebase module
Comment 14 Michele Calgaro 2013-11-20 05:35:40 CST 
Created attachment 1650 [details]
patch for tde-packaging (debian/ubuntu distribution)
Comment 15 Michele Calgaro 2013-11-20 05:41:27 CST 
Attached above the proposed patches for this bug report.

1) attachment 1649 [details] adds the missing logic to test the mouse double click in KControl -> Peripherals -> Mouse -> Advanced tab
This patch is for tdebase

2) attachment 1650 [details] is only required for Debian/Ubuntu distributions and makes sure the two images needed are installed in the correct place.
This patch is for the tde-packaging repository and addresses all Debian/Ubuntu tdebase/debian/tdebase-data-trinity.install files (avoiding link repetition)
Comment 16 Slávek Banko 2013-11-20 13:44:59 CST 
Ooh, yeah, it works :)
Good job.

I am adding patches into my queue to commit...
Comment 17 Darrell 2013-11-20 14:36:19 CST 
>I am adding patches into my queue to commit...
Please push. Works great for me!

Thank you!
Comment 18 Slávek Banko 2013-11-20 21:01:41 CST 
Pushed to GIT in hash c4083c1d (tdebase) and hash 3393e97a (tde-packaging).