1329 – Build issue: tde-i18n cmake support

By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 1329 - Build issue: tde-i18n cmake support

Summary: Build issue: tde-i18n cmake support

Status:	RESOLVED FIXED

Alias:	None

Product:	TDE
Classification:	Unclassified
Component:	other (any) (show other bugs)
Version:	R14.0.0 [Trinity]
Hardware:	All All

Importance:	P5 normal
Assignee:	Alexander Golubev (Fat-Zer)

URL:

Depends on:	1337 1342 1343 1344
Blocks:	1300
	Show dependency tree / graph

Reported:	2012-11-17 20:41 CST by Alexander Golubev (Fat-Zer)
Modified:	2013-12-30 18:15 CST (History)
CC List:	4 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
initial patch for tde-i18n-cs (39.58 KB, patch) 2012-11-17 20:41 CST, Alexander Golubev (Fat-Zer)	Details \| Diff
fix additional «commons» in cmake (508 bytes, patch) 2012-11-17 20:47 CST, Alexander Golubev (Fat-Zer)	Details \| Diff
fix additional «commons» in cmake (2) (533 bytes, patch) 2012-11-18 19:43 CST, Slávek Banko	Details \| Diff
fix additional «commons» in cmake (3) (554 bytes, patch) 2012-11-18 23:51 CST, Alexander Golubev (Fat-Zer)	Details \| Diff
fix additional «commons» in cmake (4) (553 bytes, patch) 2012-11-19 12:43 CST, Slávek Banko	Details \| Diff
Initial cmake support patch (84.44 KB, application/bzip2) 2012-11-24 09:39 CST, Alexander Golubev (Fat-Zer)	Details
Fixes some file missings in he language. (486 bytes, patch) 2012-11-24 10:12 CST, Alexander Golubev (Fat-Zer)	Details \| Diff
Initial cmake support for missing locale zh_CN (13.59 KB, patch) 2012-11-24 11:53 CST, Alexander Golubev (Fat-Zer)	Details \| Diff
Initial cmake support for missing locale tr (17.88 KB, patch) 2012-11-24 11:59 CST, Alexander Golubev (Fat-Zer)	Details \| Diff
Initial cmake support patch[broken] (14 bytes, application/bzip2) 2013-08-14 14:09 CDT, Alexander Golubev (Fat-Zer)	Details
differences to autotools file list (10.46 KB, application/octet-stream) 2013-08-14 14:13 CDT, Alexander Golubev (Fat-Zer)	Details
Initial cmake patch (14 bytes, application/bzip2) 2013-08-14 14:16 CDT, Alexander Golubev (Fat-Zer)	Details
Initial cmake patch (82.35 KB, application/bzip2) 2013-08-14 18:14 CDT, Alexander Golubev (Fat-Zer)	Details
tde-i18n-initial-cmake-support-3.patch.bz2 (84.01 KB, application/bzip2) 2013-08-26 17:36 CDT, Alexander Golubev (Fat-Zer)	Details
Show Obsolete (13) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alexander Golubev (Fat-Zer) 2012-11-17 20:41:37 CST

Created attachment 993 [details]
initial patch for tde-i18n-cs

Ok... I'm starting to introduce cmake support into tde-i18n. Here is a first step: a patch for сzech localization.

NOTES:
It installs some additional «common» symlinks I'm not sure if it's a autotools miss or a cmake issue. So patch is put into NEEDINFO state.

Autotools installs CMakeLists.txt files for all documentation dirs. I'm not familiar with autotools so can somebody fix it?

Comment 1 Alexander Golubev (Fat-Zer) 2012-11-17 20:47:52 CST

Created attachment 994 [details]
fix additional «commons» in cmake

here is a patch to remove additional «commons» witch are installed with tde_createte_handbook() with NOINDEX flag.
This flag is not used by any other cmake modules for now.

Comment 2 Slávek Banko 2012-11-18 19:43:32 CST

Created attachment 997 [details]
fix additional «commons» in cmake (2)

Previous patch causing FTBFS since symlink was created before the creation folder => instead of a folder was under $(_dest) named symlink => subsequent files cannot be copied.

Comment 3 Slávek Banko 2012-11-18 20:03:02 CST

I tested initial cmake patch and got the following results:

1) Symlinks to en/common as not relative, but absolute.

2) Without additional cmake patch are created new symlinks:
/opt/trinity/share/doc/tde/HTML/cs/kcontrol/arts/common -> /opt/trinity/share/doc/tde/HTML/cs/common
/opt/trinity/share/doc/tde/HTML/cs/kcontrol/khtml/common -> /opt/trinity/share/doc/tde/HTML/cs/common
/opt/trinity/share/doc/tde/HTML/cs/khelpcenter/common -> /opt/trinity/share/doc/tde/HTML/cs/common

3) With additional cmake patch on contrary was missing:
/opt/trinity/share/doc/tde/HTML/cs/kcontrol/bell/common -> /opt/trinity/share/doc/tde/HTML/cs/common
/opt/trinity/share/doc/tde/HTML/cs/kcontrol/clock/common -> /opt/trinity/share/doc/tde/HTML/cs/common
/opt/trinity/share/doc/tde/HTML/cs/kcontrol/common -> /opt/trinity/share/doc/tde/HTML/cs/common
/opt/trinity/share/doc/tde/HTML/cs/kcontrol/crypto/common -> /opt/trinity/share/doc/tde/HTML/cs/common
/opt/trinity/share/doc/tde/HTML/cs/kcontrol/email/common -> /opt/trinity/share/doc/tde/HTML/cs/common
/opt/trinity/share/doc/tde/HTML/cs/kcontrol/kcmaccess/common -> /opt/trinity/share/doc/tde/HTML/cs/common
/opt/trinity/share/doc/tde/HTML/cs/kcontrol/kcmlowbatcrit/common -> /opt/trinity/share/doc/tde/HTML/cs/common
/opt/trinity/share/doc/tde/HTML/cs/kcontrol/kcmsmserver/common -> /opt/trinity/share/doc/tde/HTML/cs/common
/opt/trinity/share/doc/tde/HTML/cs/kcontrol/kcmstyle/common -> /opt/trinity/share/doc/tde/HTML/cs/common
/opt/trinity/share/doc/tde/HTML/cs/kcontrol/kdm/common -> /opt/trinity/share/doc/tde/HTML/cs/common
/opt/trinity/share/doc/tde/HTML/cs/kcontrol/kmixcfg/common -> /opt/trinity/share/doc/tde/HTML/cs/common
/opt/trinity/share/doc/tde/HTML/cs/kcontrol/laptop/common -> /opt/trinity/share/doc/tde/HTML/cs/common
/opt/trinity/share/doc/tde/HTML/cs/kcontrol/passwords/common -> /opt/trinity/share/doc/tde/HTML/cs/common
/opt/trinity/share/doc/tde/HTML/cs/kdeprint/common -> /opt/trinity/share/doc/tde/HTML/cs/common
/opt/trinity/share/doc/tde/HTML/cs/kdm/common -> /opt/trinity/share/doc/tde/HTML/cs/common
/opt/trinity/share/doc/tde/HTML/cs/kgamma/common -> /opt/trinity/share/doc/tde/HTML/cs/common
/opt/trinity/share/doc/tde/HTML/cs/kinfocenter/devices/common -> /opt/trinity/share/doc/tde/HTML/cs/common
/opt/trinity/share/doc/tde/HTML/cs/kinfocenter/dma/common -> /opt/trinity/share/doc/tde/HTML/cs/common
/opt/trinity/share/doc/tde/HTML/cs/kinfocenter/interrupts/common -> /opt/trinity/share/doc/tde/HTML/cs/common
/opt/trinity/share/doc/tde/HTML/cs/kinfocenter/ioports/common -> /opt/trinity/share/doc/tde/HTML/cs/common
/opt/trinity/share/doc/tde/HTML/cs/kinfocenter/memory/common -> /opt/trinity/share/doc/tde/HTML/cs/common
/opt/trinity/share/doc/tde/HTML/cs/kinfocenter/partitions/common -> /opt/trinity/share/doc/tde/HTML/cs/common
/opt/trinity/share/doc/tde/HTML/cs/kinfocenter/pci/common -> /opt/trinity/share/doc/tde/HTML/cs/common
/opt/trinity/share/doc/tde/HTML/cs/kinfocenter/pcmcia/common -> /opt/trinity/share/doc/tde/HTML/cs/common
/opt/trinity/share/doc/tde/HTML/cs/kinfocenter/processor/common -> /opt/trinity/share/doc/tde/HTML/cs/common
/opt/trinity/share/doc/tde/HTML/cs/kinfocenter/scsi/common -> /opt/trinity/share/doc/tde/HTML/cs/common
/opt/trinity/share/doc/tde/HTML/cs/kinfocenter/sound/common -> /opt/trinity/share/doc/tde/HTML/cs/common
/opt/trinity/share/doc/tde/HTML/cs/kinfocenter/xserver/common -> /opt/trinity/share/doc/tde/HTML/cs/common
/opt/trinity/share/doc/tde/HTML/cs/konsole/common -> /opt/trinity/share/doc/tde/HTML/cs/common

I do not know which of these options is correct - 2) or 3) ?

Comment 4 Alexander Golubev (Fat-Zer) 2012-11-18 23:51:19 CST

Created attachment 998 [details]
fix additional «commons» in cmake (3)

(In reply to comment #3)
> I tested initial cmake patch and got the following results:
> 
> 1) Symlinks to en/common as not relative, but absolute.

IMHO, that won't make a lot of difference, but if decide I'd prefer absolute links.

> 2) Without additional cmake patch are created new symlinks:
> 3) With additional cmake patch on contrary was missing:
> I do not know which of these options is correct - 2) or 3) ?
3) obviously isn't. I 'm still not sure if 2) is correct or not. 
Added a normal patch to follow the automake behavior.

Comment 5 Slávek Banko 2012-11-19 12:43:52 CST

Created attachment 1001 [details]
fix additional «commons» in cmake (4)

I removed the slash, which I added in my patch - apparently it was not the right solution. Your adjustment is correct. Now I get the same results for automake and cmake (aside from the absolute × relative symlinks). It looks good!

Comment 6 Alexander Golubev (Fat-Zer) 2012-11-24 09:39:01 CST

Created attachment 1019 [details]
Initial cmake support patch

Here is an initial patch for all languages.

================================================

Next languages FTBFS:
ca da de en_GB es et fi fr hu it ja nb nl pl pt_BR pt ro ru sk sl sv zg_CN

================================================

I've got next differences to automake:
fa:< ./share/locale/fa/COPYING
Shouldn't be installed. NOT-A-BUG.

he:< ./share/doc/tde/HTML/he/khelpcenter
   < ./share/doc/tde/HTML/he/khelpcenter/khelpcenter.png
   < ./share/doc/tde/HTML/he/khelpcenter/main.html
   < ./share/doc/tde/HTML/he/khelpcenter/konq.css
Will be fixed.

mn:< ./share/locale/mn/30x16.png
   < ./share/locale/mn/flag_new_30x16.png
   < ./share/locale/mn/60x40.png
Need more info. I'm not sure if those files are really needed. Or one of them should be renamed to flag.png

se:< ./share/locale/se/ChangeLog
Shouldn't be installed. NOT-A-BUG.

================================================

Because this patch is really huge, please push it to git as-is. It will be easier to fix various errors with smaller patches for separate parts.

Comment 7 Alexander Golubev (Fat-Zer) 2012-11-24 10:12:43 CST

Created attachment 1020 [details]
Fixes some file missings in he language.

Comment 8 Alexander Golubev (Fat-Zer) 2012-11-24 11:53:50 CST

Created attachment 1021 [details]
Initial cmake support for missing locale zh_CN

Comment 9 Alexander Golubev (Fat-Zer) 2012-11-24 11:59:26 CST

Created attachment 1022 [details]
Initial cmake support for missing locale tr

tr FTBFS as well

So current list of FTBFS languages is:
ca da de en_GB es et fi fr hu it ja nb nl pl pt_BR pt ro ru sk sl sv tr

Comment 10 Alexander Golubev (Fat-Zer) 2012-11-24 19:14:55 CST

After applying patches from bugs 1337, 1342 and 1343 next languages are still failed to build: en_GB,fr,it,nb,pt,sv

Seems they got this mostly because of cmake issues than genel-builed problems.

Comment 11 Alexander Golubev (Fat-Zer) 2012-11-24 19:51:04 CST

(In reply to comment #10)
> After applying patches from bugs 1337, 1342 and 1343 next languages are still
> failed to build: en_GB,fr,it,nb,pt,sv
> 
> Seems they got this mostly because of cmake issues than genel-builed problems.
Nope, I was wrong... there are some sort of collisions:
e.g. en_GB got in docs/tdebase/khelpcenter/ five subdirectories:
  - faq
  - glossary 
  - quickstart 
  - userguide
  - visualdict

the same directories are in the tdebase (one directory topper).
Also those directories contains same files and tries to install them on the same path. But «topper» seems to be newer...

So what to do with them? merge everything to bottom-level dir?

Comment 12 Darrell 2012-11-24 20:10:28 CST

There are many tde-i18n docbook files that need updated doctype declarations. I'm including those updates in the patch for those bug reports. Testing in progress. :)

Comment 13 Darrell 2012-11-25 15:44:45 CST

I pushed a big patch in commit 177d300e. Everything in tde-i18n builds with automake. Update your local repository and try again with cmake. Please remember to rebuild tdelibs (to update entity files) before building tde-i18n. Any subsequent tde-i18n cmake build failures should not be docbook related. :)

Comment 14 Slávek Banko 2012-11-27 11:59:39 CST

Comment on attachment 1001 [details]
fix additional «commons» in cmake (4)

Pushed to GIT in hash 0953d90e.

Comment 15 Slávek Banko 2012-11-27 12:00:35 CST

(Odpověď na komentář #0)
> Autotools installs CMakeLists.txt files for all documentation dirs. I'm not
> familiar with autotools so can somebody fix it?

Fixed in GIT hash 24a4b8ad.

Comment 16 Darrell 2012-11-27 19:07:41 CST

Which module is commit 24a4b8ad pushed?

Comment 17 Slávek Banko 2012-11-27 19:22:55 CST

(Odpověď na komentář #16)
> Which module is commit 24a4b8ad pushed?

24a4b8ad => common/admin
0953d90e => common/cmake

Comment 18 Slávek Banko 2012-11-28 20:21:59 CST

(Odpověď na komentář #11)
> (In reply to comment #10)
> > After applying patches from bugs 1337, 1342 and 1343 next languages are still
> > failed to build: en_GB,fr,it,nb,pt,sv
> > 
> > Seems they got this mostly because of cmake issues than genel-builed problems.
> Nope, I was wrong... there are some sort of collisions:
> e.g. en_GB got in docs/tdebase/khelpcenter/ five subdirectories:
>   - faq
>   - glossary 
>   - quickstart 
>   - userguide
>   - visualdict
> 
> the same directories are in the tdebase (one directory topper).
> Also those directories contains same files and tries to install them on the
> same path. But «topper» seems to be newer...
> 
> So what to do with them? merge everything to bottom-level dir?

It seems that with automake it is ignored and files from the bottom-level override in the result files from topper-level. This may not always be good choise.

I propose to merge the newer files to a level which is in the result. So, for example fr - quanta/kxsldbg and tdewebdev/kxsldbg merge directly into kxsldbg on the topper level.

Comment 19 Alexander Golubev (Fat-Zer) 2012-11-28 22:03:09 CST

(In reply to comment #18)
> It seems that with automake it is ignored and files from the bottom-level
> override in the result files from topper-level. This may not always be good
> choise.
> 
> I propose to merge the newer files to a level which is in the result. So, for
> example fr - quanta/kxsldbg and tdewebdev/kxsldbg merge directly into kxsldbg
> on the topper level.

I've filled a separate bug (1344) for that issue. 

Darrel proposed to keep the same structure as in main packages... and I agree with that. Although I think it would be nice to revise that structure there. e.g. for khelpcenter, but it will be an another story...

Comment 20 Alexander Golubev (Fat-Zer) 2013-08-14 14:09:35 CDT

Created attachment 1467 [details]
Initial cmake support patch[broken]

Here is the new version of patch. Three locales (sv,it,fr) are still FTBFS due to bug 1344.

Comment 21 Alexander Golubev (Fat-Zer) 2013-08-14 14:13:26 CDT

Created attachment 1468 [details]
differences to autotools file list

Also It has quite a lot of differences to autotools version. 
I suppose that some or most of those files are shouldn't be installed.

Comment 22 Alexander Golubev (Fat-Zer) 2013-08-14 14:16:00 CDT

Created attachment 1469 [details]
Initial cmake patch

Comment 23 Darrell 2013-08-14 17:47:21 CDT

Attachment 1469 [details] is a bzip2 that contains no files?

Comment 24 Alexander Golubev (Fat-Zer) 2013-08-14 18:14:39 CDT

Created attachment 1470 [details]
Initial cmake patch

(In reply to comment #23)
> Attachment 1469 [details] is a bzip2 that contains no files?
sorry...  uploaded the empty patch twice... here is the right one

Comment 25 Darrell 2013-08-14 18:32:10 CDT

Quick note: would you update the patch to use 'set(VERSION R14.0.0)' rather than 'set(VERSION R14)'? That is what I used in bug report 1595. :-)

Comment 26 Alexander Golubev (Fat-Zer) 2013-08-14 18:48:31 CDT

(In reply to comment #25)
> Quick note: would you update the patch to use 'set(VERSION R14.0.0)' rather
> than 'set(VERSION R14)'? That is what I used in bug report 1595. :-)

sure, Anyway I'll have to update the patch after the bug 1344 got resolved.

Comment 27 Alexander Golubev (Fat-Zer) 2013-08-26 17:36:50 CDT

Created attachment 1503 [details]
tde-i18n-initial-cmake-support-3.patch.bz2

here is the third one cmake patch and I hope the last one =)

I've got next differences to autotools:
< ./share/locale/da/da.compendium
< ./share/locale/fa/COPYING
< ./share/locale/fr/relecture_docs
< ./share/locale/fr/nbsp_gui_fr.txt
< ./share/locale/fr/relecture_gui
< ./share/doc/tde/HTML/fr/khelpcenter/main.html
< ./share/doc/tde/HTML/he/khelpcenter/main.html
< ./share/locale/mn/flag_new_30x16.png
< ./share/locale/mn/60x40.png
< ./share/locale/mn/30x16.png
< ./share/locale/nb/README
< ./share/doc/tde/HTML/pt_BR/api
< ./share/doc/tde/HTML/pt_BR/api/footer.html
< ./share/doc/tde/HTML/pt_BR/api/Doxyfile.am
< ./share/doc/tde/HTML/pt_BR/api/mainheader.html
< ./share/doc/tde/HTML/pt_BR/api/doxyndex.sh
< ./share/doc/tde/HTML/pt_BR/api/mainfooter.html
< ./share/doc/tde/HTML/pt_BR/api/header.html
< ./share/doc/tde/HTML/pt_BR/kig/scripting-api
< ./share/doc/tde/HTML/pt_BR/kig/scripting-api/Doxyfile.scripting-api.in
< ./share/locale/se/ChangeLog
< ./share/doc/tde/HTML/sl/khelpcenter/main.html

I consider those files as trash that shouldn't be installed...
All other differences are fixed.

Comment 28 Slávek Banko 2013-12-30 18:15:36 CST

After some small fixes pushed to GIT in hash 2da3d790.
Thanks to everyone involved for their joint efforts.