By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 1330 - Build Issue: tdenetwork, multiple cmake issues.
Summary: Build Issue: tdenetwork, multiple cmake issues.
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: tdenetwork (show other bugs)
Version: R14.0.0 [Trinity]
Hardware: All All
: P1 major
Assignee: Slávek Banko
URL:
Depends on:
Blocks: 1300
  Show dependency tree / graph
 
Reported: 2012-11-19 23:35 CST by Alexander Golubev (Fat-Zer)
Modified: 2012-11-22 11:33 CST (History)
3 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
Issue#1 fix (502 bytes, patch)
2012-11-19 23:38 CST, Alexander Golubev (Fat-Zer) 		Details | Diff
Issue#2 build.log (73.78 KB, application/octet-stream)
2012-11-20 00:18 CST, Alexander Golubev (Fat-Zer) 		Details
Issue#2 fix (2.54 KB, patch)
2012-11-20 03:47 CST, Alexander Golubev (Fat-Zer) 		Details | Diff
Issue#2 fix with automake (2.92 KB, patch)
2012-11-20 22:57 CST, Alexander Golubev (Fat-Zer) 		Details | Diff
Issue#2 fix with automake (2) (3.03 KB, patch)
2012-11-21 16:50 CST, Slávek Banko 		Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Golubev (Fat-Zer) 2012-11-19 23:35:33 CST 
Here will be posted some cmake-related tdenetwork issues.
Comment 1 Alexander Golubev (Fat-Zer) 2012-11-19 23:38:50 CST 
Created attachment 1003 [details]
Issue#1 fix

This missing export blocks at least separate compilation of dcoprss.
Comment 2 Alexander Golubev (Fat-Zer) 2012-11-20 00:18:47 CST 
Created attachment 1004 [details]
Issue#2 build.log

here is a parallel compilation Issue. filesharing fails to compile in parallel. no fix yet.

error message is:
/var/tmp/portage/trinity-base/tdenetwork-filesharing-9999/work/tdenetwork-filesharing-9999/filesharing/advanced/propsdlgplugin/../kcm_sambaconf/sharedlgimpl.h:39:19: fatal error: share.h: No such file or directory
Comment 3 Alexander Golubev (Fat-Zer) 2012-11-20 03:47:15 CST 
Created attachment 1005 [details]
Issue#2 fix

here is a patch to fix the issue.

See the cmake FAQ about that all this stuff for: http://www.cmake.org/Wiki/CMake_FAQ
Especially chapters 4.6, 4.7, 4.8.

can somebody test it with autotools as well? I've also changed some includes...
Comment 4 Darrell 2012-11-20 14:14:26 CST 
> fatal error: share.h: No such file or directory

I have see this error but not in a repeatable manner. The tdenetwork package always built on a second attempt. I will add the patch and test but looks to me if Tim or Slavek review then we should just push right away.

Please notice there are several open bug reports affecting tdenetwork:

http://bugs.pearsoncomputing.net/buglist.cgi?quicksearch=tdenetwork

Two of those reports contain patches.
Comment 5 Slávek Banko 2012-11-20 17:56:56 CST 
I tried building with both automake and cmake. If have to be adjusted paths in propertiespage.cpp, it is necessary to modify also automake build, otherwise it leads to FTBFS.
Comment 6 Alexander Golubev (Fat-Zer) 2012-11-20 22:57:23 CST 
Created attachment 1008 [details]
Issue#2 fix with automake

(In reply to comment #5)
> I tried building with both automake and cmake. If have to be adjusted paths in
> propertiespage.cpp, it is necessary to modify also automake build, otherwise it
> leads to FTBFS.
here is a patch but I'm not familiar with automake and I even can't test if it works.

(In reply to comment #4)
> > fatal error: share.h: No such file or directory
> 
> I have see this error but not in a repeatable manner. The tdenetwork package
> always built on a second attempt. I will add the patch and test but looks to me
I've achieved repeatability with cmake -DBUILD_FILESHARING=ON && make -j14 or -j8 some times. Eventually I've built with -j2 through -j32 with step 6 for test. All worked well.
Comment 7 Darrell 2012-11-20 23:40:06 CST 
I tested both patches building with cmake. I haven't yet tried automake. No build issues. Of course, I only saw the share.h failure intermittently os the only test for me is to keep watch over the weeks. We still need somebody else to approve before I can push.
Comment 8 Slávek Banko 2012-11-21 16:50:57 CST 
Created attachment 1009 [details]
Issue#2 fix with automake (2)

I modified automake part of the patch.
Now I can build successfully with both automake and also cmake.

If there are no objections, I'll push both patches into the GIT.
Comment 9 Darrell 2012-11-21 19:17:52 CST 
I tested the latest Issue#2 fix with automake and had no problems. I say push both to GIT.

We probably should get the patches in bug report 1040 tested and pushed too. Then we could close that report as well as this one.
Comment 10 Slávek Banko 2012-11-22 11:33:34 CST 
Pushed to GIT in hash 14f7445d and 6ab3b4d3.
And also into v3.5.13-sru branch.