By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 1365 - Build Issue: Initial cmake support for konversation
Summary: Build Issue: Initial cmake support for konversation
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: non-core programs (show other bugs)
Version: R14.0.0 [Trinity]
Hardware: All Linux
: P5 normal
Assignee: Alexander Golubev (Fat-Zer)
URL:
Depends on:
Blocks: 1300
  Show dependency tree / graph
 
Reported: 2012-12-13 11:17 CST by Alexander Golubev (Fat-Zer)
Modified: 2014-01-02 08:52 CST (History)
4 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
patch (36.61 KB, patch)
2012-12-13 11:17 CST, Alexander Golubev (Fat-Zer) 		Details | Diff
patch (37.04 KB, patch)
2012-12-23 02:54 CST, Alexander Golubev (Fat-Zer) 		Details | Diff
patch (36.62 KB, patch)
2012-12-23 03:05 CST, Alexander Golubev (Fat-Zer) 		Details | Diff
build error logt (24.11 KB, application/octet-stream)
2012-12-23 20:32 CST, Calvin Morrison 		Details
This is my cmake and make commands (118.13 KB, application/octet-stream)
2012-12-26 12:50 CST, Calvin Morrison 		Details
PREFERENCES.cpp (17.05 KB, text/x-c++src)
2012-12-26 12:51 CST, Calvin Morrison 		Details
PREFERENCES.h (6.73 KB, text/x-chdr)
2012-12-26 15:42 CST, Calvin Morrison 		Details
Updated patch to build with cmake (42.42 KB, patch)
2012-12-26 20:50 CST, Darrell 		Details | Diff
Patch to build with cmake (3) (36.95 KB, patch)
2012-12-31 11:24 CST, Slávek Banko 		Details | Diff
Updated cmake conversion patch (36.96 KB, patch)
2013-03-03 16:53 CST, Darrell 		Details | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Golubev (Fat-Zer) 2012-12-13 11:17:37 CST 
Created attachment 1052 [details]
patch

here is the patch.
Comment 1 Calvin Morrison 2012-12-21 12:31:06 CST 
awesome! I'll try out the patch today.
Comment 2 Alexander Golubev (Fat-Zer) 2012-12-23 02:54:14 CST 
Created attachment 1061 [details]
patch

small fixes in LINK for main binary in konversation/src. Over vice the build can fail in some special cases
Comment 3 Alexander Golubev (Fat-Zer) 2012-12-23 03:05:05 CST 
Created attachment 1062 [details]
patch

sorry, previous patch contained bad git submodules
Comment 4 Calvin Morrison 2012-12-23 20:31:48 CST 
Hey I am getting a build error. I have uploaded a log.
Comment 5 Calvin Morrison 2012-12-23 20:32:20 CST 
Created attachment 1064 [details]
build error logt
Comment 6 Alexander Golubev (Fat-Zer) 2012-12-23 22:15:10 CST 
(In reply to comment #4)
> Hey I am getting a build error. I have uploaded a log.

Are you using some -jN option for make?

Can you attach full configure/build log e.g. produced by:
cmake <your configure options> && make -j1 VERBOSE=1
(or whichever -jN option produces the fail)

Also please attach your konversation/src/config/preferences_base.{cpp,h} files located in your build directory.
Comment 7 Calvin Morrison 2012-12-26 12:50:35 CST 
Created attachment 1065 [details]
This is my cmake and make commands
Comment 8 Calvin Morrison 2012-12-26 12:51:20 CST 
Created attachment 1066 [details]
PREFERENCES.cpp
Comment 9 Calvin Morrison 2012-12-26 15:42:34 CST 
Created attachment 1067 [details]
PREFERENCES.h
Comment 10 Alexander Golubev (Fat-Zer) 2012-12-26 19:32:42 CST 
(In reply to comment #8)
> Created attachment 1066 [details]
> PREFERENCES.cpp

preferences_base.{cpp,h}, not preferences.
Comment 11 Darrell 2012-12-26 20:50:11 CST 
Created attachment 1068 [details]
Updated patch to build with cmake

The package builds with the cmake patch. My configure options:

-DCMAKE_C_FLAGS:STRING="$CPUOPT" \
-DCMAKE_CXX_FLAGS:STRING="$CPUOPT $DEBUG_CMAKE_OPT" \
-DCMAKE_INSTALL_PREFIX=${PREFIX} \
-DSYSCONF_INSTALL_DIR=${SYSCONFDIR} \
-DLIB_SUFFIX=${LIBDIRSUFFIX} \
-DMAN_INSTALL_DIR=${MANDIR} \
-DWITH_GCC_VISIBILITY=ON \
-DWITH_ALL_OPTIONS=ON \
-DBUILD_ALL=ON

Noticeable differences from the automake build:

* All *.pl files in /opt/trinity/share/apps/kconf_update are chmod 001 rather than chmod 755.

* Missing from /opt/trinity/share/apps/konversation/scripts:

bug
cmd
fortune
gauge
mail
media
sayclip
sysinfo
tdeversion
tinyurl
uptime
weather

* Missing from /opt/trinity/share/doc/tde/HTML/en: konversation-apidocs

* Missing from /opt/trinity/share/doc/tde/HTML: es. Completing the CMakeLists.txt file won't help because of a missing index.docbook file. There is no es/index.docbook file in the pre-Trinity konversation 1.1 sources.

I'm attaching an updated patch. The patch does not resolve the missing konversation-apidocs.
Comment 12 Slávek Banko 2012-12-31 11:24:47 CST 
Created attachment 1070 [details]
Patch to build with cmake (3)

Use install (FILES ... PERMISSIONS ... ) for installing executables is incorrect way. For this purpose is intended install (PROGRAMS ... ). Fixed in updated patch.

I added a comment to 'es' of the documentation to make it clear that it is not installed intentionally. Also in updated patch.

I tested the patch in v3.5.13-sru branch, which works flawlessly. When testing in the master branch, I get the same error as described Calvin. I compared preferences_base.cpp and preferences_base.h generated with automake and cmake - are identical. Same source tree built with automake is ok, but with cmake I get an error.
Comment 13 Darrell 2013-03-03 16:53:54 CST 
Created attachment 1118 [details]
Updated cmake conversion patch

The existing patch needed to be updated for the recent renaming rampage. I found one typo as well that caused a build failure. With the updated patch I can build konversation with cmake and parallel processing.
Comment 14 Slávek Banko 2013-03-04 15:05:33 CST 
(Odpověď na komentář #13)
> Vytvořena příloha 1118
> Updated cmake conversion patch
> 
> The existing patch needed to be updated for the recent renaming rampage. I
> found one typo as well that caused a build failure. With the updated patch I
> can build konversation with cmake and parallel processing.

I tested with R14 on Debian, and unfortunately I still cannot approve this patch - still leads to the same FTBFS mentioned by Calvin.
Comment 15 Darrell 2013-04-16 15:02:35 CDT 
How about pushing what we have to GIT? Then we can more easily study the CMakeLists.txt files for the missing components rather than trying to study a diff file.
Comment 16 Darrell 2013-04-20 21:58:45 CDT 
In reference to comment 15, the first initial patch pushed to GIT in commit 930640c5. The commit does not close this bug report because some people remain unable to build konversation using cmake. Note: the package builds without error for me on Slackware 14.0 32-bit. My cmake config is listed in comment 11.
Comment 17 Alexander Golubev (Fat-Zer) 2013-07-28 20:48:29 CDT 
(In reply to comment #14)
> (Odpověď na komentář #13)
> > Vytvořena příloha 1118
> > Updated cmake conversion patch
> > 
> > The existing patch needed to be updated for the recent renaming rampage. I
> > found one typo as well that caused a build failure. With the updated patch I
> > can build konversation with cmake and parallel processing.
> 
> I tested with R14 on Debian, and unfortunately I still cannot approve this
> patch - still leads to the same FTBFS mentioned by Calvin.

Sorry for not responding for a while. Slavek is this still actual for you? 
If it still FTBFS, can you provide your generated preferences_base.{cpp,h}, NOT preferences.

BTW, try to #include "preferences.h" directly to viewcontainer.cpp
Comment 18 Alexander Golubev (Fat-Zer) 2013-07-28 20:49:41 CDT 
(In reply to comment #14)
> (Odpověď na komentář #13)
> > Vytvořena příloha 1118
> > Updated cmake conversion patch
> > 
> > The existing patch needed to be updated for the recent renaming rampage. I
> > found one typo as well that caused a build failure. With the updated patch I
> > can build konversation with cmake and parallel processing.
> 
> I tested with R14 on Debian, and unfortunately I still cannot approve this
> patch - still leads to the same FTBFS mentioned by Calvin.

Sorry for not responding for a while. Slavek is this still actual for you? 
If it still FTBFS, can you provide your generated preferences_base.{cpp,h}, NOT preferences.

BTW, try to #include "preferences.h" directly to viewcontainer.cpp
Comment 19 Slávek Banko 2013-08-05 12:02:20 CDT 
Yes, the problem still persists.

I tried to add #include "preferences.h" into viewcontainer.cpp, but without change. Interestingly, v3.5.13-sru branch is not affected by this problem - only master branch.

Unfortunately I did not have enough time for further research.
Comment 20 Alexander Golubev (Fat-Zer) 2013-08-13 19:00:15 CDT 
anyway, I still need preferences_base.{cpp,h} from the system there build fails. I believe the problem is somewhere in them. Got no idea there else it could be.

PS: sorry for flooding with multiple status changes, but for some reason I couldn't put the bug into NEEDINFO state.
Comment 21 Slávek Banko 2014-01-02 08:52:41 CST 
Well, I found the core of problem.

Konversation uses files preferences.h and preferences_base.h - these control their re-insertion using definition PREFERENCES_H and PREFERENCESBASE_H.

But TQt3 also installs the file preferences.h that controls its re-insertion using definition PREFERENCESBASE_H. This very successful conflicts with both above files from Konversation.

Fixed in GIT hash c672ecbd.