1436 – [Regression] Gwenview persistent image rotation broken

By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 1436 - [Regression] Gwenview persistent image rotation broken

Summary: [Regression] Gwenview persistent image rotation broken

Status:	RESOLVED FIXED

Alias:	None

Product:	TDE
Classification:	Unclassified
Component:	tdegraphics (show other bugs)
Version:	3.5.13.2 [Trinity]
Hardware:	i386 Debian Wheezy

Importance:	P5 normal
Assignee:	Slávek Banko

URL:

Depends on:
Blocks:

Reported:	2013-04-07 05:13 CDT by Sergey Frolov
Modified:	2013-04-09 22:17 CDT (History)
CC List:	5 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
Fix FTBFS (542 bytes, patch) 2013-04-08 22:26 CDT, Slávek Banko	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Sergey Frolov 2013-04-07 05:13:32 CDT

Gwenview no longer saves orientation information to the original image file, neither manually (explicitly clicking "Save" from "File" menu) nor automatically.

I do have necessary permissions on the target file and still able to rotate it via konqueror context menu.

Package versions:
gwenview-trinity 4:3.5.13-1debian0+ax2~wheezy
kipi-plugins-trinity 4:3.5.13-2debian0~pre7+2~wheezy

My system:
aidaho@aidaho-laptop:~$ lsb_release -d
Description:    Debian GNU/Linux 7.0 (wheezy)
aidaho@aidaho-laptop:~$ uname -a
Linux aidaho-laptop 3.2.0-4-686-pae #1 SMP Debian 3.2.39-2 i686 GNU/Linux

Comment 1 Darrell 2013-04-07 16:58:08 CDT

When you wrote "no longer" did you mean this feature worked in a previous version of Trinity?

Comment 2 Sergey Frolov 2013-04-08 01:28:44 CDT

>When you wrote "no longer" did you mean this feature worked in a previous
version of Trinity?
Yes. I use this feature infrequently but regularly, rotating shots from camera without orientation sensor.

It was working on 3.5.13.1 and lower on Debian Squeeze thus I have marked this bug as regression.

Comment 3 Darrell 2013-04-08 13:03:06 CDT

Okay, thank you.

Comment 4 Timothy Pearson 2013-04-08 14:42:31 CDT

This works for me with TDE from GIT (using the nightly builds), so I must assume that the 3.5.13.2 SRU branch has introduced the problem.

Slavek, can you investigate and confirm?

Comment 5 Slávek Banko 2013-04-08 15:11:15 CDT

Between 3.5.13.1 and current state of 3.5.13.2 there are no patches for gwenview or libkipi. Where I would be looking elsewhere?

I understand correctly, in the meantime, was also updated from Squeeze to Wheezy?

Comment 6 Timothy Pearson 2013-04-08 15:14:26 CDT

(In reply to comment #5)
> Between 3.5.13.1 and current state of 3.5.13.2 there are no patches for
> gwenview or libkipi. Where I would be looking elsewhere?
> 
> I understand correctly, in the meantime, was also updated from Squeeze to
> Wheezy?

The only thing I could think of would be an ABI issue.  Can you check for proper functionality in 3.5.13.2?

Comment 7 Darrell 2013-04-08 15:32:00 CDT

I'm not a gwenview guru --- what steps are needed to replicate this bug?

I have older package sets from GIT I can test. I also have a 3.5.13.0 VM.

Comment 8 Slávek Banko 2013-04-08 15:44:29 CDT

I also need to know what steps are necessary to replicate this error? Useful could also be sample data.

I have 3.5.12.2 on Debian Squeeze.

Comment 9 Timothy Pearson 2013-04-08 15:49:35 CDT

(In reply to comment #8)
> I also need to know what steps are necessary to replicate this error? Useful
> could also be sample data.
> 
> I have 3.5.12.2 on Debian Squeeze.

What I did was take a sample png wallpaper, copy it to my desktop, open it with Gwenview, click the rotate button (either one), then save it.  After that, I closed Gwenview and reopened that file; when I did this, the image was properly rotated.

Sergey, is this what you did as well or are we misunderstanding your process?

Thanks!

Comment 10 Darrell 2013-04-08 16:03:14 CDT

I just performed the steps outlined by Tim. I confirm the image does not retain the rotated status. I closed gwenview and reopened.

I used a jpg image with a file date stamp from 2008. The file date stamp of the file does not change after I rotate and select Save from the File menu.

My currently installed GIT version is shortlog 1211, from about March 4. I haven't yet installed a new package set from GIT.

Comment 11 Darrell 2013-04-08 16:05:50 CDT

Note: Using Save As changes the file date stamp but does not retain the rotation.

Comment 12 Timothy Pearson 2013-04-08 16:06:52 CDT

(In reply to comment #10)
> I just performed the steps outlined by Tim. I confirm the image does not retain
> the rotated status. I closed gwenview and reopened.
> 
> I used a jpg image with a file date stamp from 2008. The file date stamp of the
> file does not change after I rotate and select Save from the File menu.
> 
> My currently installed GIT version is shortlog 1211, from about March 4. I
> haven't yet installed a new package set from GIT.

It looks like I spoke too soon.  While the PNG images worked, JPG images are displaying the problem noted in this bug report.

Tim

Comment 13 Slávek Banko 2013-04-08 16:14:54 CDT

I tested the above procedure with gwenview on 3.5.13.2 on Debian Squeeze and I have no problem with JPG. The picture is saved rotated.

It may be a problem with rotation in exif informations?
On Squeeze is libexiv2 version 0.20, on Wheezy 0.23.

Comment 14 Timothy Pearson 2013-04-08 16:19:40 CDT

Further information:
JPEG files store Orientation data in their EXIF metadata structure.

Interestingly, only rotations are broken in Gwenview; flip and mirror (which also use the EXIF metadata) work fine.

Comment 15 Timothy Pearson 2013-04-08 16:27:03 CDT

(In reply to comment #13)
> I tested the above procedure with gwenview on 3.5.13.2 on Debian Squeeze and I
> have no problem with JPG. The picture is saved rotated.
> 
> It may be a problem with rotation in exif informations?
> On Squeeze is libexiv2 version 0.20, on Wheezy 0.23.

I can confirm that my failures also occur on libexiv2 0.23-1.

So, what changed?  Running exiv2 on the output file indicates that no EXIF data is present; this implies that libexiv2 is unable to write the metadata for some reason.

Tim

Comment 16 Darrell 2013-04-08 16:36:15 CDT

Oh, yeah. A PNG works great, a JPG does not. :)

I have exiv2-0.23 installed.

Comment 17 Darrell 2013-04-08 16:41:06 CDT

>So, what changed?
My first guess is recent renaming? I would have to install a package set from back in January to test that.

Comment 18 Slávek Banko 2013-04-08 16:43:13 CDT

(Odpověď na komentář #17)
> >So, what changed?
> My first guess is recent renaming? I would have to install a package set from
> back in January to test that.

With renaming it certainly is not related - it's the same in 3.5.13-sru (without renaming) and the R14 (with renaming).

Comment 19 Darrell 2013-04-08 16:59:59 CDT

I tested this on my 3.5.13.0 VM. PNGs save the rotate change and JPGs do not.

The 3.5.13 VM is with Slackware 13.1, which has exiv2-0.18.2.

I tested in another VM with Slackware 13.1, but with KDE 3.5.10. Same results. :)

Apparently this bug has existed for a while. I'm guessing that --- just guessing --- that perhaps Sergey had previously rotated a non jpg image and only recently tried rotating a jpg to notice the bug.

Comment 20 Darrell 2013-04-08 17:23:38 CDT

Note: I can rotate and save a jpg using kolourpaint.

Comment 21 Slávek Banko 2013-04-08 17:48:18 CDT

I'm trying to JPG images on Debian Squeeze I had been a problem not encountered. Exif obviously not a problem. What's your version of libjpeg?

Squeeze = libjpeg62 - 6b1
Wheezy = libjpeg8 - 8d

Comment 22 Timothy Pearson 2013-04-08 18:02:29 CDT

jtransform_execute_transformation is not working properly with JXFORM_ROT_*, even though Gwenview is passing the correct JXFORM_ROT_* parameter.

We aren't the only ones observing this bug BTW:
https://bugs.kde.org/show_bug.cgi?id=227313

Comment 23 Timothy Pearson 2013-04-08 18:35:57 CDT

Resolved in GIT hash 29976f7.

Thanks for reporting!

Comment 24 Slávek Banko 2013-04-08 20:17:40 CDT

Digikam and kipi-plugins are also affected by this problem?

Comment 25 Slávek Banko 2013-04-08 22:26:08 CDT

Created attachment 1146 [details]
Fix FTBFS

I've tried the patch, but it causes FTBFS with both - libjpeg6b (in Squeeze) and also libjpeg8 (in Wheezy). Propsed patch attached.

Comment 26 Timothy Pearson 2013-04-08 22:50:34 CDT

(In reply to comment #25)
> Created attachment 1146 [details]
> Fix FTBFS
> 
> I've tried the patch, but it causes FTBFS with both - libjpeg6b (in Squeeze)
> and also libjpeg8 (in Wheezy). Propsed patch attached.

Looks good, go ahead and patch.

I've been so swamped with these bugs that I haven't had time to do proper rebuild tests.  Thanks for cleaning up my mess! :-)

Comment 27 Slávek Banko 2013-04-08 23:01:27 CDT

Fixed in GIT hash 5ce04ff5.

Comment 28 Sergey Frolov 2013-04-09 01:53:52 CDT

Wow. Thank you for your lightning fast response guys. In the evening it was there, by the morning it was gone. Hats off to you all.

Comment 29 Darrell 2013-04-09 12:39:22 CDT

>I've been so swamped with these bugs that I haven't had time to do proper rebuild tests.

Right now we can live with that. Usually hard build failures are straightforward to remedy. Right now we need your expertise to keep the show moving, which is happening at a delightful and encouraging pace! :)

Comment 30 Darrell 2013-04-09 22:17:53 CDT

>Digikam and kipi-plugins are also affected by this problem?
I just tested digikam. Yes. I filed bug report 1444.