By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 1448 - Build issue: TDM ignores @TDE_DATA_DIR@/share to populate sessions menu
Summary: Build issue: TDM ignores @TDE_DATA_DIR@/share to populate sessions menu
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: tdebase (show other bugs)
Version: R14.0.0 [Trinity]
Hardware: Other Linux
: P5 critical
Assignee: Timothy Pearson
URL:
Depends on:
Blocks: 1449
  Show dependency tree / graph
 
Reported: 2013-04-12 17:38 CDT by Darrell
Modified: 2013-04-20 19:09 CDT (History)
3 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
Patch to ensure SessionsDirs is correct (725 bytes, patch)
2013-04-12 21:05 CDT, Darrell 		Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darrell 2013-04-12 17:38:34 CDT 
Latest GIT, Slackware 14.

Currently the only way to start Trinity from TDM is to use the Default session option.

Some investigating reveals that in tdebase/tdm/config.def, the default tdmrc will compile the SessionsDirs key to the following:

Default: "/usr/share/xsessions,/var/lib/menu-xdg/xsessions,/usr/share/apps/tdm/sessions"

When Trinity is installed to a location other than /usr, typically /opt/trinity, as is the case on my system, TDM then will not correctly populate the sessions drop-down list.

The default in the sources should be like this:

Default: "@TDE_DATA_DIR@/share/apps/tdm/sessions,/usr/share/xsessions,/var/lib/menu-xdg/xsessions"

Because Trinity typically is relegated to being installed to a non-standard location (/opt/trinity rather than /usr) to avoid potential conflicts with KDE4, the SessionsDirs key should not default to being commented but instead be a live key that compiles automatically as suggested above.

The only work-around at this time is to manually modify tdmrc, either programmatically when building tdebase or after installation and adding the SessionsDirs key to tdmrc.

I will test a patch using the above suggestions, but I wanted to get this bug report filed. The report should be considered part of the R14.0.0 road map.
Comment 1 Darrell 2013-04-12 21:05:04 CDT 
Created attachment 1155 [details]
Patch to ensure SessionsDirs is correct

I successfully tested the attached patch. A sanity check would be wise before pushing to GIT.

On my system, where I build Trinity to install to /opt/trinity, the result looks this in the final package tdmrc file:

[X-*-Core]
...
SessionsDirs=/usr/share/xsessions,/var/lib/menu-xdg/xsessions,/opt/trinity/share/apps/tdm/sessions
Comment 2 Timothy Pearson 2013-04-20 18:50:33 CDT 
(In reply to comment #1)
> Created attachment 1155 [details]
> Patch to ensure SessionsDirs is correct
> 
> I successfully tested the attached patch. A sanity check would be wise before
> pushing to GIT.
> 
> On my system, where I build Trinity to install to /opt/trinity, the result
> looks this in the final package tdmrc file:
> 
> [X-*-Core]
> ...
> SessionsDirs=/usr/share/xsessions,/var/lib/menu-xdg/xsessions,/opt/trinity/share/apps/tdm/sessions

Looks good to me, go ahead and patch.  Essentially this sets a compile-time default for the compiled-in TDE prefix, which is acceptable as far as I am concerned.
Comment 3 Darrell 2013-04-20 19:09:09 CDT 
Patch pushed to GIT in commit f003ff9c.

Resolved. :)