1525 – Backporting KDE3 patches from openSUSE

By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 1525 - Backporting KDE3 patches from openSUSE

Summary: Backporting KDE3 patches from openSUSE

Status:	RESOLVED FIXED

Alias:	None

Product:	TDE
Classification:	Unclassified
Component:	tdebase (show other bugs)
Version:	3.5.13.2 [Trinity]
Hardware:	All Linux

Importance:	P5 enhancement
Assignee:	Francois Andriot

URL:

Depends on:
Blocks:	2014
	Show dependency tree / graph

Reported:	2013-05-25 09:43 CDT by Francois Andriot
Modified:	2014-10-06 00:59 CDT (History)
CC List:	5 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
tdepim 3.5.13.2 : fix kio_imap4 endless loop (4.44 KB, patch) 2013-05-25 09:57 CDT, Francois Andriot	Details \| Diff
tdepim 3.5.13.2 : add networkmanager support in kmail (7.89 KB, patch) 2013-05-25 10:42 CDT, Francois Andriot	Details \| Diff
tdelibs 3.5.13.2 : fix security issue when displaying certificate informations (4.32 KB, patch) 2013-05-31 16:08 CDT, Francois Andriot	Details \| Diff
tdelibs 3.5.13.2 : fix empty directory support in kzip (1.66 KB, patch) 2013-05-31 16:22 CDT, Francois Andriot	Details \| Diff
tdelibs 3.5.13.2 : fix possible DOS in konqueror (1.47 KB, patch) 2013-05-31 16:30 CDT, Francois Andriot	Details \| Diff
tqt3: fix zoom in qtextedit (906 bytes, patch) 2014-09-07 05:07 CDT, Francois Andriot	Details \| Diff
tqt3: add environment variable TQT_HOME_DIR and TQT_SYSTEM_DIR (1.27 KB, patch) 2014-09-07 05:41 CDT, Francois Andriot	Details \| Diff
Show Obsolete (7) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Francois Andriot 2013-05-25 09:43:37 CDT

Hello, after the Mandriva patches, this time I will try to get patches/updates from openSUSE's KDE3 and adapt them for Trinity.

Comment 1 Francois Andriot 2013-05-25 09:57:37 CDT

Created attachment 1287 [details]
tdepim 3.5.13.2 : fix kio_imap4 endless loop

Patch for kio_imap4 stability issues, thanks to Serghei Amelian .
http://trinity-devel.pearsoncomputing.net/?0::11019

Comment 2 Francois Andriot 2013-05-25 10:42:46 CDT

Created attachment 1288 [details]
tdepim 3.5.13.2 : add networkmanager support in kmail

Another patch from Serghei Amelian:
http://trinity-devel.pearsoncomputing.net/?0::11020

Comment 3 Slávek Banko 2013-05-30 13:03:33 CDT

I'm very hesitant about incorporating patch for NetworkManager support into 3.5.13.2 due to following reasons:

1) TDE 3.5.13.x branch does not have support for newer versions of NetworkManager
2) Not all distributions use NetworkManager
3) Not all users use NetworkManager
4) This solution is not suitable for R14
5) The solution should be more comprehensive - also for other applications - see Bug 1105

Comment 4 Francois Andriot 2013-05-30 13:32:31 CDT

No problem, do not push the patches as they are.
We can consider them as experimental test, rather than usable features.

I will look into more openSUSE patches soon.

Comment 5 Slávek Banko 2013-05-30 18:58:43 CDT

Comment on attachment 1287 [details]
tdepim 3.5.13.2 : fix kio_imap4 endless loop

This patch is incorrect and causes other problems.
The real bug was fixed in commit c830701a.

Comment 6 Francois Andriot 2013-05-31 16:08:10 CDT

Created attachment 1291 [details]
tdelibs 3.5.13.2 : fix security issue when displaying certificate informations

Fix a security issue in KSSL, see:
http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2011-3365

Note: the patch is for 3.5.13-SRU but that does not mean we should delay 3.5.13.2 for including this patch.

Comment 7 Francois Andriot 2013-05-31 16:22:14 CDT

Created attachment 1292 [details]
tdelibs 3.5.13.2 : fix empty directory support in kzip

Comment 8 Francois Andriot 2013-05-31 16:30:50 CDT

Created attachment 1293 [details]
tdelibs 3.5.13.2 : fix possible DOS in konqueror

Security issue, see: http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-2537

Comment 9 Slávek Banko 2013-06-01 08:45:20 CDT

Patches from attachment 1291 [details] and attachment 1293 [details] look sane.
Will be included into 3.5.13.2.

For patch from attachment 1292 [details] I do not know how to verify its function / if needed. When I open zip archive in Konqueror, I see an empty folder even without this patch.

Comment 10 Slávek Banko 2013-06-01 11:49:41 CDT

Comment on attachment 1291 [details]
tdelibs 3.5.13.2 : fix security issue when displaying certificate informations

Pushed to GIT in hash a67a4810 and also into v3.5.13-sru branch.

Comment 11 Slávek Banko 2013-06-01 11:50:25 CDT

Comment on attachment 1293 [details]
tdelibs 3.5.13.2 : fix possible DOS in konqueror

Pushed to GIT in hash 89cfde63 and also into v3.5.13-sru branch.

Comment 12 Francois Andriot 2014-09-07 05:07:15 CDT

Created attachment 2226 [details]
tqt3: fix zoom in qtextedit

Original patch:
0055-qtextedit_zoom.patch

qt-bugs@ issue : 
bugs.kde.org number :
applied: yes
author: Waldo Bastian <bastian@kde.org>

QTextEdit::zoomIn /QTextEdit::zoomOut does not work if the original
font had its size specified in pixels instead of points.
pointSize() returns 0 in such case.

Comment 13 Francois Andriot 2014-09-07 05:41:18 CDT

Created attachment 2227 [details]
tqt3: add environment variable TQT_HOME_DIR and TQT_SYSTEM_DIR

Original patch from opensuse QT3.

Comment 14 Slávek Banko 2014-09-15 21:25:26 CDT

Comment on attachment 2226 [details]
tqt3: fix zoom in qtextedit

Pushed to GIT in hash 9a892fca (TQt3) and 14f96e80 (Qt3).

Comment 15 Timothy Pearson 2014-10-05 23:53:04 CDT

Comment on attachment 1292 [details]
tdelibs 3.5.13.2 : fix empty directory support in kzip

I tracked this one down to its source--it's legit:
http://websvn.kde.org/?view=revision&revision=1057062

And it's in KDE4:
http://lists.kde.org/?l=kde-commits&m=125967200405525

Pushed to GIT in hash ddbe23e.

Comment 16 Timothy Pearson 2014-10-06 00:04:11 CDT

Comment on attachment 2227 [details]
tqt3: add environment variable TQT_HOME_DIR and TQT_SYSTEM_DIR

Patch looks useful and sane.  Pushed to GIT in hashes f0cc368 (qt3) and 16e2c76 (tqt3).

Comment 17 Timothy Pearson 2014-10-06 00:58:02 CDT

Comment on attachment 1288 [details]
tdepim 3.5.13.2 : add networkmanager support in kmail

KMail already has almost identical network detection support using the TDE network manager as of GIT hash 111cc21 (tdepim), therefore, this patch is not needed.

Comment 18 Timothy Pearson 2014-10-06 00:59:20 CDT

As there are no more patches remaining at this time I am going to close this report.  If more are needed at a later date (unlikely as we are fast becoming upstream for the KDE 3.5-style desktop on OpenSUSE) they should be handled in a new report.

Thanks for reporting, and for the patches!