By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 1545 - tde-guidance: mountconfig does not handle LABEL correctly in fstab
Summary: tde-guidance: mountconfig does not handle LABEL correctly in fstab
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: non-core programs (show other bugs)
Version: 3.5.13.2 [Trinity]
Hardware: All Other
: P5 normal
Assignee: Francois Andriot
URL:
Depends on:
Blocks:
 
Reported: 2013-06-13 09:23 CDT by Francois Andriot
Modified: 2013-06-13 16:20 CDT (History)
2 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
tde-guidance 3.5.13.2 : fix handling of LABEL in fstab in mountconfig (2.37 KB, patch)
2013-06-13 09:26 CDT, Francois Andriot 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Francois Andriot 2013-06-13 09:23:45 CDT 
Hello, on RHEL/Fedora distributions, when using LABEL in fstab, the partition are labelled using the mount point directly.
E.g. fstab contains (example):
LABEL=/      /     ext4    defaults 1 1
LABEL=/usr   /usr  ext4    defaults 1 2

But alas, the "mountconfig" does not finds them. The partitions are shown in the list since they are mounted (present via /etc/mtab), but the fstab-related information are missing.
When replacing LABEL= with device names in fstab, it works correctly.
Example:
/dev/sda1    /     ext4    defaults 1 1
/dev/sda2    /usr     ext4    defaults 1 1
Comment 1 Francois Andriot 2013-06-13 09:26:47 CDT 
Created attachment 1308 [details]
tde-guidance 3.5.13.2 : fix handling of LABEL in fstab in mountconfig

The root cause of the problem is that, when using filesystems labels containing "/" caracter, it is seen by hal as the "%" caracter.
(I dunno if this is an HAL bug or if this is a general problem with the "/" caracter in labels)

E.g:
 lshal|grep volume.label
 volume.label = %usr

The attached patch fixes this problem.
Also, it adds "support" for ext4 partitions.
Comment 2 Timothy Pearson 2013-06-13 16:20:29 CDT 
Even though we don't really support guidance any longer (largely due to long-maintenance issues as the code is Python and relies on HAL in places), I see no harm in this patch.  Committed to GIT in hash 3b6ac8e.

Thanks for reporting, and for the patch!