By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 1622 - Build issue: make available to build without xscreensaver installed
Summary: Build issue: make available to build without xscreensaver installed
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: tdebase (show other bugs)
Version: R14.0.0 [Trinity]
Hardware: All Linux
: P5 minor
Assignee: Alexander Golubev (Fat-Zer)
URL:
Depends on:
Blocks: 2014
  Show dependency tree / graph
 
Reported: 2013-08-12 20:21 CDT by Alexander Golubev (Fat-Zer)
Modified: 2014-04-28 19:02 CDT (History)
4 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
tdebase-bug-1622-enhance-xscreensaver-directory-detection.patch (1.34 KB, patch)
2013-08-12 20:22 CDT, Alexander Golubev (Fat-Zer) 		Details | Diff
Updated patch to support xscreensaver in an alternate directory (2.39 KB, patch)
2013-11-12 15:42 CST, Darrell 		Details | Diff
0001-tdebase-enhance-xscreensaver-directory-detection-see.patch (1.55 KB, patch)
2014-04-05 17:46 CDT, Alexander Golubev (Fat-Zer) 		Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Golubev (Fat-Zer) 2013-08-12 20:21:08 CDT 
For now xscreensaver is a runtime dependencie to tdelibs only because it's required to set configuration dir in the code.

This patch will enable user to manually define XSCREENSAVER_DIR. So you don't need to have xscreensaver package installed anymore.

Of course you must still have libXss and appropriate header files.

NOTE: It will be nice if the message is reviewed by native speakers...
Comment 1 Alexander Golubev (Fat-Zer) 2013-08-12 20:22:25 CDT 
Created attachment 1462 [details]
tdebase-bug-1622-enhance-xscreensaver-directory-detection.patch
Comment 2 Darrell 2013-11-12 15:42:20 CST 
Created attachment 1634 [details]
Updated patch to support xscreensaver in an alternate directory

>NOTE: It will be nice if the message is reviewed by native speakers...
I updated the text and added the XSCREENSAVER_DIR option to CMakeLists.txt.
Comment 3 Darrell 2013-11-12 15:42:56 CST 
>NOTE: It will be nice if the message is reviewed by native speakers...
I updated the text and added the XSCREENSAVER_DIR option to CMakeLists.txt.
Comment 4 Alexander Golubev (Fat-Zer) 2013-11-22 14:20:05 CST 
(In reply to comment #3)
> >NOTE: It will be nice if the message is reviewed by native speakers...
> I updated the text and added the XSCREENSAVER_DIR option to CMakeLists.txt.

That's wrong. 
option() statement is used to define only ON/OFF options. To define full-text option it's supposed to be defined with set() and CACHE specifier.
Comment 5 Alexander Golubev (Fat-Zer) 2014-04-05 17:46:07 CDT 
Created attachment 2020 [details]
0001-tdebase-enhance-xscreensaver-directory-detection-see.patch

Here is a new version of patch. If you don't count the comment and error message, it changes only the if condition. It's enough because find_path in FindXscreensaver.cmake creates CAHCE variable, so we haven't to do anything about that.
Comment 6 Slávek Banko 2014-04-28 18:47:49 CDT 
Comment on attachment 2020 [details]
0001-tdebase-enhance-xscreensaver-directory-detection-see.patch

Pushed to GIT in hash 9fb2cb29.