By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 1641 - Build issue: tdewallet was renamed but cmake still uses BUILD_KWALLET
Summary: Build issue: tdewallet was renamed but cmake still uses BUILD_KWALLET
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: tdeutils (show other bugs)
Version: R14.0.0 [Trinity]
Hardware: All Linux
: P5 blocker
Assignee: Timothy Pearson
URL:
Depends on:
Blocks:
 
Reported: 2013-08-22 04:26 CDT by Alexander Golubev (Fat-Zer)
Modified: 2013-08-31 12:49 CDT (History)
4 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Golubev (Fat-Zer) 2013-08-22 04:26:48 CDT 
yet another rename issue.
Comment 1 Timothy Pearson 2013-08-26 16:38:33 CDT 
Fixed in GIT hash 956d52a (tdeutils).

Thanks for reporting!
Comment 2 Darrell 2013-08-27 10:01:54 CDT 
Searching the source tree reveals there are many modules still referencing "KWallet" functions rather than "TDEWallet" functions. I realize the code itself does not know the difference as long as everything compiles and correctly points to final libs, but should those function calls be renamed too?
Comment 3 Timothy Pearson 2013-08-27 14:50:31 CDT 
Since it looks like we are going to need to do a full rebuild anyway (see Bug 1575) this might be a good time to rename the affected methods.  Can you handle this or should I?
Comment 4 Darrell 2013-08-27 17:56:22 CDT 
I'm tight for time right now and probably will be for several more days. If I'm lucky I will be able to run build sets at night. :-(

Here is a list of affected modules from a tree grep of several days ago:

tdeutils
tdegraphics
tdepim
kftpgrabber
koffice
kvpnc
kshowmail
kmyfirewall
tdesvn
krusader
knetworkmanager8
tdenetworkmanager
smb4k

That was a case-insensitive search, which includes change logs, which should not be updated. I think mostly we're concerned with KWallet::**?
Comment 5 Timothy Pearson 2013-08-27 18:43:47 CDT 
(In reply to comment #4)
> I'm tight for time right now and probably will be for several more days. If I'm
> lucky I will be able to run build sets at night. :-(
> 
> Here is a list of affected modules from a tree grep of several days ago:
> 
> tdeutils
> tdegraphics
> tdepim
> kftpgrabber
> koffice
> kvpnc
> kshowmail
> kmyfirewall
> tdesvn
> krusader
> knetworkmanager8
> tdenetworkmanager
> smb4k
> 
> That was a case-insensitive search, which includes change logs, which should
> not be updated. I think mostly we're concerned with KWallet::**?

So we need to change the KWallet namespace.  I can handle that via sed.
Comment 6 Timothy Pearson 2013-08-29 13:55:34 CDT 
The KWallet namespace was changed to TDEWallet a few days ago.  I imagine there may be a few cosmetic name changes required in various strings and documentation files, but overall I think this report can be closed if the rebuilds are successful.
Comment 7 Darrell 2013-08-29 16:09:24 CDT 
I'll try to update my sources and run a build set tonight.
Comment 8 Darrell 2013-08-30 10:09:39 CDT 
I rebuilt packages during the night. No build failures.

I don't use tdewallet and am unable to test usability.

I grepped the sources for other "[KWkw]allet" references and files. Looks like some cosmetic changes remain. I have some time now and will test some patches here before pushing to git. Then I'll close the report.
Comment 9 Darrell 2013-08-31 12:49:55 CDT 
The following patches were pushed to git:

97c19ee1 tdelibs
1e38678e tde-i18n
e9d00a46 tdeutils
bafc4152 kftpgrabber
f4cef261 kvpnc
471786e5 kshowmail
2d7a1fca smb4k
6ebfc149 knetworkmanager8