By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 1649 - Build issue: kshowmail "comparison with string literal results" warnings
Summary: Build issue: kshowmail "comparison with string literal results" warnings
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: non-core programs (show other bugs)
Version: R14.0.0 [Trinity]
Hardware: Other Linux
: P5 normal
Assignee: Michele Calgaro
URL:
Depends on:
Blocks: 2014
  Show dependency tree / graph
 
Reported: 2013-08-31 13:19 CDT by Darrell
Modified: 2014-06-06 13:30 CDT (History)
3 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
Patch to fix string literal warnings (3.93 KB, patch)
2013-08-31 13:19 CDT, Darrell 		Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darrell 2013-08-31 13:19:59 CDT 
Created attachment 1506 [details]
Patch to fix string literal warnings

The packatge builds but the following warnings appear:

accountsetupdialog.cpp:259:34: warning: comparison with string literal results in unspecified behaviour [-Waddress]
configlog.cpp:124:45: warning: comparison with string literal results in unspecified behaviour [-Waddress]
configlog.cpp:134:43: warning: comparison with string literal results in unspecified behaviour [-Waddress]/bin/sh ../../libtool --tag=CXX   --mode=link g++  -Wno-long-long -Wundef -ansi -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -Wcast-align -Wchar-subscripts -Wall -W -Wpointer-arith -fno-builtin -g3 -fno-inline -O2 -march=i486 -mtune=i686 -Wformat-security -Wmissing-format-attribute -Wno-non-virtual-dtor -fno-exceptions -fno-check-new -fno-common -I/usr/include/tqt  -avoid-version -module -L/opt/trinity/lib      -o kcm_kshowmailconfigactions.la -rpath /opt/trinity/lib/trinity configactions.lo  
configlog.cpp:158:43: warning: comparison with string literal results in unspecified behaviour [-Waddress]
configlog.cpp:160:48: warning: comparison with string literal results in unspecified behaviour [-Waddress]
configlog.cpp:165:41: warning: comparison with string literal results in unspecified behaviour [-Waddress]
configlog.cpp:167:46: warning: comparison with string literal results in unspecified behaviour [-Waddress]
serverdialog.cpp:220:34: warning: comparison with string literal results in unspecified behaviour [-Waddress]

I'm attaching a patch but as I'm not a C++ hacker, somebody please review and approve. :-)
Comment 1 Darrell 2013-08-31 13:20:28 CDT 
P.S. The patch does eliminate the warnings....
Comment 2 Michele Calgaro 2014-06-05 04:14:39 CDT 
Fixed in commit 1eaefc4.
Darrell, strcmp return 0 when two strings are identical, so you need a ! in front of it ;)
Comment 3 Darrell 2014-06-06 13:30:53 CDT 
Build log is clean here. Thanks. :)