By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 1683 - Move "advanced settings options" to main configuration window
Summary: Move "advanced settings options" to main configuration window
Status: NEW
Alias: None
Product: TDE
Classification: Unclassified
Component: tdebase (show other bugs)
Version: R14.0.x [Trinity]
Hardware: All All
: P5 normal
Assignee: Michele Calgaro
URL:
Depends on:
Blocks:
 
Reported: 2013-10-18 14:43 CDT by Michele Calgaro
Modified: 2018-05-27 10:50 CDT (History)
5 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
KControl user interface patch (46.63 KB, patch)
2013-12-18 03:14 CST, Michele Calgaro 		Details | Diff
Konqueror patch (893 bytes, patch)
2013-12-18 03:14 CST, Michele Calgaro 		Details | Diff
sample screenshot (92.43 KB, image/png)
2013-12-18 03:17 CST, Michele Calgaro 		Details
updated KControl patch, after KDE->TDE rename in commit 26dbe18e on 2013-12-26 (46.63 KB, patch)
2014-01-01 09:00 CST, Michele Calgaro 		Details | Diff
KControl patch for tdehtml / ui (45.29 KB, patch)
2014-01-22 20:31 CST, Slávek Banko 		Details | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michele Calgaro 2013-10-18 14:43:40 CDT 
If a configuration window has a button for "advanced settings options" shown on a separate dialog window, we should aim at moving the options to the main configuration window, either by integrating the options in an existing category or by adding a new category.

As a start, Konqueror -> Web Behavior -> Tabbed browsing options.

If you find other "advanced buttons", please add to this bug report.

PS: Tim, Calvin, in the bugzilla "component" list is it possible to add a "all TDE" entry? I choose tdebase for this bug, but it actually relates to TDE as a whole
Comment 1 Darrell 2013-10-18 15:07:24 CDT 
I always use "other (any)." :-)
Comment 2 Darrell 2013-10-18 15:20:38 CDT 
From the KControl Reorganization Effort etherpad (http://trinity.etherpad.trinitydesktop.org/40):

* Window Behavior -> Advanced Tab -> Window Actions tab

* Screen Saver -> Advanced Options -> to parent dialog

* Appearance & Themes -> Background -> Advanced Options -> parent dialog.
Comment 3 Michele Calgaro 2013-12-18 03:14:06 CST 
Created attachment 1730 [details]
KControl user interface patch

These two patches moves the "tabbed browsing" options of Konqueror from the Advanced dialog to a new category called "User interace". I didn't call it "Tabbed browsing" because we could add more options to the same category later. Anyhow the options are contained inside a group called "Tabbed Browsing".

The AdvancedTab*** files have been removed and instead userInter*** files have been added.

After you commit the patch to GIT, please mark again this bug as "NEW", since there are other advanced options that needs to be moved somewhere else later.
Comment 4 Michele Calgaro 2013-12-18 03:14:38 CST 
Created attachment 1731 [details]
Konqueror patch
Comment 5 Michele Calgaro 2013-12-18 03:17:18 CST 
Created attachment 1732 [details]
sample screenshot
Comment 6 Darrell 2013-12-18 15:48:22 CST 
Michele, the konqy patches look very nice! :-)

I did not test every check box, but of the several I tested all functioned as expected.
Comment 7 Michele Calgaro 2013-12-18 19:04:38 CST 
> I did not test every check box, but of the several I tested all functioned as
> expected.

I also didn't test all options, but the 4 or 5 I tried all worked ok.
Anyhow the code for those options is exactly the same, so I don't expect problems on that side :)
Comment 8 Michele Calgaro 2014-01-01 09:00:21 CST 
Created attachment 1814 [details]
updated KControl patch, after KDE->TDE rename in commit 26dbe18e on 2013-12-26
Comment 9 Darrell 2014-01-22 03:16:01 CST 
General note: the konqueror patch works fine and I have been using since the patch was available. But the patch should not be pushed to git until the help handbook is updated. :)
Comment 10 Michele Calgaro 2014-01-22 06:34:21 CST 
(In reply to comment #9)
> General note: the konqueror patch works fine and I have been using since the
> patch was available. But the patch should not be pushed to git until the help
> handbook is updated. :)

We are in the process of reviewing the handbooks, this will not be the only change required to the Konqueror handbook for sure.
So I would say that if Slavek/Tim want to push the patch, they should go ahead. When we review the related handbook, we just add the documentation for this as well.
Comment 11 Darrell 2014-01-22 13:20:04 CST 
We need bug 1813 resolved with the new status option of DOCREVIEW. Then we can push patches like this and have a way to track required handbook updates.
Comment 12 Slávek Banko 2014-01-22 13:30:17 CST 
Before pushing patch to GIT I want to test one thing - whether patch cause that all texts will be in this moment untranslated. I know for english speakers this is not essential. But for other languages ​​it represents another piece which will be not translated in R14.0.0 against 3.5.13.x.
Comment 13 Michele Calgaro 2014-01-22 19:27:34 CST 
(In reply to comment #12)
> Before pushing patch to GIT I want to test one thing - whether patch cause that
> all texts will be in this moment untranslated. I know for english speakers this
> is not essential. But for other languages ​​it represents another piece which
> will be not translated in R14.0.0 against 3.5.13.x.

In theory it should still be ok. I am using the same entities and strings that  were in the Advanced Tab, so translation should remain the same.
Comment 14 Slávek Banko 2014-01-22 20:31:47 CST 
Created attachment 1886 [details]
KControl patch for tdehtml / ui

Looks good, translations are as they should be.

Just one correction - m_pHoverCloseButton is not enabled / disabled immediately when switching m_pPermanentCloseButton.
Comment 15 Darrell 2014-01-31 14:01:24 CST 
I added a proper bookmark in the handbook for the new User Interface module. I renamed the desktop file from tdehtml_userInter.desktop to tdehtml_userinterface.desktop to be consistent with the naming of other desktop files.

I performed only nominal editing in the handbook. Generally, the handbook is like most handbooks and is out of date and inaccurate.

Patches pushed to git in commit a0e3f4ae.

The patch does not close the bug report because this is a general bug report for all "Advanced" dialogs.
Comment 16 Darrell 2014-02-23 20:43:21 CST 
With a new profile, the checkbox "Confirm when closing windows with multiple tabs" will always remain unchecked. Uncheck the option, select the Apply button, close the dialog, immediately reopen the dialog, and the option is enabled.
Comment 17 Michele Calgaro 2014-02-23 23:51:16 CST 
(In reply to comment #16)
Thanks Darrell. Bug confirmed: it always remains unchecked.
I think this bug may have been there even before this patch. I remember also that some options do not change their behavior until Konqueror is restarted, which is a bug as well.
We will have to address all these small issues.
Comment 18 Darrell 2014-02-24 00:10:18 CST 
The bug is not in 3.5.13.2 and not in an R14 package set from Jan 2013 (I tested in a VM we used for other testing). The bug is not exactly as I previously shared.

The bug depends upon the current configuration. When disabled in the config file then the user cannot enable. Conversely, when the option is enabled then the user cannot disable.

The only work-around is manually edit the config file.
Comment 19 Darrell 2014-05-27 12:40:37 CDT 
Another Advanced dialog:

Konqueror -> Properties -> Permissions tab -> Advanced Permissions

Yet Another Extra Click and hiding the information is silly because there are other ways to find the same information, even in Konqueror.
Comment 20 Michele Calgaro 2014-05-27 22:25:19 CDT 
> Yet Another Extra Click and hiding the information is silly because there
> are other ways to find the same information, even in Konqueror.
I don't think it was about hiding information.
Anyhow, well spotted (as usual). I think the "advanced permissions" would be good as an extra tab, such to have: General. Permissions, Advanced permissions, Preview.
How do you think?
Comment 21 Darrell 2014-05-27 23:51:39 CDT 
Seems another tab substitutes the tab for the Advanced button. Still requires an additonal click.

The Advanced Permissions dialog can be shrunk. After shrinking, replacing the button with the dialog places all of the information in one place, in one group box. No additional tab needed. That would mean a subsequent larger Properties dialog default size because all tabs would have to be the same size as the Permissions tab.