By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 1706 - Improve option to change the TDE menu button icon
Summary: Improve option to change the TDE menu button icon
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: tdebase (show other bugs)
Version: R14.0.0 [Trinity]
Hardware: Other Linux
: P5 enhancement
Assignee: Michele Calgaro
URL:
Depends on:
Blocks: 2014
  Show dependency tree / graph
 
Reported: 2013-11-08 17:41 CST by Darrell
Modified: 2014-06-06 13:27 CDT (History)
3 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
Mockup of proposed dialog change (9.54 KB, image/png)
2013-11-08 20:31 CST, Darrell 		Details
Patch to improve text string with an action verb (528 bytes, patch)
2013-11-09 12:14 CST, Darrell 		Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darrell 2013-11-08 17:41:53 CST 
The option to change the TDE menu button icon is in the Panel configuration Menus dialog, located to the far right of the 'TDE Menu' group box. Clicking on the icon is not intuitive. Two ways to improve usability:

* Change the text string:

AS IS:
Menu button icon:

CHANGE TO:
Change menu button icon:

* Move the text string and button to the top of that particular layout column, which currently is occupied by 'Open menu on mouse hover', and push the remaining widgets in that column layout down one spot.
Comment 1 Darrell 2013-11-08 19:13:28 CST 
On second thought, a better location to move the text string and button is in the first column layout, just below the 'Edit TDE Menu' pushbutton.
Comment 2 Darrell 2013-11-08 20:31:48 CST 
Created attachment 1610 [details]
Mockup of proposed dialog change

I'm attaching a mockup of a proposed dialog change. I don't know how to use the TQt Designer --- Just barely enough to create a mockup.
Comment 3 Darrell 2013-11-09 12:14:53 CST 
Created attachment 1615 [details]
Patch to improve text string with an action verb

This patch updates the text string with an action verb, thereby helping better identify the dialog option and option's purpose.

I tested the patch.

This patch does not move the text string and pushbutton as requested in the problem description and shown in the mockup picture.

A sanity review of the patch (a simple text change) by one of the coders should suffice to push at least this patch to git although work is needed to rearrange the dialog.
Comment 4 Darrell 2013-11-24 15:24:50 CST 
The patch in attachment 1615 [details] changed only the text string. Pushed to GIT in commit a615b201. Work remains to move the widgets as proposed.
Comment 5 Michele Calgaro 2014-06-04 06:43:50 CDT 
Fixed in commit 8a8b8ce.
The button is now located under the "Edit TDE menu" button and the label "Change menu icon" has been included in the button text itself, so that the two buttons have the same width. The current menu icon is displayed on the button itself.
Comment 6 Michele Calgaro 2014-06-04 06:45:07 CDT 
Forgot to mention: you might need to restart kicker to see the changes.
Comment 7 Darrell 2014-06-06 13:27:25 CDT 
Looks nice. Thanks. :)