By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 1737 - Remove code sources of KDE_IS_VERSION
Summary: Remove code sources of KDE_IS_VERSION
Status: NEW
Alias: None
Product: TDE
Classification: Unclassified
Component: other (any) (show other bugs)
Version: R14.0.x [Trinity]
Hardware: Other Linux
: P5 enhancement
Assignee: Timothy Pearson
URL:
Depends on:
Blocks: 2969
  Show dependency treegraph
 
Reported: 2013-11-26 19:26 CST by Darrell
Modified: 2018-08-30 02:24 CDT (History)
3 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Darrell 2013-11-26 19:26:36 CST
The Trinity sources are filled with legacy KDE version checks in the form of:

#if KDE_IS_VERSION
  some code...
#endif

Such references to old KDE versions no longer are needed.

Some of the KDE_IS_VERSION checks are for KDE 4 beta such as 3, 90, 90.

All of these version checks should be removed from the Trinity code base.
Comment 1 Michele Calgaro 2013-11-26 19:29:13 CST
I agree, we should try to simplify the code were possible -> easier maintenance.
Comment 2 Darrell 2013-11-26 19:56:49 CST
Likely there are other #if, #ifdef, #ifndef, etc., statements that can be removed. For example, I doubt we'll ever support MS Windows.

We should open other reports respectively. Let me know of any candidates. I'll write the enhancement request.