By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 1786 - Trinity kfinddialog history is limited to a maxcount of 10 items
Summary: Trinity kfinddialog history is limited to a maxcount of 10 items
Status: NEW
Alias: None
Product: TDE
Classification: Unclassified
Component: other (any) (show other bugs)
Version: R14.0.x [Trinity]
Hardware: Other Linux
: P5 normal
Assignee: Timothy Pearson
URL:
Depends on:
Blocks: 2968
  Show dependency tree / graph
 
Reported: 2013-12-24 18:38 CST by Darrell
Modified: 2018-08-30 02:52 CDT (History)
3 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
Patch to change the kfinddialog maxcount from 10 to 25 (610 bytes, patch)
2013-12-24 18:38 CST, Darrell 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darrell 2013-12-24 18:38:46 CST 
Created attachment 1746 [details]
Patch to change the kfinddialog maxcount from 10 to 25

I've lived with this bug way too long. Currently the Find dialog history maxcount is hard-coded to 10 items. This should be configurable.

Because the kfinddialog is a global utility, ideally the maxcount should be configurable. I don't know the best place in kcontrol to offer such a configuration. Possibly TDE Components.

For now I'm attaching a sledge hammer patch to change the default to 25.
Comment 1 Michele Calgaro 2013-12-25 21:07:32 CST 
> For now I'm attaching a sledge hammer patch to change the default to 25.

Rather than a sledge hammer patch (which may not fit everyone's needs), I favor the idea of a global config option.
For the location I suggest to create an entry TDEComponents -> Global options
where we put options that affect TDE globally.
An example of another option to add there would be a global "cycle tabs with mouse wheel" which would affect the behavior of all Tabbar controls in TDE.

I also suggest we move the contents of TDEComponents -> File Manager -> Quick copy and move tab to the Behavior tab, to simplify the interface.
Comment 2 Darrell 2013-12-25 21:17:24 CST 
I attached the patch only to help anybody expand the concept to a configuration option (to easily find the maxcount setting). For now I can live with my sledge hammer as 25 entries will satisfy me.

Or should. :)

I like the idea of a TDE Components -> Global Options. Probably a good place for various kdeglobals "hidden" options to be configured. Before we create such a new kcm dialog, we should have a few more options to populate, rather than just the one from this bug report.

Tab bar cycling can already be controlled in the Panel -> Taskbar configuration dialog. Near the top of the dialog. :)

>I also suggest we move the contents of TDEComponents -> File Manager ->
>Quick copy and move tab to the Behavior tab, to simplify the interface.
Good idea, which will make the dialog available in Konqueror too.
Comment 3 Michele Calgaro 2013-12-26 21:36:57 CST 
> Tab bar cycling can already be controlled in the Panel -> Taskbar configuration
> dialog. Near the top of the dialog. :)

Actually the option I proposed does not relate to the taskbar, but refers to the tabbar control used to display multiple tabs in several applications. 
In bug 909 and bug 910 we introduce two options to control this in Konqueror and Konsole. Most likely a user would like to have the same behavior throughout all TDE applications, so a global option would do that.

PS: i suggest we set the status of this bug back to NEW since the attached patch is a sledge hammer as you said, but I let the final decision to you.
Comment 4 Darrell 2013-12-26 22:03:59 CST 
Note to all: the attached patch is a sledge hammer and is intended only to highlight where the the maxcount is hard-coded. I'm using the patch to relieve my own grief but that is all.

>Actually the option I proposed does not relate to the taskbar, but refers to
>the tabbar control used to display multiple tabs in several applications.
Ah, okay. Sounds good. That probably should be a new enhancement request, with some kind of starter list of apps to which the configuration would apply.