By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 1804 - Add vbox as a recognized xml mimetype
Summary: Add vbox as a recognized xml mimetype
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: tdelibs (show other bugs)
Version: R14.0.0 [Trinity]
Hardware: Other Linux
: P5 normal
Assignee: Timothy Pearson
URL:
Depends on:
Blocks: 1779
  Show dependency treegraph
 
Reported: 2013-12-31 20:17 CST by Darrell
Modified: 2014-01-06 11:47 CST (History)
3 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:


Attachments
Patch to add *.vbox to tdelibs/kate/data/xml.xml (1.12 KB, patch)
2013-12-31 20:17 CST, Darrell
Details | Diff
Patch to add *.vbox to tdelibs/mimetypes/text/xml.desktop (391 bytes, patch)
2013-12-31 20:18 CST, Darrell
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darrell 2013-12-31 20:17:58 CST
Created attachment 1812 [details]
Patch to add *.vbox to tdelibs/kate/data/xml.xml

For years the VirtualBox developers assigned xml as the file extension to all VirtualBox configuration files, which are indeed xml files.

I don't know which VirtualBox version, I think 4.x, they changed that file extension from xml to vbox.

The declaration at top of the vbox files is clear that the file is an xml file. Unfortunately neither the kate xml.xml syntax file recognizes the vbox extension nor does the Trinity file association scheme recognize vbox as an xml mimetype.

Attached are two proposed patches. One modifies the kate xml.xml file. The second modifies the Trinity file association scheme to add vbox to the list of known xml mimetype file extensions.
Comment 1 Darrell 2013-12-31 20:18:53 CST
Created attachment 1813 [details]
Patch to add *.vbox to tdelibs/mimetypes/text/xml.desktop
Comment 2 Michele Calgaro 2014-01-05 09:16:48 CST
I tested the patch, works well here. .vbox files are now open with syntax highlight automatically enabled.
IMO, you can push it to GIT.
Comment 3 Darrell 2014-01-05 12:33:27 CST
Which patch did you test? Which patch is preferred? I posted both patches because I don't know which is preferred.
Comment 4 Michele Calgaro 2014-01-05 21:16:07 CST
(In reply to comment #3)
> Which patch did you test? Which patch is preferred? I posted both patches
> because I don't know which is preferred.

Sorry if it wasn't clear Darrell, yesterday I was up way to late. I actually tested both patches.
The first patch suffices in Kate. 
The second patch alone does not enable syntax highlighting in Kate.

IMO the first patch *only* should be pushed ti GIT. I don't think the second patch should be pushed because vbox files could have different file associations compared to xml files. Look for example at rss files: their extension is included in xml.xml but they have their own mimetype rss.desktop file.
Eventually you could create a vbox.desktop entry in the mimetypes folder if you needed it.
Comment 5 Darrell 2014-01-06 11:46:48 CST
Patch from attachment 1812 [details] pushed to git in commit c5189a79.