By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 1838 - Build issue: Change WITH_HAL and WITH_TDEHWLIB configuration defaults
Summary: Build issue: Change WITH_HAL and WITH_TDEHWLIB configuration defaults
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: tdebase (show other bugs)
Version: R14.0.0 [Trinity]
Hardware: Other Linux
: P5 normal
Assignee: Timothy Pearson
URL:
Depends on:
Blocks:
 
Reported: 2014-01-20 16:26 CST by Darrell
Modified: 2014-01-20 17:30 CST (History)
3 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darrell 2014-01-20 16:26:02 CST 
Current tdebase defaults:

option( WITH_ALL_OPTIONS "Enable all optional support" OFF )
option( WITH_HAL "Enable HAL support" ${WITH_ALL_OPTIONS} )
option( WITH_TDEHWLIB "Enable TDE hardware library support" OFF )

Proposed change:

option( WITH_ALL_OPTIONS "Enable all optional support" OFF )
option( WITH_HAL "Enable HAL support" OFF )
option( WITH_TDEHWLIB "Enable TDE hardware library support" ${WITH_ALL_OPTIONS} )
Comment 1 Timothy Pearson 2014-01-20 16:28:32 CST 
Looks good to me!  After all these years we *finally* get to switch off HAL!
Comment 2 Darrell 2014-01-20 17:30:11 CST 
Change made in commit 63473fdc.

To all:

If building for mixed distro releases, consider something like the following in the build script:

if [ -x /usr/sbin/hald ]; then
  BUILD_HAL=${BUILD_HAL:-ON}
  BUILD_TDEHWLIB=${BUILD_TDEHWLIB:-OFF}
else
  BUILD_HAL=${BUILD_HAL:-OFF}
  BUILD_TDEHWLIB=${BUILD_TDEHWLIB:-ON}
fi
...
cmake $SOURCES_ROOT \
...
  -DWITH_HAL=${BUILD_HAL} \
  -DWITH_TDEHWLIB=${BUILD_TDEHWLIB} \
...