By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 1910 - Remove code references to KInfo Center
Summary: Remove code references to KInfo Center
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: other (any) (show other bugs)
Version: R14.0.0 [Trinity]
Hardware: Other Linux
: P5 normal
Assignee: Timothy Pearson
URL:
Depends on:
Blocks: 2014
  Show dependency tree / graph
 
Reported: 2014-02-04 15:11 CST by Darrell
Modified: 2014-09-29 17:08 CDT (History)
3 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darrell 2014-02-04 15:11:02 CST 
The KInfo Center no longer is used. All modules, help handbooks, usages, etc.  have been moved to KControl.

There remain code snippets referencing or testing whether KInfo Center is being used. Although causing no direct harm, those snippets should be removed to optimize the code.

Side note: starting kinfocenter from the command line or Alt+F2 with KDE4 installed starts the KDE4 version because kinfocenter no longer exists anywhere in Trinity.
Comment 1 Timothy Pearson 2014-09-27 11:47:34 CDT 
Can you post an example snippet so that I know what exactly you are referring to?

Thanks!

Tim
Comment 2 Darrell 2014-09-27 14:39:36 CDT 
>Can you post an example snippet so that I know what exactly you are referring to?
I just grepped the sources. Best I can tell is the remnants are in po files.

>Side note: starting kinfocenter from the command line or
>Alt+F2 with KDE4 installed starts the KDE4 version because
>kinfocenter no longer exists anywhere in Trinity.
I wonder whether TDE should add a sym link: $TDEDIR/bin/kinfocenter->$TDEDIR/bin/khelpcenter (Peripherals->Information).
Comment 3 Timothy Pearson 2014-09-27 22:07:54 CDT 
I just grepped the source again; most of these are .po files as stated in tde-i18n.  There are several docbooks that need to be cleaned up as well.

Should the .po files block R14?  I'm not sure what the harm is of shipping some obsolete translations.  As I do not yet know how those .po files were generated and/or updated in the first place this could end up being a lengthy sticking point.
Comment 4 Darrell 2014-09-28 10:02:33 CDT 
>Should the .po files block R14?
I don't think so. The bug report should be left open.

Should also be left open to address the corner case of KDE4 kinfocenter opening.
Comment 5 Timothy Pearson 2014-09-29 15:32:14 CDT 
I am going though and removing references now.  First commit is GIT hash f285b77 (tdelibs); more to come.

However, I am concerned we lost something when we dropped the info center.  In a single Amarok translation file there is a reference to a Protocols section in kinfocenter that does not appear to exist in kcontrol.  Digging further yielded this screenshot:
http://slaout.linux62.org/kde-wishs/kio-wizard/

Did such a module exist in kcontrol at one point?  I don't want to modify the Amarok translation string until we know if this is missing in kcontrol and needs to be added back in.
Comment 6 Darrell 2014-09-29 16:15:05 CDT 
The Protocols module was removed in commit 50741cc5 2014-02-10. Background discussions for the patch are in bug 1920.
Comment 7 Timothy Pearson 2014-09-29 17:08:07 CDT 
(In reply to Darrell from comment #6)
> The Protocols module was removed in commit 50741cc5 2014-02-10. Background
> discussions for the patch are in bug 1920.

OK, thanks for that info.

Remaining references removed in GIT hashes 4344b69 (tde-i18n) and e5dadd5 (amarok).

Thanks for reporting!