By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 1999 - Logout gray fadeaway appears all the time regardless of the kcontrol setting
Summary: Logout gray fadeaway appears all the time regardless of the kcontrol setting
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: tdebase (show other bugs)
Version: R14.0.0 [Trinity]
Hardware: Other Linux
: P5 normal
Assignee: Timothy Pearson
URL:
Depends on:
Blocks:
 
Reported: 2014-03-07 14:26 CST by Darrell
Modified: 2014-03-18 19:22 CDT (History)
4 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
Patch to add secondary fadeaway control (14.97 KB, patch)
2014-03-09 19:02 CDT, Darrell 		Details | Diff
tdebase : make fancy logout checkbox grayed if fadeaway is disabled (647 bytes, patch)
2014-03-10 15:19 CDT, Francois Andriot 		Details | Diff
Updated patch to add secondary fadeaway control (15.09 KB, patch)
2014-03-10 17:20 CDT, Darrell 		Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darrell 2014-03-07 14:26:56 CST 
In KControl->TDE Components->Session Manager, when 'Confirm logout' is enabled and 'Show fancy logout fadeaway' is disabled, the gray fadeaway appears anyway. This is true with both the classic and kickoff menus.

The gray fadeaway should appear only when 'Confirm logout' is enabled and 'Show fancy logout fadeaway' is enabled. Probably some missing brackets disrupt the AND operation.

Note: the fadeaway GUI controls have yet to be added as needed by bug 258.
Comment 1 Francois Andriot 2014-03-08 04:25:39 CST 
I believe this is in fact the expected behaviour.

I think there has always been 2 different fadeaway: the default one, and the "fancy" one.
The check box in kcontrol activates the fancy fadeway. If you disable it, then the default fadeaway is used. This one is simpler and faster, so it runs better on older hardware.

The problem is that, until 3.5.13.2 , the default fadeaway was broken and did not work, so we had forgotten that it existed.

Look at commit 3a84ecae .
Comment 2 Darrell 2014-03-08 13:16:38 CST 
From my perspective the broken way is the correct way.

The folks who want eye candy can have that and those who don't should have that too. This has always been the way of KDE/TDE configurations.

I believe the gray fadeaway should not appear at all when the kcontrol option is disabled.

In bug 258 I reported that the fadeaway is too slow for older hardware. That argument still applies.

I propose the "definition" of "fancy fadeaway" be changed. When the option is enabled the gray fadeaway appears and when disabled the fadeaway does not appear.

When bug 258 is completed and full controls are provided, those controls will control the speed and darkness of the fadeaway, but the current check box would control whether or not the fadeaway appears.
Comment 3 Darrell 2014-03-09 16:40:57 CDT 
I suppose somebody will scream if the fadeaway is removed. A new check box could be added:

| | Confirm logout
| | Show logout fadeaway <-NEW OPTION
    | | Show fancy logout fadeaway <-Indented as a child check box

Both fadeaway options are disabled when 'Confirm logout' is unchecked.

'Show fancy logout fadeaway' is disabled when 'Show logout fadeaway' is unchecked.
Comment 4 Darrell 2014-03-09 19:02:51 CDT 
Created attachment 2001 [details]
Patch to add secondary fadeaway control

The patch seems to work for me, as described in comment 3. There is no indentation but that does not seem important.
Comment 5 Francois Andriot 2014-03-10 01:16:51 CDT 
Still a minor issue with patch:
when "Confirm Logout" (1st checkbox) is disabled, closing then reopeing the control panel: "Show Fancy Logout" (3rd checkbox) is not grayed, but it should.
Comment 6 Darrell 2014-03-10 13:24:49 CDT 
I don't know how to fix that.
Comment 7 Francois Andriot 2014-03-10 15:19:45 CDT 
Created attachment 2002 [details]
tdebase : make fancy logout checkbox grayed if fadeaway is disabled

Apply this patch after yours, it should do the trick (works on my computer).
Comment 8 Darrell 2014-03-10 17:20:34 CDT 
Created attachment 2004 [details]
Updated patch to add secondary fadeaway control

Patch updated by merging attachments 2001 and 2002.
Comment 9 Slávek Banko 2014-03-18 19:19:45 CDT 
Comment on attachment 2004 [details]
Updated patch to add secondary fadeaway control

Fixed (showLogoutStatusDialog changed to confirmLogoutCheck)
and pushed to GIT in hash 907d8b7d.
Comment 10 Slávek Banko 2014-03-18 19:22:52 CDT 
Looks good, thank you both.