By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 2033 - Many applications crash at 8-bit color depth Xserver
Summary: Many applications crash at 8-bit color depth Xserver
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: qt3 (show other bugs)
Version: R14.0.0 [Trinity]
Hardware: Other Linux
: P5 major
Assignee: Slávek Banko
URL:
Depends on:
Blocks:
 
Reported: 2014-04-21 10:56 CDT by Slávek Banko
Modified: 2014-05-19 21:17 CDT (History)
3 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
Crash on 8-bit depth - twin (44.80 KB, text/plain)
2014-04-21 10:56 CDT, Slávek Banko 		Details
Fix crash on 8-bit color depth Xserver (1.92 KB, patch)
2014-05-17 20:31 CDT, Slávek Banko 		Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Slávek Banko 2014-04-21 10:56:35 CDT 
Created attachment 2039 [details]
Crash on 8-bit depth - twin

During the test on older hardware whose graphics card only allows 8-bit color depth, I have observed that many application crashes - beginning TWin on the TDM login screen.

It seems that the bug has its origin in TQt3.
See the attached backtrace.
Comment 1 Slávek Banko 2014-04-21 11:01:06 CDT 
To simulate the problem is sufficient minimalist xorg.conf:

Section "Screen"
        Identifier      "Default Screen"
        DefaultDepth    8
EndSection
Comment 2 Timothy Pearson 2014-04-23 17:24:08 CDT 
I can confirm this bug on R14.  Is this a regression or was this bug always hidden away in TDE/KDE3?
Comment 3 Slávek Banko 2014-04-23 17:39:04 CDT 
(In reply to Timothy Pearson from comment #2)
> I can confirm this bug on R14.  Is this a regression or was this bug always
> hidden away in TDE/KDE3?

Before upgrading to Wheezy + TDE R14.0.0 (TQt3) was on my SGI Indy installed Lenny + KDE 3.5.9 (Qt3) and it worked without crashes (although slowly - it's an old machine).

So yes, it's a regression. I'll try to verify if also applies to TDE 3.5.13.x.
Comment 4 Slávek Banko 2014-04-23 17:54:05 CDT 
(In reply to Slávek Banko from comment #3)
> So yes, it's a regression. I'll try to verify if also applies to TDE
> 3.5.13.x.

Confirmed - on current TDE 3.5.13.2 is the same problem. Unfortunately I do not have available the older version so I cannot test when the problem began to manifest.
Comment 5 Timothy Pearson 2014-04-23 18:06:43 CDT 
(In reply to Slávek Banko from comment #4)
> (In reply to Slávek Banko from comment #3)
> > So yes, it's a regression. I'll try to verify if also applies to TDE
> > 3.5.13.x.
> 
> Confirmed - on current TDE 3.5.13.2 is the same problem. Unfortunately I do
> not have available the older version so I cannot test when the problem began
> to manifest.

I suspect this bug was introduced when true ARGB support was added to TQt3/TDE.  TDE 3.5.13.2 contained ARGB support in kdecore, so this bolsters my theory.
Comment 6 Slávek Banko 2014-05-17 20:31:48 CDT 
Created attachment 2058 [details]
Fix crash on 8-bit color depth Xserver

I have long examined the problem until I managed to fix it in one-line patch for qwidget_x11.cpp!

I found that when converting pixmap icon to 24-bit are data written back to TQImage. I think that it is incorrect. Please test the patch and confirm me whether the hypothesis is correct.
Comment 7 Timothy Pearson 2014-05-18 22:47:31 CDT 
(In reply to Slávek Banko from comment #6)
> Created attachment 2058 [details]
> Fix crash on 8-bit color depth Xserver
> 
> I have long examined the problem until I managed to fix it in one-line patch
> for qwidget_x11.cpp!
> 
> I found that when converting pixmap icon to 24-bit are data written back to
> TQImage. I think that it is incorrect. Please test the patch and confirm me
> whether the hypothesis is correct.

Patch looks good; not sure why that ls[x] line was present in the first place.  

The problem was originally introduced here in order to repair corrupt titlebar icons being displayed in ARGB mode:
http://git.trinitydesktop.org/cgit/tqt3/commit/src/kernel/qwidget_x11.cpp?id=e980c0380f96c0eea185e86a464f140b012e2818

I say go ahead and commit; good job tracking this down!
Comment 8 Slávek Banko 2014-05-19 21:17:05 CDT 
Comment on attachment 2058 [details]
Fix crash on 8-bit color depth Xserver

Pushed to GIT in hash d5059601 (tqt3) and 1afc62ef (qt3).