By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 2038 - Review/improve desktop lock code
Summary: Review/improve desktop lock code
Status: NEW
Alias: None
Product: TDE
Classification: Unclassified
Component: tdebase (show other bugs)
Version: R14.0.x [Trinity]
Hardware: Other Linux
: P5 normal
Assignee: Timothy Pearson
URL:
Depends on:
Blocks:
 
Reported: 2014-04-28 01:09 CDT by Michele Calgaro
Modified: 2018-05-27 10:47 CDT (History)
2 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michele Calgaro 2014-04-28 01:09:56 CDT 
The code in tdebase/kdesktop/lock looks very messy.
There are several variables named "trinity_desktop_lock_*", macros as ENABLE_CONTINUOUS_LOCKDLG_DISPLAY and DISABLE_CONTINUOUS_LOCKDLG_DISPLAY and processes and timers named "mHack*".
All these things give the impression the code was heavily/poorly hacked from the KDE 3.5.10 days and from a first analysis I wonder if all that stuff is or was really necessary.

Cleaning up the code is the minimum that has to be done (for example replacing those macros with proper functions). Possibly analyze and remove unused/unnecessary code would be a plus.

This should be done after v14.0.0 is out (perhaps for v14.1.0) to avoid introducing potential new bugs at this time.
Comment 1 Timothy Pearson 2014-04-28 01:20:55 CDT 
It *is* very messy.  It was bad enough in the KDE 3.5.x days (all the mHack* stuff), and it has only gotten worse now that there are essentially two completely different lock systems crammed into one executable.