By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 2050 - New Kate alert highlighting is ugly and hard to read
Summary: New Kate alert highlighting is ugly and hard to read
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: tdelibs (show other bugs)
Version: R14.0.0 [Trinity]
Hardware: Other Linux
: P5 minor
Assignee: Michele Calgaro
URL:
Depends on:
Blocks:
 
Reported: 2014-05-06 16:37 CDT by Timothy Pearson
Modified: 2014-05-10 07:14 CDT (History)
5 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Pearson 2014-05-06 16:37:24 CDT 
This commit changed the Kate alert highlighting color:

https://git.trinitydesktop.org/cgit/tdelibs/commit/kate/data/alert.xml?id=bb647dca1516a45ce18f2e040bd20528f588e2fe

The new color scheme is horribly ugly and hard to read.  To try it, type FIXME in a C/C++ document in Kate.

The old scheme was black text and a light pink highlight that was easy to read.  Should part of this patch be reverted?
Comment 1 Timothy Pearson 2014-05-06 16:38:17 CDT 
Adding Darrell to CC list as he is more involved in policy decisions than most.
Comment 2 Michele Calgaro 2014-05-09 04:26:45 CDT 
Currently, the Kate syntax highlighting files are aligned as much as possible with the KDE ones. If the preference is to keep the old style, I can revert the part of the commit related to it.
I agree with Tim that the old style was somehow better (or perhaps I was just used to it).
Let's see Darrell or Slavek opinion too.
Comment 3 Darrell 2014-05-09 12:48:39 CDT 
Reverting sounds best.
Comment 4 Timothy Pearson 2014-05-10 03:17:15 CDT 
(In reply to Michele Calgaro from comment #2)
> Currently, the Kate syntax highlighting files are aligned as much as
> possible with the KDE ones. If the preference is to keep the old style, I
> can revert the part of the commit related to it.
> I agree with Tim that the old style was somehow better (or perhaps I was
> just used to it).
> Let's see Darrell or Slavek opinion too.

Sounds like a revert to me...glad to hear it. :-)  The new color scheme was driving me nuts!
Comment 5 Slávek Banko 2014-05-10 04:35:16 CDT 
Yes, the "bad things" we are not obliged to take into our code :)
I have no objection to revert it.
Comment 6 Michele Calgaro 2014-05-10 04:40:30 CDT 
Ok, we all agree about reverting the color scheme.
I will probably do it tomorrow.
Comment 7 Michele Calgaro 2014-05-10 07:14:42 CDT 
Code for alert.xml reverted in commit 0290dba.
I didn't do a full tdelibs rebuild, but I tested locally by copying the patched file to ~/.trinity/share/apps/katepart/syntax and it works fine.