Created attachment 2262 [details]
tdepim: fix FTBFS due to knewstuff.h

Created attachment 2263 [details]
tdenetwork: fix FTBFS due to renamed knewstuff

Created attachment 2264 [details]
tdebindings: fix FTBFS due to renamed knewstuff

Created attachment 2265 [details]
tdeaddons: fix FTBFS due to renamed knewstuff

Created attachment 2266 [details]
tdeutils: fix FTBFS due to renamed knewstuff

in tdewebdev, there is a copy of knewstuff library located under "lib/compatibility/knewstuff". I think it can be removed.

Created attachment 2268 [details]
tdeaddons: fix FTBFS due to renamed knewstuff (2)

Fix typo.

Created attachment 2271 [details]
koffice: fix FTBFS due to renamed knewstuff

Created attachment 2272 [details]
tellico: fix FTBFS due to renamed knewstuff

Created attachment 2273 [details]
tdeedu: fix FTBFS due to renamed knewstuff

Nice - because I did not have information about this bug, I have also developed some patches. So I'll put together my efforts with your patches. Thank you.

Note: Renaming is not done completely - for example action icon is still named knewstuff, while you assume in your patches already tdenewstuff. I believe that we should also rename these remaining files. What is your opinion.

Comment on attachment 2262 [details]
tdepim: fix FTBFS due to knewstuff.h

With small adjustment pushed to GIT in hash 4d969177.

Comment on attachment 2266 [details]
tdeutils: fix FTBFS due to renamed knewstuff

Equivalent patches pushed in GIT hash 9526b0bc and 80e661aa.

Comment on attachment 2271 [details]
koffice: fix FTBFS due to renamed knewstuff

Equivalent patch pushed in GIT hash 38518d61.

(In reply to Slávek Banko from comment #15)
> Comment on attachment 2271 [details]
> koffice: fix FTBFS due to renamed knewstuff
> 
> Equivalent patch pushed in GIT hash 38518d61.

Note: Kexi templates still does not works.

Comment on attachment 2263 [details]
tdenetwork: fix FTBFS due to renamed knewstuff

Equivalent patch pushed in GIT hash 6ed1cdba.

Note: Chat styles list is loaded, but installation fail.

(In reply to Slávek Banko from comment #17)
> Comment on attachment 2263 [details]
> tdenetwork: fix FTBFS due to renamed knewstuff
> 
> Equivalent patch pushed in GIT hash 6ed1cdba.
> 
> Note: Chat styles list is loaded, but installation fail.

Update: Installation fails with style Glossyk, which has incorrectly listed url address. Other styles work correctly.

tdewebdev fails to build.

The tdelibs knewstuff header directory was renamed to tdenewstuff, but the header files were not renamed k->tde:

knewstuff.h->tdenewstuff.h
knewstuffbutton.h->tdenewstuffbutton.h
knewstuffgeneric.h->tdenewstuffgeneric.h
knewstuffsecure.h->tdenewstuffsecure.h

Renaming the header files requires updating many packages but the four header files should be renamed to be consistent and to avoid confusion.

(In reply to Darrell from comment #19)
> tdewebdev fails to build.
> 
> The tdelibs knewstuff header directory was renamed to tdenewstuff, but the
> header files were not renamed k->tde:
> 
> knewstuff.h->tdenewstuff.h
> knewstuffbutton.h->tdenewstuffbutton.h
> knewstuffgeneric.h->tdenewstuffgeneric.h
> knewstuffsecure.h->tdenewstuffsecure.h
> 
> Renaming the header files requires updating many packages but the four
> header files should be renamed to be consistent and to avoid confusion.

Yes, that's exactly what I had in mind in the mail http://trinity-devel.pearsoncomputing.net/?0::13766 and comment 12. In addition to headers there is also icon for action with the name knewstuff:

cr16-action-knewstuff.png
cr32-action-knewstuff.png
cr64-action-knewstuff.png

A list of files named *knewstuff*:

tdeaccessibility/IconThemes/mono/scalable/actions/knewstuff.svgz

tdelibs/tdenewstuff/README.knewstuff
tdelibs/tdenewstuff/cr16-action-knewstuff.png
tdelibs/tdenewstuff/cr32-action-knewstuff.png
tdelibs/tdenewstuff/cr64-action-knewstuff.png
tdelibs/tdenewstuff/knewstuff.cpp
tdelibs/tdenewstuff/knewstuff.h
tdelibs/tdenewstuff/knewstuffbutton.cpp
tdelibs/tdenewstuff/knewstuffbutton.h
tdelibs/tdenewstuff/knewstuffgeneric.cpp
tdelibs/tdenewstuff/knewstuffgeneric.h
tdelibs/tdenewstuff/knewstuffsecure.cpp
tdelibs/tdenewstuff/knewstuffsecure.h

tdeutils/superkaramba/src/sknewstuff.cpp
tdeutils/superkaramba/src/sknewstuff.h

tdewebdev/lib/compatibility/knewstuff
tdewebdev/lib/compatibility/knewstuff/cr16-action-knewstuff.png
tdewebdev/lib/compatibility/knewstuff/cr32-action-knewstuff.png
tdewebdev/lib/compatibility/knewstuff/cr64-action-knewstuff.png
tdewebdev/lib/compatibility/knewstuff/knewstuff.cpp
tdewebdev/lib/compatibility/knewstuff/knewstuff.h
tdewebdev/lib/compatibility/knewstuff/knewstuffgeneric.cpp
tdewebdev/lib/compatibility/knewstuff/knewstuffgeneric.h
tdewebdev/lib/compatibility/knewstuff/knewstuffsecure.cpp
tdewebdev/lib/compatibility/knewstuff/knewstuffsecure.h

(In reply to Darrell from comment #21)
> A list of files named *knewstuff*:
> 
> tdeaccessibility/IconThemes/mono/scalable/actions/knewstuff.svgz
> 
> tdelibs/tdenewstuff/README.knewstuff
> tdelibs/tdenewstuff/cr16-action-knewstuff.png
> tdelibs/tdenewstuff/cr32-action-knewstuff.png
> tdelibs/tdenewstuff/cr64-action-knewstuff.png
> tdelibs/tdenewstuff/knewstuff.cpp
> tdelibs/tdenewstuff/knewstuff.h
> tdelibs/tdenewstuff/knewstuffbutton.cpp
> tdelibs/tdenewstuff/knewstuffbutton.h
> tdelibs/tdenewstuff/knewstuffgeneric.cpp
> tdelibs/tdenewstuff/knewstuffgeneric.h
> tdelibs/tdenewstuff/knewstuffsecure.cpp
> tdelibs/tdenewstuff/knewstuffsecure.h
> 

The above are suitable for renaming.

> tdeutils/superkaramba/src/sknewstuff.cpp
> tdeutils/superkaramba/src/sknewstuff.h
> 

These are fine - 'sk' as a superkaramba and 'newstuff' is ok.

> tdewebdev/lib/compatibility/knewstuff
> tdewebdev/lib/compatibility/knewstuff/cr16-action-knewstuff.png
> tdewebdev/lib/compatibility/knewstuff/cr32-action-knewstuff.png
> tdewebdev/lib/compatibility/knewstuff/cr64-action-knewstuff.png
> tdewebdev/lib/compatibility/knewstuff/knewstuff.cpp
> tdewebdev/lib/compatibility/knewstuff/knewstuff.h
> tdewebdev/lib/compatibility/knewstuff/knewstuffgeneric.cpp
> tdewebdev/lib/compatibility/knewstuff/knewstuffgeneric.h
> tdewebdev/lib/compatibility/knewstuff/knewstuffsecure.cpp
> tdewebdev/lib/compatibility/knewstuff/knewstuffsecure.h

These are suitable for deletion.

Several automake files should be updated:

As Is:
AC_SUBST(LIB_KNEWSTUFF, "-lknewstuff")
Change to:
AC_SUBST(LIB_TDENEWSTUFF, "-ltdenewstuff")

Recommendation:

1) Push patches attached to this bug report.
2) Rename tdeaccessibility/tdelibs files (comment 22).
3) Delete tdewebdev duplicate files.
4) Update common automake files.
5) Allow common automake files to replicate overnight.
6) Patch/commit remaining affected sources.

(In reply to Darrell from comment #24)
> Recommendation:
> 
> 1) Push patches attached to this bug report.
> 2) Rename tdeaccessibility/tdelibs files (comment 22).
> 3) Delete tdewebdev duplicate files.
> 4) Update common automake files.
> 5) Allow common automake files to replicate overnight.
> 6) Patch/commit remaining affected sources.

I gradually processing patches, because outside FTBFS solutions still need to change the provider name and category. For example, for a patch for Tellico will still need some further adjustments, except these.

Note: Common automake files have been already changed. Remaining renaming in automake is specific for modules.

>I gradually processing patches
Okay. I'll wait for the changes.

Created attachment 2275 [details]
tdewebdev: fix FTBFS due to renamed knewstuff and delete duplicate knewstuff files

The patch resolves the build failure for me on Slackware 14.1 and deletes the duplicate knewstuff files.

Comment on attachment 2264 [details]
tdebindings: fix FTBFS due to renamed knewstuff

Sorry Francois, I just find out your patch now. I have pushed an identical patch in commit c9f587d. When you have patches like this one, feel free to push them directly to GIT instead of opening a bug report.

Comment on attachment 2268 [details]
tdeaddons: fix FTBFS due to renamed knewstuff (2)

As above, identical patch pushed in commit fd63c2d.

Michelle, I assume that you did not address a change of provider and category, as I mentioned above?

>Michelle, I assume that you did not address a change of provider and category, >as I mentioned above?
Not yet, I just did a simple rename at first, resulting in the same patches that Francois had already proposed.

tdebindings now builds properly but require some more changes since tdelibs is still not detected at configure time.

checking whether to use the tdenewstuff lib from tdelibs... no

tdeaddons is waiting to be build during the night, since now is bed time for me ;-)

Slavek,
unless I missed something, tdebindings and tdeaddons do not have any provider to be updated.

>unless I missed something, tdebindings and tdeaddons do not have any provider 
>to be updated.
As further note, I searched for "khownewstuff" which is usually in the provider url and didn't find any.

(In reply to Michele Calgaro from comment #33)
> >unless I missed something, tdebindings and tdeaddons do not have any provider 
> >to be updated.
> As further note, I searched for "khownewstuff" which is usually in the
> provider url and didn't find any.

Yes, also I looked. 

In tdebindings are only defined interfaces for bindings == not has its own providers and categories == not need further changes.

In tdeaddons is in kate / filetemplates / plugin category "katefiletemplates/template" - leaving the default provider. However, there is no such category in opendesktop.org or in the original kde-look.org == does not work also in 3.5.13.x == is not currently a way to fix it.

Comment on attachment 2275 [details]
tdewebdev: fix FTBFS due to renamed knewstuff and delete duplicate knewstuff files

With the change of provider and categories pushed to GIT in hash 76c59a33.

Comment on attachment 2273 [details]
tdeedu: fix FTBFS due to renamed knewstuff

With the change of provider and categories pushed to GIT in hash 9a79f045.

Comment on attachment 2272 [details]
tellico: fix FTBFS due to renamed knewstuff

Equivalent patch pushed in GIT hash e4b4d01f.

I leave this bug report open, because although were resolved FTBFS and changed provider and categories, in many cases, the content is not loaded.

What categories are not loading?

I am aware of a problem with SuperKaramba.  Unfortunately OpenDesktop.org is buggy; I sent them a message asking them to fix the SuperKaramba category (which is completely missing from the OCS data source!) but never received a reply.

We may need to look into being our own OCS provider.  Unfortunately I cannot do that from the main TDE servers as they are located in the USA, and the DMCA and similar laws essentially makes allowing uncontrolled user-generated content untenable, even if we only provide links to said content.  As the saying goes it only takes one rotten apple...and I have seen some clearly pirated stuff on KDE-look.org uploaded by random users when I was browsing years back.

If someone in a less restricted country would like to put up an OCS data source on their servers we should be able to at least work around the SuperKaramba problem.  Ideally we should have an alternative to OpenDesktop.org for all non-wallpaper stuff, e.g. Kicker applets, SuperKaramba widgets, etc.; it doesn't need to be fancy but I don't know how much longer OpenDesktop.org is going to keep support for our old KDE 3.x stuff.  The fact that they are unresponsive is most discouraging.

In light of all this should this report block R14?  Wallpapers work, as stated above I need a list of the stuff that doesn't to see if it's our problem or theirs. :-)

Thanks!

Tim

I observed the following situations:

1) Appropriate category is not available. For example, Karamba, Kate File Template. For such probably we cannot do much of anything. Is kde-look.org available with the same OCS API? Karamba is available on kde-look.org:
http://kde-look.org/index.php?xcontentmode=38

2) Link on OpenDesktop.org contains redirect outside OpenDesktop.org. In the test I chose wallpaper Mountain Village and Kopete style Glossyk. For both page for download content contains redirect outside OpenDesktop.org. In the case of wallpaper refers to non-existent content. As the downloaded content was saved php file == downloaded file type is not checked. In case Glossyk refers to the correct file. I suppose that is downloaded php file and therefore installation fails. However, in both cases, the content is marked as installed - is stated in the rc file.

3) TDENewStuff class was initialized only using constructor - even with the correct category. I observed that if the content is downloaded via the call load("category",...) is displayed correctly. But if is TDENewStuff initialized only using a constructor, it is not displaying any content.

4) Tellico. It uses its own dialog to display the content.

(In reply to Slávek Banko from comment #40)
> I observed the following situations:
> 
> 1) Appropriate category is not available. For example, Karamba, Kate File
> Template. For such probably we cannot do much of anything. Is kde-look.org
> available with the same OCS API? Karamba is available on kde-look.org:
> http://kde-look.org/index.php?xcontentmode=38

kde-look.org, OpenDesktop.org, gnome-look.org, and all other sister sites use the exact same content database--all content is available from any of these sites.  As mentioned in Comment 39 there is a bug in the OCS provider that makes Karamba files unavailable via OCS; the "webmaster" of OpenDesktop.org is unresponsive and therefore I assume this will not be fixed.

> 2) Link on OpenDesktop.org contains redirect outside OpenDesktop.org. In the
> test I chose wallpaper Mountain Village and Kopete style Glossyk. For both
> page for download content contains redirect outside OpenDesktop.org. In the
> case of wallpaper refers to non-existent content. As the downloaded content
> was saved php file == downloaded file type is not checked. In case Glossyk
> refers to the correct file. I suppose that is downloaded php file and
> therefore installation fails. However, in both cases, the content is marked
> as installed - is stated in the rc file.

This is an old bug, existing long before the OCS conversion.  It was probably introduced as kde-look.org and authors started monetizing their "free" work with advertisements; the only thing we can really do is try to detect file type via mime magic and pop up a "Content Not Installable" box if the file is not an image.  Enough of that and maybe authors will get the hint when users aren't able to install their work and start complaining.  Then again, given that OpenDesktop.org appears to be dying maybe not. :-)

> 3) TDENewStuff class was initialized only using constructor - even with the
> correct category. I observed that if the content is downloaded via the call
> load("category",...) is displayed correctly. But if is TDENewStuff
> initialized only using a constructor, it is not displaying any content.

I'll need to look into this.

> 4) Tellico. It uses its own dialog to display the content.

So it doesn't use TDENewStuff at all?

If I understand correctly, the only missing categories then are:
Karamaba
Kate File Template

Is this correct?

Thanks!

Tim

(In reply to Timothy Pearson from comment #41)
> (In reply to Slávek Banko from comment #40)
> > 4) Tellico. It uses its own dialog to display the content.
> 
> So it doesn't use TDENewStuff at all?
> 

Tellico uses TDENewStuff to get content, but for its own dialog to display. See:
http://git.trinitydesktop.org/cgit/tellico/commit/src/newstuff/dialog.cpp?id=e4b4d01f

> If I understand correctly, the only missing categories then are:
> Karamaba
> Kate File Template
> 
> Is this correct?
> 

I'll check the recent patches for related to TDENewStuff to remind myself, if there was still any other category...

> Thanks!
> 
> Tim

(In reply to Slávek Banko from comment #40)
> 3) TDENewStuff class was initialized only using constructor - even with the
> correct category. I observed that if the content is downloaded via the call
> load("category",...) is displayed correctly. But if is TDENewStuff
> initialized only using a constructor, it is not displaying any content.

Which application(s) do this?  I just need one example to analyze the codepaths.

Also, I just sent one more message to what I believe is the parent corporation controlling OpenDesktop.org (h i v e 01); if I do not receive a response then we have to consider OpenDesktop.org essentially brain dead such that the entire site could disappear at any time.  Most users and authors are blissfully unaware of this, so the site looks OK, but only for so long as it doesn't suffer a fatal problem as (from what I can tell at this time) no one is actively monitoring or maintaining it.

Thanks!

Tim

(In reply to Timothy Pearson from comment #43)
> (In reply to Slávek Banko from comment #40)
> > 3) TDENewStuff class was initialized only using constructor - even with the
> > correct category. I observed that if the content is downloaded via the call
> > load("category",...) is displayed correctly. But if is TDENewStuff
> > initialized only using a constructor, it is not displaying any content.
> 
> Which application(s) do this?  I just need one example to analyze the
> codepaths.
> 

For example, in KOffice - getting new script works, but getting templates for kexi does not work. Getting new content in all tdeedu applications does not work. Getting new content in Quanta from tdewebdev does not work.

Looks like I didn't convert the base TDENewStuff Engine class to the OCS provider format as I didn't realize TDENewStuff had duplicated the engine code.

Fixed in GIT hash 72a2afc (tdelibs).

This should fix everything except the outstanding OCS provider issues that we have no control over.  I will look into adding mime detection to the wallpaper grabber, but after that (provided this patch repairs the majority of the broken applications) I think this bug should be removed from the R14 block list.

(In reply to Timothy Pearson from comment #45)
> Looks like I didn't convert the base TDENewStuff Engine class to the OCS
> provider format as I didn't realize TDENewStuff had duplicated the engine
> code.
> 
> Fixed in GIT hash 72a2afc (tdelibs).
> 
> This should fix everything except the outstanding OCS provider issues that
> we have no control over.  I will look into adding mime detection to the
> wallpaper grabber, but after that (provided this patch repairs the majority
> of the broken applications) I think this bug should be removed from the R14
> block list.

Downloaded mimetype is now checked for wallpapers as of GIT hash 30c2b7e (tdelibs).  If the downloaded file is not an image then it is removed and installation fails.  Unfortunately it seems OpenDesktop.org has just become a dumping ground for external links these days, so most of the high-rated wallpapers just fail at this point.  If you want to test with ones that work, try Wilkolak or Green Snake HD.

I don't think the remaining issues with the OCS data source should block R14.  Do you concur?

I have not tested Tellico to see if it works now; can you check?

Thanks!

Tellico reimplemented parts of the ProviderLoader class just to get access to progress info; I'm working on adding that ability to the base ProviderLoader class and fixing up tellico.

Additionally, there is an issue I just noticed where downloading one wallpaper works fine, but downloading the second somehow downloads the original wallpaper again under the same name.  I'm working on that as well.

(In reply to Timothy Pearson from comment #47)
> Tellico reimplemented parts of the ProviderLoader class just to get access
> to progress info; I'm working on adding that ability to the base
> ProviderLoader class and fixing up tellico.
> 
> Additionally, there is an issue I just noticed where downloading one
> wallpaper works fine, but downloading the second somehow downloads the
> original wallpaper again under the same name.  I'm working on that as well.

These issues should be fixed in GIT hashes a71fa09 (tdelibs) and 1c137da (tellico).

Bear in mind that Tellico's GHNS was already somewhat broken before the OCS conversion; while I was able to repair template installation the source script installation is still broken.  The latter may be due to a lack of appropriate content on OpenDesktop.org; in any case this bug should no longer block R14.

Created attachment 2330 [details]
Update r14-xdg-update: add update of tdenewstuff sections

For information, this patch I have in my queue for pushing into tdebase.

Comment on attachment 2330 [details]
Update r14-xdg-update: add update of tdenewstuff sections

Pushed to GIT in hash d7ccc160.