By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 2152 - Add lcms2 support
Summary: Add lcms2 support
Status: NEW
Alias: None
Product: TDE
Classification: Unclassified
Component: system (show other bugs)
Version: R14.0.x [Trinity]
Hardware: All Linux
: P5 major
Assignee: Timothy Pearson
URL:
Depends on:
Blocks:
 
Reported: 2014-10-10 11:09 CDT by Slávek Banko
Modified: 2018-05-27 10:48 CDT (History)
4 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Slávek Banko 2014-10-10 11:09:30 CDT 
I noticed that LCMS1 disappearing from the distributions, and we need to add support for LCMS2. Affected packages (at first glance) are: 

+ tdegraphics - done in commit b34c4d8c
+ libkdcraw - done in commit 87d533f7
+ digikam 
+ koffice
Comment 1 Timothy Pearson 2014-10-14 11:59:27 CDT 
Slavek, are you working on this report?

Thanks!
Comment 2 Slávek Banko 2014-10-14 12:04:00 CDT 
(In reply to Timothy Pearson from comment #1)
> Slavek, are you working on this report?
> 
> Thanks!

At this time not.
I am currently focused on bug 2110.
Comment 3 Timothy Pearson 2014-10-16 13:32:37 CDT 
Looks like Digikam is going to require a lot of work; lcms2 is not 1:1 feature compatible:
http://littlecms2.blogspot.com/2009/11/backwards-compatibility.html

Anyone up to the challenge?
Comment 4 Timothy Pearson 2014-10-16 13:39:10 CDT 
(In reply to Timothy Pearson from comment #3)
> Looks like Digikam is going to require a lot of work; lcms2 is not 1:1
> feature compatible:
> http://littlecms2.blogspot.com/2009/11/backwards-compatibility.html
> 
> Anyone up to the challenge?

OK, after digging a bit more it seems that Digikam uses lprof, which in turn uses lcms1.  lprof is not maintained since 2008 and KDE's Digikam simply dropped it and the features it relied on entirely:
http://marc.info/?l=kde-commits&m=132813939610177&w=2

Not sure if that's an acceptable solution; personally I'd be more inclined to move lprof to a 3rdparty folder and add a copy of liblcms1 to the 3rdparty folder; this would at least buy us a bit more time to figure out how best to re-implement the broken features.
Comment 5 Slávek Banko 2014-10-16 13:52:45 CDT 
(In reply to Timothy Pearson from comment #4)
> (In reply to Timothy Pearson from comment #3)
> > Looks like Digikam is going to require a lot of work; lcms2 is not 1:1
> > feature compatible:
> > http://littlecms2.blogspot.com/2009/11/backwards-compatibility.html
> > 
> > Anyone up to the challenge?
> 
> OK, after digging a bit more it seems that Digikam uses lprof, which in turn
> uses lcms1.  lprof is not maintained since 2008 and KDE's Digikam simply
> dropped it and the features it relied on entirely:
> http://marc.info/?l=kde-commits&m=132813939610177&w=2
> 
> Not sure if that's an acceptable solution; personally I'd be more inclined
> to move lprof to a 3rdparty folder and add a copy of liblcms1 to the
> 3rdparty folder; this would at least buy us a bit more time to figure out
> how best to re-implement the broken features.

I was looking for information in digikam git:

http://quickgit.kde.org/?p=digikam.git&a=search&h=HEAD&st=commit&s=lcms2

However, so far I have not looked at the complexity of individual patches.
Comment 6 Slávek Banko 2014-10-16 13:58:51 CDT 
Challenging seems to be also adjustments in KOffice:

http://quickgit.kde.org/?p=calligra.git&a=search&h=HEAD&st=commit&s=lcms2
Comment 7 Timothy Pearson 2014-10-16 14:20:33 CDT 
So basically it looks like there is a lot of backporting to do.

After you are done with Bug 2110 do you want to start working on this?  I probably won't be able to, at least not in time for R14; I've been working on TDE pretty much non-stop for a month now and need to tend to other duties soon. :-)

Thanks!
Comment 8 Slávek Banko 2014-10-16 14:45:31 CDT 
(In reply to Timothy Pearson from comment #7)
> So basically it looks like there is a lot of backporting to do.
> 
> After you are done with Bug 2110 do you want to start working on this?  I
> probably won't be able to, at least not in time for R14; I've been working
> on TDE pretty much non-stop for a month now and need to tend to other duties
> soon. :-)
> 
> Thanks!

For patches from bug 2110 I now waiting for confirmation from François. Besides, I have to prepare a patch for the r14-xdg-update to add processing KNewStuff => TDENewStuff in existing user profile. It is also important / necessary, and I expect that it will be relatively easy. Then I will be able to delve into the processing digikam and chalk patches.
Comment 9 Timothy Pearson 2014-10-16 14:50:28 CDT 
(In reply to Slávek Banko from comment #8)
> (In reply to Timothy Pearson from comment #7)
> > So basically it looks like there is a lot of backporting to do.
> > 
> > After you are done with Bug 2110 do you want to start working on this?  I
> > probably won't be able to, at least not in time for R14; I've been working
> > on TDE pretty much non-stop for a month now and need to tend to other duties
> > soon. :-)
> > 
> > Thanks!
> 
> For patches from bug 2110 I now waiting for confirmation from François.
> Besides, I have to prepare a patch for the r14-xdg-update to add processing
> KNewStuff => TDENewStuff in existing user profile. It is also important /
> necessary, and I expect that it will be relatively easy. Then I will be able
> to delve into the processing digikam and chalk patches.

OK, sounds great!  I'll be poking at Bug 1850 as I have time.
Comment 10 Michele Calgaro 2014-10-22 22:16:24 CDT 
As additional info, digikam and koffice FTBFS in Jessie due to this problem.
Comment 11 Timothy Pearson 2014-10-22 22:37:10 CDT 
(In reply to Michele Calgaro from comment #10)
> As additional info, digikam and koffice FTBFS in Jessie due to this problem.

Slavek, what is the status of this?

Thanks!

Tim
Comment 12 Slávek Banko 2014-10-23 02:13:30 CDT 
(In reply to Timothy Pearson from comment #11)
> (In reply to Michele Calgaro from comment #10)
> > As additional info, digikam and koffice FTBFS in Jessie due to this problem.
> 
> Slavek, what is the status of this?
> 
> Thanks!
> 
> Tim

I started to work on KOffice.
Comment 13 Timothy Pearson 2014-11-03 09:59:31 CST 
(In reply to Slávek Banko from comment #12)
> (In reply to Timothy Pearson from comment #11)
> > (In reply to Michele Calgaro from comment #10)
> > > As additional info, digikam and koffice FTBFS in Jessie due to this problem.
> > 
> > Slavek, what is the status of this?
> > 
> > Thanks!
> > 
> > Tim
> 
> I started to work on KOffice.

How is the fix progressing?  If it ends up being too complex to finish before R14 release we'll need to bundle lcms1 with R14.

Thanks!
Comment 15 Slávek Banko 2014-11-12 15:53:44 CST 
Ok, I think I know where the problem is. Library libkdcraw already uses lcms2 support and therefore kipi-plugins and digikam tries to link lcms2.

Fixed in GIT hash f8131d40 (tde-packaging - package libkdcraw).
Comment 16 Timothy Pearson 2014-11-13 08:59:18 CST 
(In reply to Slávek Banko from comment #15)
> Ok, I think I know where the problem is. Library libkdcraw already uses
> lcms2 support and therefore kipi-plugins and digikam tries to link lcms2.
> 
> Fixed in GIT hash f8131d40 (tde-packaging - package libkdcraw).

Unfortunately this doesn't look fixed:
https://librarian.quickbuild.pearsoncomputing.net/6590834/buildlog_ubuntu-saucy-amd64.digikam-trinity_4%3A14.0.0-r221-0ubuntu13.10.0%2Bpr29_FAILEDTOBUILD.txt.gz
Comment 17 Slávek Banko 2014-11-13 14:02:37 CST 
(In reply to Timothy Pearson from comment #16)
> (In reply to Slávek Banko from comment #15)
> > Ok, I think I know where the problem is. Library libkdcraw already uses
> > lcms2 support and therefore kipi-plugins and digikam tries to link lcms2.
> > 
> > Fixed in GIT hash f8131d40 (tde-packaging - package libkdcraw).
> 
> Unfortunately this doesn't look fixed:
> https://librarian.quickbuild.pearsoncomputing.net/6590834/buildlog_ubuntu-
> saucy-amd64.digikam-trinity_4%3A14.0.0-r221-0ubuntu13.10.
> 0%2Bpr29_FAILEDTOBUILD.txt.gz

Variable dependency apparently was not enough. Therefore I added strict dependency on liblcms*-dev, which were used for building libkdcraw.

I hope that has really been fixed by commit c5c42041.
Comment 18 Timothy Pearson 2014-11-13 19:56:08 CST 
(In reply to Slávek Banko from comment #17)
> (In reply to Timothy Pearson from comment #16)
> > (In reply to Slávek Banko from comment #15)
> > > Ok, I think I know where the problem is. Library libkdcraw already uses
> > > lcms2 support and therefore kipi-plugins and digikam tries to link lcms2.
> > > 
> > > Fixed in GIT hash f8131d40 (tde-packaging - package libkdcraw).
> > 
> > Unfortunately this doesn't look fixed:
> > https://librarian.quickbuild.pearsoncomputing.net/6590834/buildlog_ubuntu-
> > saucy-amd64.digikam-trinity_4%3A14.0.0-r221-0ubuntu13.10.
> > 0%2Bpr29_FAILEDTOBUILD.txt.gz
> 
> Variable dependency apparently was not enough. Therefore I added strict
> dependency on liblcms*-dev, which were used for building libkdcraw.
> 
> I hope that has really been fixed by commit c5c42041.

Closer; now only Wheezy is failing:
https://librarian.quickbuild.pearsoncomputing.net/6591513/buildlog_ubuntu-wheezy-amd64.digikam-trinity_4%3A14.0.0-r221-0debian7.0.0%2Bpr27_FAILEDTOBUILD.txt.gz
Comment 19 Timothy Pearson 2014-11-17 10:13:40 CST 
(In reply to Timothy Pearson from comment #18)
> (In reply to Slávek Banko from comment #17)
> > (In reply to Timothy Pearson from comment #16)
> > > (In reply to Slávek Banko from comment #15)
> > > > Ok, I think I know where the problem is. Library libkdcraw already uses
> > > > lcms2 support and therefore kipi-plugins and digikam tries to link lcms2.
> > > > 
> > > > Fixed in GIT hash f8131d40 (tde-packaging - package libkdcraw).
> > > 
> > > Unfortunately this doesn't look fixed:
> > > https://librarian.quickbuild.pearsoncomputing.net/6590834/buildlog_ubuntu-
> > > saucy-amd64.digikam-trinity_4%3A14.0.0-r221-0ubuntu13.10.
> > > 0%2Bpr29_FAILEDTOBUILD.txt.gz
> > 
> > Variable dependency apparently was not enough. Therefore I added strict
> > dependency on liblcms*-dev, which were used for building libkdcraw.
> > 
> > I hope that has really been fixed by commit c5c42041.
> 
> Closer; now only Wheezy is failing:
> https://librarian.quickbuild.pearsoncomputing.net/6591513/buildlog_ubuntu-
> wheezy-amd64.digikam-trinity_4%3A14.0.0-r221-0debian7.0.
> 0%2Bpr27_FAILEDTOBUILD.txt.gz

Looks fixed--thanks!
Comment 20 Timothy Pearson 2014-11-18 11:02:54 CST 
What is the status of this report?  As R14 RC1 is almost fully uploaded we will be opening the merge window for RC2 in the next day or so.

Thanks!
Comment 21 Slávek Banko 2014-11-19 15:59:03 CST 
(In reply to Timothy Pearson from comment #19)
> (In reply to Timothy Pearson from comment #18)
> > (In reply to Slávek Banko from comment #17)
> > > (In reply to Timothy Pearson from comment #16)
> > > > (In reply to Slávek Banko from comment #15)
> > > > > Ok, I think I know where the problem is. Library libkdcraw already uses
> > > > > lcms2 support and therefore kipi-plugins and digikam tries to link lcms2.
> > > > > 
> > > > > Fixed in GIT hash f8131d40 (tde-packaging - package libkdcraw).
> > > > 
> > > > Unfortunately this doesn't look fixed:
> > > > https://librarian.quickbuild.pearsoncomputing.net/6590834/buildlog_ubuntu-
> > > > saucy-amd64.digikam-trinity_4%3A14.0.0-r221-0ubuntu13.10.
> > > > 0%2Bpr29_FAILEDTOBUILD.txt.gz
> > > 
> > > Variable dependency apparently was not enough. Therefore I added strict
> > > dependency on liblcms*-dev, which were used for building libkdcraw.
> > > 
> > > I hope that has really been fixed by commit c5c42041.
> > 
> > Closer; now only Wheezy is failing:
> > https://librarian.quickbuild.pearsoncomputing.net/6591513/buildlog_ubuntu-
> > wheezy-amd64.digikam-trinity_4%3A14.0.0-r221-0debian7.0.
> > 0%2Bpr27_FAILEDTOBUILD.txt.gz
> 
> Looks fixed--thanks!

Oh, yes, I did not get to write that problem with multiarch on Wheezy was treated in commit b9049d0f (tde-packaging).
Comment 22 Slávek Banko 2014-11-19 16:02:05 CST 
(In reply to Timothy Pearson from comment #20)
> What is the status of this report?  As R14 RC1 is almost fully uploaded we
> will be opening the merge window for RC2 in the next day or so.
> 
> Thanks!

The last few days I unfortunately did not have enough time to could move with this forward. I hope that maybe this weekend I'll find some time.
Comment 23 Slávek Banko 2014-11-27 09:32:04 CST 
(In reply to Slávek Banko from comment #22)
> (In reply to Timothy Pearson from comment #20)
> > What is the status of this report?  As R14 RC1 is almost fully uploaded we
> > will be opening the merge window for RC2 in the next day or so.
> > 
> > Thanks!
> 
> The last few days I unfortunately did not have enough time to could move
> with this forward. I hope that maybe this weekend I'll find some time.

For information: last weekend I was intensely work on patch for KOffice, but as I suspected, it is a challenging task and completion it will still take some time.

Because solving is currently required only for Debian Jessie, this bug can be considered non-blocking for R14.0.0.
Comment 24 Timothy Pearson 2014-11-27 12:47:38 CST 
That is what I expected.  Thank you for trying at least; the work will still need to be done for our next point release.

I will probably work around the Jessie issue by building old libcms in the deps repo.
Comment 25 Timothy Pearson 2014-11-28 01:17:29 CST 
(In reply to Timothy Pearson from comment #24)
> That is what I expected.  Thank you for trying at least; the work will still
> need to be done for our next point release.
> 
> I will probably work around the Jessie issue by building old libcms in the
> deps repo.

lcms v1 is now in Jessie R14 build deps archive; removing from R14 block list.