By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 2218 - Repeated Twin crashes
Summary: Repeated Twin crashes
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: tdebase (show other bugs)
Version: R14.0.0 [Trinity]
Hardware: Other Linux
: P1 blocker
Assignee: Timothy Pearson
URL:
Depends on:
Blocks: 2014
  Show dependency tree / graph
 
Reported: 2014-11-27 23:15 CST by Michele Calgaro
Modified: 2014-11-28 02:59 CST (History)
3 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
sample crash dump (35.57 KB, text/plain)
2014-11-27 23:15 CST, Michele Calgaro 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michele Calgaro 2014-11-27 23:15:04 CST 
Created attachment 2364 [details]
sample crash dump

Last night I did a system rebuild in line with RC2 source code (all except the applications).
From this morning I have been experiencing several repeated twin crashes.
One way to reproduced the problem systematically seems to be the following:
1) open Amarok (or VLC). Make sure the GUI window is visible.
2) click on the systray icon to minimize the window to icon
3) crash handler appear.
After the crash is not possible to type anything in the open windows, but mouse remains active and Fn keys as well (i.e. the keyboard is active but the input is not passed to the windows on the screen).
Attached is a crash dump.

The problem happens while also doing other things (for example from CodeBlocks running a console program) or switching to Firefox. The example above (with Amarok/VLC) happens just after login. The other already open windows are a Konsole and Konqueror (restored from the previous section).

The system was stable until yesterday, when it was running RC1 (again, everything expect applications) from 6 days ago.
Comment 1 Timothy Pearson 2014-11-27 23:28:27 CST 
Well that's nasty.  I'll try to fix it tonight and force it into RC2.
Comment 2 Timothy Pearson 2014-11-27 23:40:57 CST 
Thus far I can't replicate the crash.  In addition the backtrace appears to be slightly corrupt; it's referencing KWinInternal::Workspace::startKompmgr() at activation.cpp:329 when that line is actually part of Workspace::takeActivity().

That being said, can you see if reversing this commit resolves the crashes?
https://git.trinitydesktop.org/cgit/tdebase/commit/?id=84d7db019508c1185f513e864483fd1fd608c05c

If it does I'll just reverse the patch and ship R14 with Bug 2189 open instead of crashing twin.

I would like to know why this is affecting your system and not mine though.  I'm also concerned about the crash dump corruption; it almost seems like you might have mismatched libraries existing on your system.
Comment 3 Michele Calgaro 2014-11-27 23:48:35 CST 
It was a full rebuild were all packages were built with pbuilder in a clean environment (Debian/Jessie). Then updated using aptitude and except for the tdepim issue, everything went well as usual. Mismatched libraries on applications may exists since I haven't rebuild the applications folder, but the crash also happens also using non-TDE applications (firefox, VLC, Code Blocks) and given that twin is in tdebase I suspect something is actually wrong.

I will try to revert the patch later today and let you know (now I am on Windows).
Tonight I can run a new rebuild (without applications) and over the weekend I can do a full TDE rebuild as well.

For info. today in less than 2 hours or usage, I got this crash more than 10 times and the longest run without a crash was about 15 minutes.
Comment 4 Michele Calgaro 2014-11-27 23:50:19 CST 
Forgot to mention the built was from the latest GIT sources.
Comment 5 Timothy Pearson 2014-11-27 23:54:09 CST 
(In reply to Michele Calgaro from comment #3)
> For info. today in less than 2 hours or usage, I got this crash more than 10
> times and the longest run without a crash was about 15 minutes.

Let me know if *only* reversing the patch fixes the issue; i.e. please don't do a full rebuild or anything other than rebuilding and reinstalling twin before testing.  I can't think of much else that could be causing crashes at this point; even that patch was pretty trivial and I don't see how it could be crashing twin.

At least you are getting the crashes reliably so if needed we can bisect the twin code between RC1 and RC2.

Thanks!
Comment 6 Michele Calgaro 2014-11-28 02:26:48 CST 
>That being said, can you see if reversing this commit resolves the crashes?
>https://git.trinitydesktop.org/cgit/tdebase/commit
>/?id=84d7db019508c1185f513e864483fd1fd608c05c
The bug is definitely caused by this patch, and more specifically by the line
get_focus->setActive( true, true );
added in activation.cpp (line 449 after the patch).
Removing that line is sufficient to prevent crashes.

If that line is not strictly required for bug 2189, then it is an easy fix (I can already push a patch for it).
Comment 7 Timothy Pearson 2014-11-28 02:29:14 CST 
(In reply to Michele Calgaro from comment #6)
> >That being said, can you see if reversing this commit resolves the crashes?
> >https://git.trinitydesktop.org/cgit/tdebase/commit
> >/?id=84d7db019508c1185f513e864483fd1fd608c05c
> The bug is definitely caused by this patch, and more specifically by the line
> get_focus->setActive( true, true );
> added in activation.cpp (line 449 after the patch).
> Removing that line is sufficient to prevent crashes.
> 
> If that line is not strictly required for bug 2189, then it is an easy fix
> (I can already push a patch for it).

OK, reverting that does reopen Bug 2189 but I guess it's better than crashing twin.  Go ahead and revert the commit, but also reopen Bug 2189 and reference this bug report please.

Thanks!
Comment 8 Michele Calgaro 2014-11-28 02:34:11 CST 
I did not revert the whole commit. Just removed the mentioned line.
Comment 9 Michele Calgaro 2014-11-28 02:35:22 CST 
And actually bug 2189 was already re-opened
Comment 10 Timothy Pearson 2014-11-28 02:59:17 CST 
OK, thanks.  I put a note on the other report so that we can keep this straight.