By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 2261 - gnome-icon-theme icons do not appear correctly
Summary: gnome-icon-theme icons do not appear correctly
Status: NEW
Alias: None
Product: TDE
Classification: Unclassified
Component: tdebase (show other bugs)
Version: R14.0.x [Trinity]
Hardware: Other Linux
: P5 major
Assignee: Timothy Pearson
URL:
Depends on: 1313
Blocks:
  Show dependency tree / graph
 
Reported: 2014-12-15 16:25 CST by Darrell
Modified: 2018-05-27 10:50 CDT (History)
3 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
Screenshot of system tray icons with gnome-icon-theme icons (7.84 KB, image/png)
2014-12-15 22:09 CST, Darrell 		Details
Screenshot of desktop device icons before suggested changes (12.33 KB, image/png)
2014-12-15 22:13 CST, Darrell 		Details
Screenshot of desktop device icons after suggested changes (12.37 KB, image/png)
2014-12-15 22:14 CST, Darrell 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darrell 2014-12-15 16:25:54 CST 
I am filing this bug report separately rather than as part of bug 1313.

Slackware 14.1 with the gnome-icon-theme package installed. I cannot test on other distros because the R14 packages are not yet available.

After restarting the desktop and flushing the icon cache, most icons in the system tray do not appear correctly, instead displaying the default 'Empty' icon, which I believe was renamed recently to application-vnd.tde.misc.

The problem might be specific to the system tray. Most icons appeared normally in the menu.

In the system tray the kmix icon appears as expected, but probably is defaulting to the crystalsvg icon rather than using a respective gnome-icon-theme icon.

Examples of incorrect icons include:

klipper
kwikdisk
kteatime
akregator

I have not done any digging into the cause. I know nothing about the recent icon renaming to support xdg and thus, don't know where to start investigating.

This bug might be related to bug 1313 or bug 1046.
Comment 1 Darrell 2014-12-15 20:59:55 CST 
With a fresh profile, the following icons did not appear correctly:

Desktop
-------
My Documents
Web Browser
Unmounted NFS share
Mounted removable medium

System Tray
-----------
krandr
tdenetworkmanager
tdepowersave
klipper
kalarm
akregator
kget
kmix, kmail, and korganizer icons are correct but are the crystalsvg defaults.

I expect icon sets like gnome-icon-theme not to have any respective app icons, but I also expect the default TDE icons to appear.

Interestingly, I got busy with something else for several minutes and when I returned to the fresh desktop the Desktop icons had self-adjusted to TDE icons. The system tray icons were still generic. That the Desktop icons self-adjusted is great but I don't know why that did not happen when the desktop first initialized.
Comment 2 Darrell 2014-12-15 22:09:18 CST 
Created attachment 2397 [details]
Screenshot of system tray icons with gnome-icon-theme icons

Screenshot attached.

I don't know how to resolve these icon bugs except ensuring they all default to TDE icons. Digging deeper indicates the gnome-icon being displayed probably is mimetypes/text-x-generic.png, which probably is the equivalent of TDE's application-vnd.tde.misc.png. I am guessing the system tray icon problem is a code bug --- refer to the patch used in commit 6209a28 for bug 1313.
Comment 3 Darrell 2014-12-15 22:13:14 CST 
Comparing the icon names used in MATE and TDE, the following fixes would be more portable and be more xdg compliant or at least non TDE friendly. These fixes would provide the expected icon when using a TDE icon set but transfer nicely to non TDE icon sets.

Desktop
-------
My Documents:

Create a sym link in all TDE places icon directories: ln -s folder_home.png user-home.png. Change /opt/trinity/share/apps/kdesktop/Desktop/My_Documents Icon=user-home. I am guessing xdg compliant icon sets all contain user-home.png so the Icon= change would satisfy all icon sets including TDE.

Web Browser:

Create a sym link in all TDE apps icon directories: ln -s konqueror.png web-browser.png. Change /opt/trinity/share/apps/kdesktop/Desktop/Web_Browser Icon=web-browser. I am guessing xdg compliant icon sets all contain web-browser.png so the Icon= change would satisfy all icon sets including TDE.

I successfully tested both of the above by manually creating the sym links and editing the desktop files.

While I can create a patch to update the desktop files, I don't know how to create the sym links in the build process.

Before and after screenshots attached.
Comment 4 Darrell 2014-12-15 22:13:53 CST 
Created attachment 2398 [details]
Screenshot of desktop device icons before suggested changes
Comment 5 Darrell 2014-12-15 22:14:11 CST 
Created attachment 2399 [details]
Screenshot of desktop device icons after suggested changes
Comment 6 Darrell 2014-12-15 22:22:57 CST 
Regarding the generic icons for Unmounted NFS share and Mounted removable medium.

TDE uses nfs_mount.png and nfs_unmount.png. The non TDE icon sets do not include such distinctions. Creating sym links and changing nfs_mounted.desktop or nfs_unmounted.desktop Icon= would only half work because non TDE icon sets are not that explicit. They use the same icon for mounted and unmounted. I believe the reason is the other desktops rely on the Places mechanism to recognize whether a device is (un)mounted.

The best we could do is create one sym link, say 'ln -s nfs_mount.png drive-harddisk' and update the nfs_mounted.desktop Icon=drive-harddisk. Users would see a generic icon for unmounted devices.

Or vice-versa.

Likewise for removable medium. The non TDE icon sets do not distinguish between mounted and unmounted. One icon is used because unlike TDE, there is no little green triangle indicator that a device is mounted. Those indications are part of the Places mechanism, usually in the file managers.
Comment 7 Timothy Pearson 2014-12-16 00:19:44 CST 
(In reply to Darrell from comment #3)
> Comparing the icon names used in MATE and TDE, the following fixes would be
> more portable and be more xdg compliant or at least non TDE friendly. These
> fixes would provide the expected icon when using a TDE icon set but transfer
> nicely to non TDE icon sets.
> 
> Desktop
> -------
> My Documents:
> 
> Create a sym link in all TDE places icon directories: ln -s folder_home.png
> user-home.png. Change /opt/trinity/share/apps/kdesktop/Desktop/My_Documents
> Icon=user-home. I am guessing xdg compliant icon sets all contain
> user-home.png so the Icon= change would satisfy all icon sets including TDE.
> 
> Web Browser:
> 
> Create a sym link in all TDE apps icon directories: ln -s konqueror.png
> web-browser.png. Change /opt/trinity/share/apps/kdesktop/Desktop/Web_Browser
> Icon=web-browser. I am guessing xdg compliant icon sets all contain
> web-browser.png so the Icon= change would satisfy all icon sets including
> TDE.
> 
> I successfully tested both of the above by manually creating the sym links
> and editing the desktop files.
> 
> While I can create a patch to update the desktop files, I don't know how to
> create the sym links in the build process.
> 
> Before and after screenshots attached.

When we finish the XDG update no symlinks will be needed.  I just didn't want to make the rest of those (large!) changes before R14.0.0 release, potentially destabilizing our first release in over 2 years in the process. ;-)