By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 2324 - Delete tdeio_iso.desktop
Summary: Delete tdeio_iso.desktop
Status: RESOLVED INVALID
Alias: None
Product: TDE
Classification: Unclassified
Component: tdelibs (show other bugs)
Version: R14.0.x [Trinity]
Hardware: Other Linux
: P5 normal
Assignee: Timothy Pearson
URL:
Depends on:
Blocks:
 
Reported: 2015-01-25 17:33 CST by Darrell
Modified: 2018-08-02 20:31 CDT (History)
3 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
Patch to remove tdeio_iso.desktop (2.32 KB, patch)
2015-01-25 17:33 CST, Darrell 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darrell 2015-01-25 17:33:55 CST 
Created attachment 2432 [details]
Patch to remove tdeio_iso.desktop

In tdelibs/tdeioslave/iso/ there are two konqueror service menu options:

tdeio_iso.desktop
isoservice.desktop

tdeio_iso.desktop creates an 'Open With' menu option of 'ISO9660 Image Viewer'.
isoservice.desktop creates an 'Actions' menu option of 'ISO9660 View'.

Both perform the same basic action: to list the contents of an ISO image in konqueror.

One difference is tdeio_iso.desktop opens the ISO view in a new konqueror instance while isoservice.desktop opens the ISO view in a new konqueror tab, which is more consistent with expected konqueror behavior.

To reduce redundancy, delete tdeio_iso.desktop.
Comment 1 Michele Calgaro 2015-01-25 18:07:46 CST 
No. 
First they are two different categories.
Second, when I right click on an iso image on a folder, I only see the 'Open With' option, not the 'Actions' option.

I suggest to leave everything as is and mark the bug invalid.
Comment 2 Darrell 2015-01-25 21:54:37 CST 
tdeio_iso.desktop is installed in /opt/trinity/share/applnk/.
isoservice.desktop is installed in /opt/trinity/share/apps/konqueror/servicemenus/.

>First they are two different categories.
I don't understand your point. Although the desktop files are different, the two options work the same: to display the contents of an ISO. Definitely redundant.

>I only see the 'Open With' option, not the 'Actions' option.
Interesting.
Comment 3 Darrell 2015-01-25 22:03:11 CST 
I tested this in both Slackware 14.1 and Fedora 21. I see the same two menu options in both systems.
Comment 4 Michele Calgaro 2015-01-25 22:27:48 CST 
>>First they are two different categories.
>I don't understand your point. Although the desktop files are different, the
>two options work the same: to display the contents of an ISO. Definitely
> redundant.
What I meant was that they show up in two different menus ('Open with' and 'Actions'). I do not know if isoservice.desktop is also used somewhere else, but being an action it may well be. Perhaps Tim or Slavek can add their own opinion to these.


>> I tested this in both Slackware 14.1 and Fedora 21. I see the same two menu 
>> options in both systems.
>I tested this in both Slackware 14.1 and Fedora 21. I see the same two menu 
>options in both systems.
Interesting. The iso_service.desktop file is not installed in Debian. Probably a problem with the packaging files. I will take a look later on.
Comment 5 Darrell 2015-01-26 13:30:20 CST 
>What I meant was that they show up in two different menus ('Open with' and
>'Actions').
Oh, okay. That they appear in two different menus is to me confusing, probably more so to non technical users, especially when the two options perform the same exact thing. That is, I do not see any difference in function.

Both desktop files were added to TDE in May 2010 as can be seen in bug 178 and commit 1219be78:

http://git.trinitydesktop.org/cgit/tdelibs/patch/?id=1219be78

I don't know why two desktop files were created, but they were created at the same time and long before the related bugs that are discussed in bug 178.
Comment 6 Michele Calgaro 2015-01-26 19:34:30 CST 
>Both desktop files were added to TDE in May 2010 as can be seen in bug 178 and 
>commit 1219be78
The commit is from Tim, so I guess there was a reason why he added two files instead of one. The best would be to have his opinion on this.
Comment 7 Michele Calgaro 2018-08-02 20:31:20 CDT 
As mentioned, the two files shows up in two different menus.