By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 2328 - Fix KDE->TDE branding in error dialog
Summary: Fix KDE->TDE branding in error dialog
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: tdebase (show other bugs)
Version: R14.0.0 [Trinity]
Hardware: Other Linux
: P5 trivial
Assignee: Timothy Pearson
URL:
Depends on:
Blocks: R14.0.1
  Show dependency tree / graph
 
Reported: 2015-01-26 17:34 CST by Darrell
Modified: 2015-01-27 18:41 CST (History)
4 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
Patch to fix KDE->TDE branding in error dialog (1.12 KB, patch)
2015-01-26 17:34 CST, Darrell 		Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darrell 2015-01-26 17:34:25 CST 
Created attachment 2437 [details]
Patch to fix KDE->TDE branding in error dialog

Fix branding in dialog.
Comment 1 Michele Calgaro 2015-01-27 16:37:11 CST 
The patch looks good. Darrell, you can either push it yourself or provide a "Signed-off-by" clause here and then I can push it.
Comment 2 Darrell 2015-01-27 16:44:42 CST 
>provide a "Signed-off-by" clause
What is that?
Comment 3 Michele Calgaro 2015-01-27 17:01:01 CST 
>>provide a "Signed-off-by" clause
>What is that?
Have a look here: 
http://stackoverflow.com/questions/1962094/what-is-the-sign-off-feature-in-git-for

Any contributor to TDE is now required to sign a TDE CLA
(
https://www.trinitydesktop.org/cla/
http://trinity-devel.pearsoncomputing.net/?0::13900
)
before committing or before his/her contribution is accepted. If you have already done that, you can commit with "git -s" or you can provide a string such as 
Signed-off-by: Name Surname <email address>
that will be used by another committer to push your patch in the correct way.
Comment 4 Darrell 2015-01-27 17:17:42 CST 
How do I add 'Signed-off-by: Name Surname <email address>' directly in the patch?
Comment 5 Michele Calgaro 2015-01-27 17:22:08 CST 
> How do I add 'Signed-off-by: Name Surname <email address>' directly in the 
> patch?
You can just type the sentence here in bugszilla whenever you submit a patch. Or you can commit using 'git -s' which will automatically add the string for you without having to do anything else.
Comment 6 Darrell 2015-01-27 17:33:09 CST 
Pushed in commit ad2dc879.

Please let me know whether I did this correctly.
Comment 7 Michele Calgaro 2015-01-27 18:06:51 CST 
> Please let me know whether I did this correctly.
That's good. In general though the Sign-off-by clause is inserted as the last line of the commit message ;-)

Ported to r14.0.x branch in commit ed4336e.
Comment 8 Slávek Banko 2015-01-27 18:16:50 CST 
Guys, thank you both.
Comment 9 Darrell 2015-01-27 18:26:11 CST 
>the Sign-off-by clause is inserted as the last line of the commit message
I noticed that when I typed the comment. How do I force the sign-off to the end?

I used the following: git commit -a -s
Comment 10 Michele Calgaro 2015-01-27 18:41:01 CST 
>>the Sign-off-by clause is inserted as the last line of the commit message
>I noticed that when I typed the comment. How do I force the sign-off to the end?
It may seems silly, but just type the commit message above the sign-off sentence in your editor :-)