By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 2409 - Build issue: kftpgrabber fails in rpmlint
Summary: Build issue: kftpgrabber fails in rpmlint
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: non-core programs (show other bugs)
Version: R14.0.x [Trinity]
Hardware: Other Linux
: P5 normal
Assignee: Michele Calgaro
URL:
Depends on:
Blocks: R14.0.7
  Show dependency tree / graph
 
Reported: 2015-04-03 15:33 CDT by Francois Andriot
Modified: 2019-03-31 07:48 CDT (History)
4 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
kftpgrabber: fix rpmlint check test (1.38 KB, patch)
2015-04-03 15:35 CDT, Francois Andriot 		Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Francois Andriot 2015-04-03 15:33:21 CDT 
Kftpgrabber builds, but rpmlint rejects the package.

There are 2 issues:
- a function not returning any value
- 2 memset always causing buffer overflow
Comment 1 Francois Andriot 2015-04-03 15:35:08 CDT 
Created attachment 2474 [details]
kftpgrabber: fix rpmlint check test

The attached patches fixes both issues.
(patches taken from opensuse-kde3)
Comment 2 Slávek Banko 2015-05-25 18:17:42 CDT 
I fear that this patch is incorrect. I tried simple code:

#include <stdio.h>
#include <stdlib.h>

main()
 {
  char* a10 = (char*) malloc(10);
  char s10[10];

  printf("size allocated: %d\n", sizeof a10);
  printf("size static: %d\n", sizeof s10);
 }

Compiled using g++ (on 32bit system) returns:

size allocated: 4
size static: 10


Therefore I fear that the adjustments contained in patch are incorrect:

memset(o_message, 0, sizeof o_message);
memset(o_output, 0, sizeof o_output);

Variables o_message and o_output are allocated by malloc, I excpect, that sizeof will return size of pointer - 4 (on 32bit system).
Comment 3 Michele Calgaro 2019-03-15 10:49:51 CDT 
Proposed fix here: 
https://mirror.git.trinitydesktop.org/gitea/TDE/kftpgrabber/pulls/1