By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 2481 - krusader recreate useractions.xml from useraction_examples.xml
Summary: krusader recreate useractions.xml from useraction_examples.xml
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: tdebase (show other bugs)
Version: R14.0.0 [Trinity]
Hardware: amd64 Debian Wheezy
: P5 normal
Assignee: Timothy Pearson
URL:
Depends on:
Blocks: R14.0.3
  Show dependency tree / graph
 
Reported: 2015-07-20 19:22 CDT by pitriss
Modified: 2016-01-21 20:40 CST (History)
2 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description pitriss 2015-07-20 19:22:39 CDT 
how to reproduce:

delete some useractions from krusader. for example by built in editor.. close and reopen krusader, useractions will be reset to content of useraction_examples.xml

Maybe will be good to change name of this file to useraction.xml.example to not be taken as template for recreating user actions?
Comment 1 Slávek Banko 2015-09-13 11:18:13 CDT 
I looked at the problem more closely.

Complications are not names ending in XML, but the fact that are deliberately loaded both files "krusader/useractions.xml" and "krusader/useraction_examples.xml" - see method UserAction::readAllFiles (krusader/UserAction/useraction.cpp:78).

Instead of changing the name of the file will be needed to deal with the option of whether to load or not to load examples.
Comment 2 pitriss 2016-01-15 08:47:14 CST 
(In reply to Slávek Banko from comment #1)
> I looked at the problem more closely.
> 
> Complications are not names ending in XML, but the fact that are
> deliberately loaded both files "krusader/useractions.xml" and
> "krusader/useraction_examples.xml" - see method UserAction::readAllFiles
> (krusader/UserAction/useraction.cpp:78).
> 
> Instead of changing the name of the file will be needed to deal with the
> option of whether to load or not to load examples.

Hmm hmm and how about simply load examples only when krusaderrc is not exist? Simple and IMHO it also does what examples should do..
Comment 3 Slávek Banko 2016-01-21 20:40:53 CST 
(In reply to pitriss from comment #2)
> (In reply to Slávek Banko from comment #1)
> > I looked at the problem more closely.
> > 
> > Complications are not names ending in XML, but the fact that are
> > deliberately loaded both files "krusader/useractions.xml" and
> > "krusader/useraction_examples.xml" - see method UserAction::readAllFiles
> > (krusader/UserAction/useraction.cpp:78).
> > 
> > Instead of changing the name of the file will be needed to deal with the
> > option of whether to load or not to load examples.
> 
> Hmm hmm and how about simply load examples only when krusaderrc is not
> exist? Simple and IMHO it also does what examples should do..

Yes, the proposal makes sense. Examples will now be loaded only if the user has no actions defined.

Fixed in GIT hash 76ca48c4 (master) and a9cd8b8b (r14.0.x).