By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 2493 - Build issue: libksquirrel fails rpmlint test
Summary: Build issue: libksquirrel fails rpmlint test
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: non-core programs (show other bugs)
Version: R14.0.1 [Trinity]
Hardware: Other Linux
: P5 normal
Assignee: Francois Andriot
URL:
Depends on:
Blocks: R14.0.2
  Show dependency tree / graph
 
Reported: 2015-07-31 18:05 CDT by Francois Andriot
Modified: 2015-09-15 15:01 CDT (History)
3 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
libksquirrel: fix buffer overflow (372 bytes, patch)
2015-07-31 18:06 CDT, Francois Andriot 		Details | Diff
libksquirrel: fix buffer overflow (2) (1.48 KB, patch)
2015-07-31 18:07 CDT, Francois Andriot 		Details | Diff
libksquirrel: fix build warnings (1.67 KB, patch)
2015-07-31 18:08 CDT, Francois Andriot 		Details | Diff
libksquirrel: fix potential buffer overflow (619 bytes, patch)
2015-09-13 09:30 CDT, Slávek Banko 		Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Francois Andriot 2015-07-31 18:05:03 CDT 
Rpmlint report says:

[  130s] I: Program is likely to break with new gcc. Try -fno-strict-aliasing.
[  130s] W: trinity-libksquirrel strict-aliasing-punning dds.cpp:567, 577
[  130s] W: trinity-libksquirrel strict-aliasing-punning fmt_codec_hdr.cpp:139
[  130s] 
[  130s] I: Statement is overflowing a buffer
[  130s] E: trinity-libksquirrel bufferoverflow /usr/include/bits/string3.h:120
Comment 1 Francois Andriot 2015-07-31 18:06:53 CDT 
Created attachment 2544 [details]
libksquirrel: fix buffer overflow

This patch is not mine.
I do not remember where this patch comes from, probably opensuse KDE3.
Comment 2 Francois Andriot 2015-07-31 18:07:34 CDT 
Created attachment 2545 [details]
libksquirrel: fix buffer overflow (2)

Another patch
Comment 3 Francois Andriot 2015-07-31 18:08:12 CDT 
Created attachment 2546 [details]
libksquirrel: fix build warnings

3rd and last patch to make libksquirrel pass rpmlint test.
Comment 4 Slávek Banko 2015-09-13 09:30:03 CDT 
Created attachment 2566 [details]
libksquirrel: fix potential buffer overflow

François, I've modified the patch. Instead of a hard coded 80 was applied constant. Please can you test whether rpmlint is satisfied with this patch?
Comment 5 Slávek Banko 2015-09-15 15:01:31 CDT 
Fixed in GIT hashes 53090f76 and 5fdf91b7 (master), ae5ba4db and 44ada1e1 (r14.0.x).