By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 2497 - Kvirc: irc protocol files not included in Debian/Ubuntu packages
Summary: Kvirc: irc protocol files not included in Debian/Ubuntu packages
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: other (any) (show other bugs)
Version: R14.0.1 [Trinity]
Hardware: Other Linux
: P1 major
Assignee: Slávek Banko
URL:
Depends on:
Blocks: R14.0.1
  Show dependency tree / graph
 
Reported: 2015-08-03 19:08 CDT by Michele Calgaro
Modified: 2015-08-04 11:52 CDT (History)
3 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
Fix installation of kvirc protocol files on Debian and Ubuntu (2.24 KB, patch)
2015-08-03 20:14 CDT, Slávek Banko 		Details | Diff
alternative patch for debian/rules (2.47 KB, patch)
2015-08-04 01:58 CDT, Michele Calgaro 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michele Calgaro 2015-08-03 19:08:33 CDT 
In Debian/Ubuntu kvirc packages, files irc.protocol and irc6.protocol are not included, causing problems at installation/update.

During building time, those files ends up in 'debian/tmp/opt/trinity/share/services' and not in 'debian/tmp/opt/trinity/share/kvirc/3.4.0/services'.
Comment 1 Slávek Banko 2015-08-03 20:14:28 CDT 
Created attachment 2548 [details]
Fix installation of kvirc protocol files on Debian and Ubuntu

I found two mistakes. Outside move from /opt/trinity/share/services to /opt/trinity/share/kvirc/3.4/services, in postinst / prerm scripts was expected directory with 3.4.0 instead of 3.4.

Now I'm doing the test on my builder, then will be upload to build-farm.
Comment 2 Michele Calgaro 2015-08-04 01:58:24 CDT 
Created attachment 2549 [details]
alternative patch for debian/rules

Alternative patch proposed. Do not use 'mv' after building, just call configure with an additional option.

BTW, current options of configure are not recognized. I have left them in so that in future we can check more in detail and update/remove as required.
Comment 3 Michele Calgaro 2015-08-04 01:59:47 CDT 
The alternative patch works ok in Debian Stretch.
Comment 4 Slávek Banko 2015-08-04 03:06:04 CDT 
(In reply to Michele Calgaro from comment #3)
> The alternative patch works ok in Debian Stretch.

Your patch looks cleaner, but I see a potential problem. The services path from configure is also registered in kvirc-config script - is installed in the package kvirc-trinity-dev. But /opt/trinity/share/kvirc/3.4/services not the right path to services at runtime. This path is just a hack to install - for use alternatives.

I therefore believe that the patch with the move in rules, although it is not so clear, is safer. What's your opinion?
Comment 5 Michele Calgaro 2015-08-04 07:44:01 CDT 
>Your patch looks cleaner, but I see a potential problem. The services path from 
>configure is also registered in kvirc-config script - is installed in the 
>package kvirc-trinity-dev. But /opt/trinity/share/kvirc/3.4/services not the 
>right path to services at runtime. This path is just a hack to install - for 
>use alternatives.
>I therefore believe that the patch with the move in rules, although it is not 
>so clear, is safer. What's your opinion?
The patch with the 'mv' is also ok for me. I hadn't seen the fact that kdeservicedir gets registered in kvirc-config, although it is not accessible since there is no option to get it returned from the script.
Comment 6 Slávek Banko 2015-08-04 11:28:16 CDT 
(In reply to Michele Calgaro from comment #5)
> >Your patch looks cleaner, but I see a potential problem. The services path from 
> >configure is also registered in kvirc-config script - is installed in the 
> >package kvirc-trinity-dev. But /opt/trinity/share/kvirc/3.4/services not the 
> >right path to services at runtime. This path is just a hack to install - for 
> >use alternatives.
> >I therefore believe that the patch with the move in rules, although it is not 
> >so clear, is safer. What's your opinion?
> The patch with the 'mv' is also ok for me. I hadn't seen the fact that
> kdeservicedir gets registered in kvirc-config, although it is not accessible
> since there is no option to get it returned from the script.

Because the patch with 'mv' will not cause undesirable side effects, I will push this patch.

In any case, thank you for bug report and good alternative patch.
Comment 7 Slávek Banko 2015-08-04 11:52:17 CDT 
Fixed in tde-packaging: 6253ed4f (master), 165ddae6 (r14.0.x).