By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 2528 - Add support for subversion 1.9
Summary: Add support for subversion 1.9
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: other (any) (show other bugs)
Version: R14.0.1 [Trinity]
Hardware: All All
: P5 major
Assignee: Michele Calgaro
URL:
Depends on:
Blocks: R14.0.2
  Show dependency tree / graph
 
Reported: 2015-09-13 05:54 CDT by Slávek Banko
Modified: 2015-10-19 09:46 CDT (History)
3 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
tdevelop patch for FTBFS (3.78 KB, patch)
2015-10-18 01:57 CDT, Michele Calgaro 		Details | Diff
tdesdk patch (17.79 KB, patch)
2015-10-18 04:20 CDT, Michele Calgaro 		Details | Diff
Updated tdevelop patch which include the license_svn file as well (18.60 KB, patch)
2015-10-18 04:22 CDT, Michele Calgaro 		Details | Diff
tdesvn patch (25.34 KB, patch)
2015-10-18 05:05 CDT, Michele Calgaro 		Details | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Slávek Banko 2015-09-13 05:54:17 CDT 
Subversion 1.9 hid some previously published internal structures. This causing FTBFS in some packages - tdesdk, tdevelop, tdesvn.

A similar problem also have some other packages in the distribution:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=796466
Comment 1 Michele Calgaro 2015-10-14 06:39:26 CDT 
I will tackle this bug. It may take a while because I first need to do a full local rebuild on my system to see what is ok and what is FTBFS.

Upgraded to major because we can not release the next r14.0.2 if packages such as tdevelop and tdesdk FTBFS.
Comment 2 Slávek Banko 2015-10-14 08:34:21 CDT 
(In reply to Michele Calgaro from comment #1)
> I will tackle this bug. It may take a while because I first need to do a
> full local rebuild on my system to see what is ok and what is FTBFS.
> 
> Upgraded to major because we can not release the next r14.0.2 if packages
> such as tdevelop and tdesdk FTBFS.

I would like to clarify a bit: Because the problem at this point affects only Debian Stretch, and because the final r14.0.2 "can not" be officially released for "testing" version of the distribution, it is not necessary at this point be considered this bug as blocking for r14.0.2. That's my opinion.
Comment 3 Slávek Banko 2015-10-14 08:47:45 CDT 
For inspiration (because i have traditionally not oriented in the KDE GIT, so I can not find the appropriate commit):

https://git.reviewboard.kde.org/r/124783/diff/1#index_header
Comment 4 Michele Calgaro 2015-10-14 09:01:57 CDT 
>I would like to clarify a bit: Because the problem at this point affects only >Debian Stretch, and because the final r14.0.2 "can not" be officially released >for "testing" version of the distribution, it is not necessary at this point be >considered this bug as blocking for r14.0.2. That's my opinion.
I didn't know the problem was only in stretch. Dropped to major. 


>For inspiration (because i have traditionally not oriented in the KDE GIT, so I >can not find the appropriate commit):
>https://git.reviewboard.kde.org/r/124783/diff/1#index_header
Yes, I have already seen this. But thanks anyway.
Comment 5 Michele Calgaro 2015-10-18 01:57:11 CDT 
Created attachment 2578 [details]
tdevelop patch for FTBFS

Slavek,
the attached patch fixes TDevelop FTBFS on my local non fully updated system. 
Before I push it into GIT, could you test whether it builds correctly also in an updated system?
Also please check versions that still use svn 1.8 because the patch contains small changes that 
affect the building process with svn < 1.9
Comment 6 Michele Calgaro 2015-10-18 04:20:22 CDT 
Created attachment 2579 [details]
tdesdk patch

Equivalent patch for tdesdk.
Slavek, please test this as well.
Comment 7 Michele Calgaro 2015-10-18 04:22:45 CDT 
Created attachment 2580 [details]
Updated tdevelop patch which include the license_svn file as well

Slavek, no code changes between the first patch and this one. I only added the license file for the svn code that was used.
Comment 8 Michele Calgaro 2015-10-18 05:05:19 CDT 
Created attachment 2581 [details]
tdesvn patch

And finally the patch for tdesvn. Please test :-)
Comment 9 Slávek Banko 2015-10-18 09:11:21 CDT 
(In reply to Michele Calgaro from comment #6)
> Created attachment 2579 [details]
> tdesdk patch
> 
> Equivalent patch for tdesdk.
> Slavek, please test this as well.

All 46 builds of tdesdk successfully done.
Comment 10 Slávek Banko 2015-10-18 10:21:27 CDT 
(In reply to Michele Calgaro from comment #8)
> Created attachment 2581 [details]
> tdesvn patch
> 
> And finally the patch for tdesvn. Please test :-)

All 46 builds of tdesvn successfully done.
Comment 11 Michele Calgaro 2015-10-18 11:07:31 CDT 
>All 46 builds of tdesdk successfully done.
>All 46 builds of tdesvn successfully done.
Thanks a lot for testing Slavek. I will push tomorrow, now it is sleep time for me. In the mean time I guess tdevelop will complete building as well.
Comment 12 Slávek Banko 2015-10-18 11:14:19 CDT 
(In reply to Michele Calgaro from comment #11)
> >All 46 builds of tdesdk successfully done.
> >All 46 builds of tdesvn successfully done.
> Thanks a lot for testing Slavek. I will push tomorrow, now it is sleep time
> for me. In the mean time I guess tdevelop will complete building as well.

Yes, builds are now underway - for now 8 successfull (squeeze, wheezy, jessie, stretch, trusty), 36 pending :)
Comment 13 Slávek Banko 2015-10-18 20:10:46 CDT 
(In reply to Slávek Banko from comment #12)
> (In reply to Michele Calgaro from comment #11)
> > >All 46 builds of tdesdk successfully done.
> > >All 46 builds of tdesvn successfully done.
> > Thanks a lot for testing Slavek. I will push tomorrow, now it is sleep time
> > for me. In the mean time I guess tdevelop will complete building as well.
> 
> Yes, builds are now underway - for now 8 successfull (squeeze, wheezy,
> jessie, stretch, trusty), 36 pending :)

Previous numbers were obviously wrong - pending was 38, but now it is:

All 46 of tdevelop builds successfully done.
Comment 14 Michele Calgaro 2015-10-19 09:45:58 CDT 
Pushed in the following commits.
Slavek, thanks again for testing in all those builds.

tdevelop
e392d02, db397b2 (master)
b7feb0f, fb4b4ab (r14.0.x)

tdesdk
e4d5087 (master), 2ac1aa9 (r14.0.x)

tdesvn
e42c189 (master), e665050 (r14.0.x)